Commit Graph

112865 Commits

Author SHA1 Message Date
Arda Güçlü
369534c6ec
kubectl wait: wire generic context (#114574)
* Wire generic context to better handle timeout

* Add integration test for wait timeout

* kubectl wait: Fix integration test always passing issue

Currently, `kubectl wait` integration test always passes even if
it gets an error. Problem is object check is done after errexit is
turned off.

This PR redirects error to output and correctly assures that
object is expected status and if it is not, test should fail.
2022-12-19 09:21:56 -08:00
Kubernetes Prow Robot
0783cf49e8
Merge pull request #114291 from MaxHorstmann/master
#79612 fix(client-go): return error in fake discovery
2022-12-19 09:21:44 -08:00
Maciej Szulik
8e3e3479d9
Skip .metadata.manageFields when describing unkown resources 2022-12-19 17:31:30 +01:00
kidddddddddddddddddddddd
e789beb213 errMsg 2022-12-19 23:52:06 +08:00
Kubernetes Prow Robot
239f0049f6
Merge pull request #114579 from aojea/metrics_context
pass context to gomega
2022-12-19 06:21:44 -08:00
Paco Xu
62a2c10c68 Add v1.26.0 API testdata 2022-12-19 21:46:20 +08:00
Arda Güçlü
6b7c365f8f Embed context deadline exceeded in error to let errors.Is can work
Currently, watch package embeds context deadlineexceeded error
in it's own error using `%v`, as can be seen in here;

`fmt.Errorf("UntilWithSync: unable to sync caches: %v", ctx.Err())`

However, consumers of this function can not use
`errors.Is(err, context.DeadlineExceeded)` due this `%v`.

To let consumers can distinguish context deadlineexceeded errors,
this PR changes error embedding format to `%w`.
2022-12-19 16:16:53 +03:00
Antonio Ojea
e0a23577d2 pass context to gomega
Change-Id: Ibef02a52d8922984a09efa48361b9876fc91287c
2022-12-19 13:14:02 +00:00
Kubernetes Prow Robot
a864583905
Merge pull request #114573 from pohly/e2e-ginkgo-timeout-fixes
e2e ginkgo timeout fixes, II
2022-12-19 04:43:44 -08:00
Kubernetes Prow Robot
c2eb6e69c4
Merge pull request #114576 from pohly/e2e-ginkgo-timeout-fixes-III
e2e storage: fix "Stress with local volumes [Serial] should be able to process many pods and reuse local volumes"
2022-12-19 03:37:44 -08:00
Patrick Ohly
4d7e2894b2 e2e storage: fix "Stress with local volumes [Serial] should be able to process many pods and reuse local volumes"
The background goroutine was started with the context from ginkgo.BeforeEach,
which then led to "context canceled" errors. While at it, the entire goroutine
start/stop gets moved into the BeforeEach and simplified.
2022-12-19 11:23:53 +01:00
Kubernetes Prow Robot
cbd16cf131
Merge pull request #114569 from aojea/e2e_taint_informer
e2e node taints stop controller with context
2022-12-19 01:57:43 -08:00
Patrick Ohly
1bc24630da e2e scheduling: remove redundant stopCh
The ctx.Done() channel associated with the current test can be used
instead. This is a simplification, both approaches work.
2022-12-19 10:00:00 +01:00
Patrick Ohly
29d6d03a3c e2e scheduling: fix scope of context.WithTimeout
The original intend from v1.26.0 was to only apply the timeout to the following
cache.WaitForCacheSync.
2022-12-19 10:00:00 +01:00
Kubernetes Prow Robot
03bfbdd8aa
Merge pull request #114455 from SataQiu/fix-kubeadm-2022121302
kubeadm: fix the bug that kubeadm always do CRI detection even if it is not required by phase subcommand
2022-12-19 00:51:44 -08:00
Chok Yip Lau
65eb7f1e0c fixed error 2022-12-18 22:58:23 -05:00
Chok Yip Lau
cdd84a28bf Removed factory from apply command flag struct 2022-12-18 22:45:58 -05:00
dengyufeng2206
df49c9f56f fix test order in controller/openapi/builder/builderst.go 2022-12-19 09:20:06 +08:00
Kubernetes Prow Robot
789dc88fd5
Merge pull request #114567 from aojea/e2e_dns_context
e2e dns don't fail if configmap does not exist
2022-12-18 16:05:53 -08:00
Kubernetes Prow Robot
948d5b8d52
Merge pull request #114565 from aojea/fix_e2e_after_contexts
cleanup e2e kubectl  cli tests
2022-12-18 16:05:42 -08:00
Antonio Ojea
8357eead06 e2e node tains stop controller with context
Informers controllers must use the stop channel, and not
cancel the context of the List/Watch.

Change-Id: I42e4ae4bad4fe6ad0da6fe1b3990ebe56c8eabd9
2022-12-18 22:44:20 +00:00
Kubernetes Prow Robot
76522eb1a3
Merge pull request #114559 from liggitt/gofmt
Fix indentation/spacing in comments to render correctly in godoc
2022-12-18 13:47:45 -08:00
Antonio Ojea
5d8f745e86 e2e dns don't fail if configmap does not exist
don't fail on cleanup if the configmap for kube-dns does not exist

Change-Id: Ia56d9f590baba374e0b687aeda71d547899b1713
2022-12-18 19:23:36 +00:00
Antonio Ojea
e05e96bfdd e2e kubect run tests
These tests create their own pods, however, they were inside a block
that was always creating a pod, that was not used later on the tests,
but can influence on the conditions asserted to succeed the test.

Change-Id: I3bb9a0f123fb0766d75934ef8e197f92e3f5f3b8
2022-12-18 16:22:15 +00:00
Kubernetes Prow Robot
7cf7cc2dfb
Merge pull request #114564 from pohly/e2e-ginkgo-timeout-fixes
e2e ginkgo timeout fixes
2022-12-18 08:11:42 -08:00
Patrick Ohly
2296fc4b1f e2e apps: fix "context canceled" error
Using the ctx of the ginkgo.BeforeEach in callbacks that are invoked after the
BeforeEach is done causes "context canceled" errors. Previously, this code used
context.TODO(). The best solution is to create a new context and cancel it
during test cleanup, then that context can be used for the API calls and as
stop channel.
2022-12-18 16:10:15 +01:00
Patrick Ohly
02b6b6520a e2e kubectl: increase wait timeout
After adding error checking in df5d84ae81, the "[sig-cli] Kubectl client
Simple pod should return command exit codes [Slow] running a failing command
without --restart=Never, but with --rm" test was found to time out.

Doubling the timeout might help. Alternatively, the entire
WaitForPodToDisappear could get removed, which would make this scenario similar
to the others which also don't wait.
2022-12-18 16:10:15 +01:00
Antonio Ojea
c1580e960d e2e kubectl test cleanup
the test uses a BeforeEach block to create a pod with the name defined
but the simplePodName variables, however, some test use the value of
the variable directly.

To avoid future problems use the variable name instead of the value on
all tests.

Change-Id: I21a01019d91fe5ae7e35566184420001978ce355
2022-12-18 13:57:41 +00:00
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc 2022-12-17 23:27:38 -05:00
Kubernetes Prow Robot
2ca74f2885
Merge pull request #114545 from TommyStarK/integration-tests-code-coverage-hint
Makefile: Add example of how to run integration tests and get code coverage report
2022-12-17 12:57:43 -08:00
Kubernetes Prow Robot
3459646741
Merge pull request #114553 from pacoxu/github.com/Microsoft/hcsshim
update github.com/Microsoft/hcsshim to v0.8.25
2022-12-17 11:51:42 -08:00
Paco Xu
1cfbc8768b github.com/Microsoft/hcsshim to v0.8.25 2022-12-17 22:08:54 +08:00
Sean Sullivan
21393f1b1d Fixes prune for server-side applied objects 2022-12-16 23:26:28 -08:00
Kubernetes Prow Robot
fdafd50085
Merge pull request #113318 from pacoxu/learner-mode
kubeadm: enable etcd's learner mode when joining etcd members
2022-12-16 21:55:41 -08:00
Paco Xu
37f5da904b kubeadm: remove nested loops for member promotion 2022-12-17 12:40:15 +08:00
Kubernetes Prow Robot
7f7bf68c7c
Merge pull request #111178 from lucming/cleanup
clean up code
2022-12-16 19:17:52 -08:00
Kubernetes Prow Robot
112a7a590c
Merge pull request #110723 from yangjunmyfm192085/fixklog
Fix incorrect log information and log structure
2022-12-16 19:17:41 -08:00
Kubernetes Prow Robot
038d983769
Merge pull request #114505 from aojea/service_warnings
Services API: warnings on IP addresses
2022-12-16 18:07:52 -08:00
Kubernetes Prow Robot
2f2021e208
Merge pull request #114412 from thockin/api_warn_workloads_name_not_dnslabel
Issue API warnings when workload names are not DNS labels
2022-12-16 18:07:41 -08:00
Maxim Patlasov
fcf89f66a9 Fix installDriverToCSINode(): we should not skip CSINode update if Allocatable.Count changed 2022-12-16 18:02:59 -08:00
Kubernetes Prow Robot
a93eda9db3
Merge pull request #112923 from pohly/e2e-ginkgo-timeouts
e2e: ginkgo timeouts: use context provided by ginkgo
2022-12-16 16:59:52 -08:00
Sunny Song
5e8ca18308 Add pod to dsw if termination is not completed during reconstruction #issues/113979 2022-12-16 16:32:34 -08:00
Kubernetes Prow Robot
9edd4d86c8
Merge pull request #114522 from zshihang/master
lock LegacyServiceAccountTokenNoAutoGeneration
2022-12-16 14:24:32 -08:00
Kubernetes Prow Robot
1ccf71ec03
Merge pull request #114515 from endocrimes/dani/reviewer
sig-node-reviewers: add endocrimes
2022-12-16 14:24:20 -08:00
Kubernetes Prow Robot
f11e9aaf10
Merge pull request #113929 from howardjohn/endpointslice/use-optimized-set
endpoints: remove obsolete ServiceSelectorCache
2022-12-16 14:24:09 -08:00
Kubernetes Prow Robot
0f7409a230
Merge pull request #114190 from tkashem/cors-refactor
refactor CORS handler
2022-12-16 13:08:09 -08:00
Tim Hockin
8f62b94991
cronjob: API warn when name is not DNS label 2022-12-16 13:08:08 -08:00
Tim Hockin
fec8e721b2
job: API warn when name is not DNS label 2022-12-16 13:07:42 -08:00
Tim Hockin
b65cec86eb
deployment: API warn when name is not DNS label 2022-12-16 13:07:13 -08:00
Tim Hockin
820e2fff0d
rs: API warn when name is not DNS label 2022-12-16 13:06:43 -08:00