Commit Graph

633 Commits

Author SHA1 Message Date
Miciah Masters
8aa299da90 glog.Warning -> glog.Warningf
Fix three places where glog.Warning is used with a formatted string.
2015-08-19 16:22:28 -04:00
Robert Bailey
ca168ce285 Merge pull request #12262 from jgriffiths1993/hf-12261
Replace Port with NodePort for creating LB members
2015-08-18 09:14:30 -07:00
Justin Santa Barbara
907090a777 Move new files into pkg/cloudprovider/providers/aws/
They were not caught by the general reorg because they weren't on
master.
2015-08-17 08:59:29 -04:00
Justin Santa Barbara
d947a8f78b Update imports to new k8s.io style 2015-08-17 08:58:46 -04:00
Justin Santa Barbara
08e904ad96 AWS: Configure LoadBalancer health checks
ELB will automatically create a health check, but if we update the
listeners the old health check port sticks around, and all the instances
are marked offline.

Update the health-checks to match the listeners: we just check the first
valid service port, with some hard-coded options for timeouts / retries etc.
2015-08-17 08:58:46 -04:00
Justin Santa Barbara
924350d5f6 AWS: Make load balancer creation idempotent on AWS
This turned out to be a little convoluted, but is needed because deleting an ELB on AWS
is a painful UX - it won't have the same endpoint when it is recreated.

Also started splitting the provider into files, but only for new functions (so far!)
2015-08-17 08:58:46 -04:00
Justin Santa Barbara
87df1d6fb6 Change CreateTCPLoadBalancer -> EnsureTCPLoadBalancer; implementations auto-delete if already exists
Previously the servicecontroller would do the delete, but by having the cloudprovider
take that task on, we can later remove it from the servicecontroller, and the
cloudprovider can do something more efficient.
2015-08-17 08:58:45 -04:00
Joshua Griffiths
a9aa2c6acc Replace Port with NodePort for creating LB members 2015-08-17 08:47:00 +01:00
CJ Cullen
e20467afcb Clean up GCE metadata calls. Remove GetNodeResources from all providers. 2015-08-14 07:29:52 -07:00
Sebastien LAWNICZAK
be5f9094d0 Fix : do not try to delete floatingIP if it does not exists 2015-08-13 15:51:06 +02:00
Sebastien LAWNICZAK
65c23ea0e7 Add floatingIP allocation for LB creation on openstack 2015-08-13 15:41:59 +02:00
Bryan Stenson
9541414742 create cloudprovider "providers" package
move all providers into new package
    update all references to old package path
2015-08-11 22:36:51 -07:00
Kris Rousey
565189f5b8 Correcting all go vet errors 2015-08-11 13:55:37 -07:00
CJ Cullen
1f3c322ded Merge pull request #12438 from derekparker/handle-fqdn-gce
Handle full hostname when computing host tag on GCE
2015-08-11 10:11:23 -07:00
Filip Grzadkowski
38c3e351d8 Merge pull request #12203 from jgriffiths1993/subnetid-vip
Pass SubnetID to vips.Create()
2015-08-11 10:59:56 +02:00
Alex Robinson
cd3c3fe479 Merge pull request #12373 from cjcullen/network
Use full URLs for GCE networks
2015-08-10 14:21:42 -07:00
Veres Lajos
9f77e49109 typofix - https://github.com/vlajos/misspell_fixer 2015-08-08 22:31:48 +01:00
Derek Parker
48fadc1570 Handle full hostname when computing host tag on GCE
The current code assumes the full domain name will not be included,
which is not always the case. This patch adds support for computing the
host tag from a fully qualified domain name.
2015-08-08 10:20:29 -05:00
CJ Cullen
5882c35e45 Use full URLs for GCE networks 2015-08-07 14:58:28 -07:00
Mike Danese
17defc7383 run gofmt on everything we touched 2015-08-05 17:52:56 -07:00
Mike Danese
8e33cbfa28 rewrite go imports 2015-08-05 17:30:03 -07:00
Joshua Griffiths
950bc8401b Check for nil, not unspecified 2015-08-05 18:28:25 +01:00
Eric Paris
b4fb24f4bd Move from code.google.com to google.golang.org for google-api-go-client 2015-08-04 20:08:55 -04:00
Joshua Griffiths
c911df6b46 Pass SubnetID to vips.Create() 2015-08-04 14:51:22 +01:00
gmarek
d27ad5b714 Controller codebase refactoring 2015-08-03 17:06:25 +02:00
gmarek
4e772738ca Emit event when NodeController is evicting Pods. 2015-08-03 10:19:51 +02:00
Mike Danese
20129b0adf Merge pull request #12028 from cjcullen/kl2
Make gce.ExternalID() use metadata server when requesting current external ID
2015-07-31 15:43:58 -07:00
Mike Danese
ad90c92693 Merge pull request #12042 from cjcullen/retry
Make gce operation polling more robust.
2015-07-31 14:50:37 -07:00
CJ Cullen
a4c64a5829 Make gce.ExternalID() use metadata server when requesting current external ID
Use the already computed instanceID instance of looking it up again.
2015-07-31 12:01:45 -07:00
Mike Danese
7a1d4477db Merge pull request #12029 from iterion/use-external-id-for-routes
Use external id when reconciling routes
2015-07-31 10:23:11 -07:00
CJ Cullen
983748b2e2 Make gce operation polling more robust.
Only fail the operation if we cannot poll it 3 consecutive times.
2015-07-31 10:08:41 -07:00
Adam Sunderland
75674e7f4b Fetch AWS PrivateDNSName for route recon 2015-07-31 10:57:38 -05:00
Mike Danese
dd3195084d Merge pull request #11992 from pmorie/nodecontroller-now
Accurately report ts used to make decisions in node-controller.go
2015-07-30 11:18:06 -07:00
Mike Danese
1ae4a94257 Merge pull request #11949 from justinsb/golang_switch_type_autocast
Cleanup #11029 to use go autocast-after-type-switch
2015-07-30 09:54:33 -07:00
Mike Danese
1b84fb7d74 make testclient threadsafe by guarding internal state with accessors 2015-07-29 16:17:17 -07:00
Paul Morie
1ff8964c20 Accurately report ts used to make decisions in node-controller.go 2015-07-29 17:11:19 -04:00
Justin Santa Barbara
edd21d1e7a Cleanup #11029 to use go autocast-after-type-switch
(thanks to brendandburns for the suggestion)
2015-07-28 12:10:31 -04:00
Daniel Smith
8d5a6b063c Merge pull request #11029 from justinsb/fix_aws_security_group_races
AWS: Fix security group races
2015-07-27 16:15:43 -07:00
Alex Robinson
60611c253e Add a resync period for services in the service controller.
This should ensure all load balancers get deleted even if a reordering of
watch events causes us to strand one after its service has been deleted,
because the sync will notice that the service controller's cache has a
service in it that no longer exists in the apiserver.

It could still leak in the case that the controller manager is killed
between when it leaks something and the sync runs, but this should
improve things.
2015-07-27 18:03:13 +00:00
Justin Santa Barbara
23a190cd97 Fixes per review
Primarily go style issues; also a TODO that really exponential backoff
is the correct policy for API call retries.
2015-07-26 18:30:02 -04:00
Justin Santa Barbara
092d407a48 AWS: Fix race in security-group read/create
We need to find the ID for a named security group, or create a new one.

We do this by listing the security groups, and then doing a create if we
cannot find one.  This is a race though; against another thread if the
AWS API were consistent, but generally because the AWS API is actually
eventually consistent.

We wrap it in a retry loop.
2015-07-26 18:16:05 -04:00
Justin Santa Barbara
d7bace23ff AWS: Fix race-condition in tagging of security group
When we create a security-group in the AWS API, there is sometimes
a delay before we can tag it (the AWS API is eventually consistent).

So we wrap CreateTags in a simple retry loop.
2015-07-26 18:16:05 -04:00
Vish Kannan
2a5a6b99cb Merge pull request #10635 from smarterclayton/cloud_provider_should_err
Cloud provider should return an error
2015-07-23 17:50:45 -07:00
Daniel Smith
15d50f4211 Fix part of #9382 2015-07-23 15:48:45 -07:00
Alex Robinson
b0351ff266 Detect if UpdateTCPLoadBalancer left its GCE target pool in an incorrect state. 2015-07-17 19:01:21 +00:00
Alex Robinson
e943c47e68 Fix issue of comparing instance URLs with different project ID representations
in GCE target pools.
2015-07-15 21:24:45 +00:00
Brendan Burns
a8f02e5472 Automatically open a firewall when creating a GCE load balancer. 2015-07-10 14:35:29 -07:00
Alex Robinson
b52c6f673e Increase the rate limiting of GCE's token source. The burst being at 3
means transient errors won't incur such long waits, but repeating
failures shouldn't be retrying every second.
2015-07-09 22:51:23 +00:00
CJ Cullen
53c9f324c2 Add prometheus metrics for altTokenSource. 2015-07-07 15:25:23 -07:00
Yu-Ju Hong
530bff315f Merge pull request #10719 from justinsb/aws_mountpoints
AWS: Some images require volume mounts on /dev/xvdX
2015-07-07 10:48:19 -07:00