Commit Graph

582 Commits

Author SHA1 Message Date
Brian Goff
0051db89a7 Use O_CLOEXEC for volume subpath util
This prevents fd's from leaking to subprocesses.
2019-07-09 10:03:59 -07:00
Kubernetes Prow Robot
a5e3d74691 Merge pull request #79534 from odinuge/volume-util-fd
Fix possible fd leak and closing of dirs in doSafeMakeDir
2019-07-01 15:09:58 -07:00
Kubernetes Prow Robot
2501a9083d Merge pull request #68513 from codenrhoden/mount-refactor
Refactor util/mount interface in prep for moving out of k/k
2019-06-28 13:57:28 -07:00
Odin Ugedal
626a0f7b4b Fix closing of dirs in doSafeMakeDir
This fixes the issue where "childFD" from syscall.Openat is assigned to
a local variable inside the for loop, instead of the correct one in the
function scope. This results in that when trying to close the "childFD"
in the function scope, it will be equal to "-1", instead of the correct
value.
2019-06-28 18:21:12 +02:00
Lee Verberne
a0b57ad3db Update BUILD files for container helper 2019-06-21 08:32:04 +00:00
Lee Verberne
ee821e2a04 Create helpers for iterating containers in a pod 2019-06-21 08:32:04 +00:00
Travis Rhoden
be7da5052f Refactor pkg/util/mount to be more reusable
This patch refactors pkg/util/mount to be more usable outside of
Kubernetes. This is done by refactoring mount.Interface to only contain
methods that are not K8s specific. Methods that are not relevant to
basic mount activities but still have OS-specific implementations are
now found in a mount.HostUtils interface.
2019-06-14 09:35:18 -06:00
Kubernetes Prow Robot
518f16636f Merge pull request #78593 from RobertKrawitz/ephemeral-storage-quota-cleanup
Ephemeral storage quota cleanup
2019-06-14 05:33:18 -07:00
Mucahit Kurt
db1c07750a unit tests for the volume plugin name that's used inside GeneratedUnmapVolumeFunc for csi migration on/off scenarios
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
2019-06-11 08:32:25 +03:00
Kubernetes Prow Robot
333081e79c Merge pull request #78595 from gnufied/fix-aws-dangling-volumes
Add dangling volume as uncertain
2019-06-06 16:47:59 -07:00
Hemant Kumar
7bcebe98bb Add dangling volume as uncertain 2019-06-06 15:25:10 -04:00
Kubernetes Prow Robot
8657b24d86 Merge pull request #78681 from yuxiangqian/e2efix
fix label mismatching which broke e2e serial test
2019-06-04 10:53:21 -07:00
xiangqian
d616c6fb5a fix label mismatching which broke e2e serial test 2019-06-03 23:33:37 -07:00
Hemant Kumar
0f62e3fbe8 Make language of error msgs and func names consistent: ExpandVolumeInUse
change feature flag
Fix the e2e test for online and offline expansion
2019-06-03 12:26:56 -04:00
Kubernetes Prow Robot
b3c1bbb471 Merge pull request #78061 from yuxiangqian/metrics
Enhance to record more accurate e2e provision/deletion latency metric
2019-05-31 20:45:13 -07:00
Kubernetes Prow Robot
b7fa33ec15 Merge pull request #77703 from ddebroy/inline-mig-1
API changes to support migration of inline in-tree volumes to CSI
2019-05-31 12:23:19 -07:00
Robert Krawitz
bf1f0fa5d9 Remove pod UID from volumeMount, we can get it elsewhere 2019-05-31 14:25:01 -04:00
Robert Krawitz
10d37bb748 Rename pkg/volume/util/quota -> pkg/volume/util/fsquota 2019-05-31 13:57:44 -04:00
Kubernetes Prow Robot
cf76868b34 Merge pull request #66928 from RobertKrawitz/ephemeral-storage-quota-exp
Ephemeral storage monitoring via filesystem quotas
2019-05-30 20:44:26 -07:00
Deep Debroy
de7be9d613 Populate InlineVolumeSpec in CSI attacher and translation library
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-05-30 09:35:22 +00:00
Kubernetes Prow Robot
05df640f33 Merge pull request #77994 from gnufied/csi-resize-migration
Handle CSI volume resize migration.
2019-05-29 21:28:43 -07:00
xiangqian
9688511595 record provision and deletion latency metric
instead of using provisioner from storage class directly, uses plugin name firstly
2019-05-29 14:15:30 -07:00
Robert Krawitz
f8661d6240 Use xfs_quota command to apply quotas 2019-05-29 15:12:28 -04:00
Robert Krawitz
448e0c44c6 Apply quotas via syscalls using cgo. 2019-05-29 15:12:28 -04:00
Robert Krawitz
5b97b2860d Change fsGroup to mounterArgs in volume.SetUp() to allow for future extension. 2019-05-29 15:12:28 -04:00
Hemant Kumar
7563b4d01b Address comments about retry in online resizing block 2019-05-29 11:01:45 -04:00
Hemant Kumar
d119899e22 handle review comments 2019-05-28 15:22:41 -04:00
Di Xu
f715d41635 fix bug for regular empty file 2019-05-27 14:35:24 +08:00
Hemant Kumar
33b95ebddb add some tests for expand controller
Update bazel file
2019-05-20 10:55:23 -04:00
Hemant Kumar
405d33eae4 Add code to handle in-tree to CSI migration for resizing 2019-05-17 10:57:44 -04:00
Hemant Kumar
4886e8782c name the queue properly and use lower case for error message 2019-05-16 21:34:57 -04:00
Hemant Kumar
673773cbde check for pvc objects 2019-05-16 12:23:52 -04:00
Matthew Wong
c16a555654 Use workqueue model in expand controller
Add a test for patch creation
2019-05-14 16:42:06 -04:00
Kubernetes Prow Robot
b07f311322 Merge pull request #76882 from SataQiu/fix-golint-controller-20190422
Fix golint failures of pkg/controller/certificates/approver, etc
2019-05-02 03:16:18 -07:00
Kubernetes Prow Robot
9e52832c52 Merge pull request #77317 from gnufied/fix-block-volume-resizing
Fix block volume expansion
2019-05-01 20:42:56 -07:00
SataQiu
d76f1a8fd6 fix golint failures of pkg/volume/util/recyclerclient 2019-05-02 10:27:56 +08:00
Kubernetes Prow Robot
b5c34d0c43 Merge pull request #74734 from codenrhoden/move-mountspath
Move MountsInGlobalPDPath from mount pkg to volume
2019-05-01 17:28:18 -07:00
Hemant Kumar
0eb68c5a22 Fix blockvolume expansion 2019-05-01 18:25:54 -04:00
David Zhu
1271237d23 Add migration metrics checking to all test suites 2019-05-01 11:24:03 -07:00
Travis Rhoden
78d109e201 Always use filepath.Join instead of path.Join
This patch cleans up pkg/util/mount/* and pkg/util/volume/* to always
use filepath.Join instead of path.Join. filepath.Join is preferred
because path.Join can have issues on Windows.
2019-04-29 09:56:05 -06:00
Travis Rhoden
12b7f1450c Move MountsInGlobalPDPath from mount pkg to volume
Since pkg/util/mount is going to move out of k/k, this exported constant
that is Kubernetes specific needed to move somewhere else. Made sense to
move it to pkg/volume/util.

Update GetDeviceNameFromMount in the mount interface to now take a
pluginMountDir argument, which is volume plugin dir with the global
mount path appended to it already.
2019-04-29 09:56:00 -06:00
David Zhu
213cc99ead Operation generator migration metric fixes and test metrics retrieval code 2019-04-25 16:27:45 -07:00
Kubernetes Prow Robot
88992ba185 Merge pull request #75986 from mucahitkurt/improvement/reduce-event-spam-for-GenerateAttachVolumeFunc
Reduce event spam for function GenerateAttachVolumeFunc
2019-04-24 18:12:44 -07:00
Mucahit Kurt
1c1da755dc reduce event spam for function GenerateAttachVolumeFunc
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
2019-04-24 23:45:28 +03:00
Kubernetes Prow Robot
7e02769736 Merge pull request #75926 from cwdsuzhou/operation_generator_add_attach_detach
Add operation name for other volume operations
2019-04-18 00:26:08 -07:00
caiweidong
7c9e567008 add operation name for other volume operations 2019-04-12 11:09:13 +08:00
Travis Rhoden
96476fd054 Fix linting issues for exec mounter 2019-04-11 13:22:14 -06:00
Travis Rhoden
f38d4938be Move ExecMount to pkg/volume/util/exec
This patch moves the ExecMounter found in pkg/util/mount to
pkg/volume/util/exec. This is done in preparation for pkg/util/mount to
move out of tree. This specific implemention of mount.Interface is only
used internally to K8s and does not need to move out of tree.
2019-04-11 12:19:55 -06:00
Kubernetes Prow Robot
c62cd6e3a4 Merge pull request #76047 from codenrhoden/mv-nsenter-mount
Move nsenter mounter to pkg/volume/util/nsenter
2019-04-09 09:55:59 -07:00
Travis Rhoden
2253807760 Fix pkg/volume/util/nsenter linting errors 2019-04-08 10:43:54 -06:00