Commit Graph

74362 Commits

Author SHA1 Message Date
Rostislav M. Georgiev
e10dcf07d7 kubeadm: Introduce ValidateSupportedVersion in place of DetectUnsupportedVersion
DetectUnsupportedVersion is somewhat uncomfortable, complex and inefficient
function to use. It takes an entire YAML document as bytes, splits it up to
byte slices of the different YAML sub-documents and group-version-kinds and
searches through those to detect an unsupported kubeadm config. If such config
is detected, the function returns an error, if it is not (i.e. the normal
function operation) everything done so far is discarded.

This could have been acceptable, if not the fact, that in all cases that this
function is called, the YAML document bytes are split up and an iteration on
GVK map is performed yet again. Hence, we don't need DetectUnsupportedVersion
in its current form as it's inefficient, complex and takes only YAML document
bytes.

This change replaces DetectUnsupportedVersion with ValidateSupportedVersion,
which takes a GroupVersion argument and checks if it is on the list of
unsupported config versions. In that case an error is returned.
ValidateSupportedVersion relies on the caller to read and split the YAML
document and then iterate on its GVK map checking if the particular
GroupVersion is supported or not.

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
2019-02-01 19:35:39 +02:00
Kubernetes Prow Robot
b5b627d522
Merge pull request #73636 from bart0sh/PR0059-kubeadm-reset-fix-null-pointer-dereference
kubeadm: fix nil pointer dereference
2019-02-01 09:03:56 -08:00
Kubernetes Prow Robot
53a7601e6a
Merge pull request #64648 from dcbw/remove-unused-param
kubelet: remove unused parameter from runtime's SyncPod()
2019-02-01 09:03:45 -08:00
Kubernetes Prow Robot
556c0b8593
Merge pull request #73627 from mborsz/heapster
Fix typo in create-heapster-node
2019-02-01 07:44:48 -08:00
Kubernetes Prow Robot
5dd46ad911
Merge pull request #73406 from MalloZup/02-refactor
Limit scope and refactor config functions
2019-02-01 07:44:37 -08:00
Kubernetes Prow Robot
c0457488b6
Merge pull request #63901 from weipeng1213/branch-3
fix typo: writeable->writable
2019-02-01 07:44:26 -08:00
Kubernetes Prow Robot
c5fa271dfb
Merge pull request #62979 from wackxu/comment
fix priorityclass strategy comment
2019-02-01 07:44:15 -08:00
Kubernetes Prow Robot
495ee5ea40
Merge pull request #73611 from andrewsykim/gce-lb-ports
remove GCE cloud provider dependency to pkg/master/ports
2019-02-01 06:32:23 -08:00
Kubernetes Prow Robot
b1eae78fc7
Merge pull request #73610 from rajansandeep/coredns1.3.1
Bump CoreDNS version to 1.3.1
2019-02-01 06:32:11 -08:00
Kubernetes Prow Robot
b8b0dbcb7d
Merge pull request #73599 from tedyu/master
Add ps1 to windows executable extensions
2019-02-01 06:32:01 -08:00
Kubernetes Prow Robot
a3f74bd583
Merge pull request #72872 from arjunrn/object-average-value
Added functionality for specifying target average value for object me…
2019-02-01 06:31:50 -08:00
Kubernetes Prow Robot
2e01637f86
Merge pull request #69504 from krmayankk/refactor-sched1
Move informer event handlers to scheduler
2019-02-01 06:31:39 -08:00
Brad Hoekstra
e8c75068f3 Document default value for enableServiceLinks 2019-02-01 09:12:46 -05:00
Ed Bartosh
ab655a29b8 kubeadm: fix nil pointer dereference
If configuration file doesn't exist client variable is not assigned
and causes kubeadm crash:

$ sudo ./_output/bin/kubeadm reset
[reset] Reading configuration from the cluster...
[reset] FYI: You can look at this config file with 'kubectl -n kube-system get cm kubeadm-config -oyaml'
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xf8 pc=0x108c9e7]

goroutine 1 [running]:
cmd/kubeadm/app/util/config.getInitConfigurationFromCluster(0x171109b, 0xf, 0x0, 0x0, 0xc0005b5a00, 0x3, 0x3, 0x69)
	cmd/kubeadm/app/util/config/cluster.go:93 +0x37
cmd/kubeadm/app/util/config.loadConfiguration(0x0, 0x0, 0x18d63a0, 0xc00000c018, 0x170620b, 0x5, 0x0, 0x0, 0x15d6000, 0x18d7601, ...)
	cmd/kubeadm/app/util/config/cluster.go:67 +0x374
k8s.io/kubernetes/cmd/kubeadm/app/util/config.FetchConfigFromFileOrCluster(0x0, 0x0, 0x18d63a0, 0xc00000c018, 0x170620b, 0x5, 0x0, 0x0, 0x497700, 0x18d63e0, ...)
	cmd/kubeadm/app/util/config/cluster.go:45 +0x9c
k8s.io/kubernetes/cmd/kubeadm/app/cmd.resetDetectCRISocket(0x0, 0x0, 0x1, 0x0, 0x18d63e0, 0xc0003f0630)
	cmd/kubeadm/app/cmd/reset.go:304 +0x73
k8s.io/kubernetes/cmd/kubeadm/app/cmd.NewCmdReset.func1(0xc0002a6780, 0x26dd548, 0x0, 0x0)
	cmd/kubeadm/app/cmd/reset.go:71 +0x267
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).execute(0xc0002a6780, 0x26dd548, 0x0, 0x0, 0xc0002a6780, 0x26dd548)
	vendor/github.com/spf13/cobra/command.go:760 +0x2cc
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc00019a000, 0xc000389180, 0xc00019a500, 0xc00057c1a0)
	vendor/github.com/spf13/cobra/command.go:846 +0x2fd
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).Execute(0xc00019a000, 0xc00000c010, 0x18d63a0)
	vendor/github.com/spf13/cobra/command.go:794 +0x2b
k8s.io/kubernetes/cmd/kubeadm/app.Run(0xc000086180, 0x18b)
	cmd/kubeadm/app/kubeadm.go:48 +0x202
main.main()
	cmd/kubeadm/kubeadm.go:29 +0x33

Removing check for configuration file existence should fix the issue.
2019-02-01 15:36:43 +02:00
zhoulin xie
777174080b Fix some typos in comment
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-02-01 21:11:55 +08:00
Kubernetes Prow Robot
ad58fb1ea0
Merge pull request #73542 from juanvallejo/jvallejo/log-missing-dir-errors
make missing-directory errors non fatal
2019-02-01 04:45:12 -08:00
Kubernetes Prow Robot
35b09e5370
Merge pull request #73437 from dims/update-to-latest-gophercloud
Update to latest gophercloud
2019-02-01 04:45:00 -08:00
Maciej Borsz
afeabe99b7 Fix typo in create-heapster-node 2019-02-01 11:04:23 +01:00
Kubernetes Prow Robot
a3c14ecfa5
Merge pull request #73606 from krzysztof-jastrzebski/daemonsets
Deleting pods assigned to not existing nodes only if
2019-01-31 23:30:13 -08:00
Kubernetes Prow Robot
1b741f4c77
Merge pull request #73246 from danielqsj/code-generator
fix shellcheck in code-generator
2019-01-31 21:58:21 -08:00
Kubernetes Prow Robot
5be8d9552b
Merge pull request #70005 from stewart-yu/stewart-cloud-controller-manager-movefile
remove `pkg/controller` dependencies from `k8s.io/kubernetes/pkg/cloudprovider/providers`
2019-01-31 20:43:03 -08:00
Kubernetes Prow Robot
a31be286ca
Merge pull request #73608 from juanvallejo/jvallejo/improve-discovery-restmapper-errors
return original error, unless error is *meta.NoKindMatchError
2019-01-31 19:32:39 -08:00
Kubernetes Prow Robot
6af7d2cb1a
Merge pull request #69552 from Pingan2017/remove-experimental-fail-swap-on-flag
remove kubelet flag '--experimental-fail-swap-on' (deprecated in v1.8)
2019-01-31 19:32:28 -08:00
Andrew Kim
fc9b63d6f0 remove GCE cloud provider dependency to pkg/master/ports by duplicating the proxy port value 2019-01-31 21:37:08 -05:00
Kubernetes Prow Robot
3fa6402a39
Merge pull request #73612 from andrewsykim/vsphere-remove-version-dep
remove dep to pkg/version in vSphere provider
2019-01-31 18:20:48 -08:00
Kubernetes Prow Robot
244795a06a
Merge pull request #73442 from pjh/gce-windows-cluster
Update cluster/gce/ scripts to support Windows nodes.
2019-01-31 18:20:37 -08:00
stewart-yu
0ca7bf5e86 remove pkg/controller dependencies from k8s.io/kubernetes/pkg/cloudprovider/providers 2019-02-01 08:48:23 +08:00
Kubernetes Prow Robot
91d2bd3951
Merge pull request #73306 from Pingan2017/args-type-statusmanager
correct the type in status_manager.go
2019-01-31 16:05:44 -08:00
Kubernetes Prow Robot
7b7f18c6c8
Merge pull request #70978 from Pingan2017/gracePeriod
correct log output when specifed delete gracePeriod < minimumGracePer…
2019-01-31 16:05:33 -08:00
Andrew Kim
ece2b0db19 remove dep to pkg/version in vSphere provider 2019-01-31 17:26:05 -05:00
juanvallejo
bc381fb5fb
return original error, unless error is *meta.NoKindMatchError 2019-01-31 17:24:37 -05:00
Kubernetes Prow Robot
a5ade16abd
Merge pull request #73603 from sjenning/fix-kubelet-test
TestCreatePodSandbox_RuntimeClass should not expect RunPodSandbox when runtime class is not found
2019-01-31 14:10:30 -08:00
Sandeep Rajan
aa11f6c298 Bump CoreDNS version to 1.3.1 2019-01-31 16:55:02 -05:00
Kubernetes Prow Robot
85f1205efa
Merge pull request #73464 from ipuustin/verify-generated-files-remake
verify-generated-files-remake.sh: fix issues reported by shellcheck.
2019-01-31 13:00:04 -08:00
Andrew Kim
8be7963797 move GCERegionalPersistentDisk feature to k8s.io/cloud-provider 2019-01-31 15:19:52 -05:00
Kubernetes Prow Robot
aa7220876a
Merge pull request #73550 from andrewsykim/cloud-provider-version
use k8s.io/client-go/pkg/version for cloud providers
2019-01-31 11:44:46 -08:00
Krzysztof Jastrzebski
0087af78e2 Deleting pods assigned to not existing nodes only if
ScheduleDaemonSetPods is enabled.
2019-01-31 20:34:51 +01:00
Joe Julian
e9f1700512
bug: fix segfault when EnableServiceLinks is nil
When upgrading to 1.13, pods that were created prior to the upgrade have
no pod.Spec.EnableServiceLinks set. This causes a segfault and prevents
the pod from ever starting.

Check and set to the default if nil.

Fixes #71749
2019-01-31 11:07:32 -08:00
Seth Jennings
6b51d48c4f TestCreatePodSandbox_RuntimeClass should not expect RunPodSandbox when runtime class is not found 2019-01-31 12:55:56 -06:00
Kubernetes Prow Robot
8f1082c6af
Merge pull request #73455 from danielqsj/keymutex
Migrate to k8s.io/utils/keymutex and k8s.io/utils/strings
2019-01-31 09:56:19 -08:00
Ted Yu
9e227af65c Add ps1 to windows executable extensions 2019-01-31 09:21:01 -08:00
Kubernetes Prow Robot
9487d37666
Merge pull request #72873 from taragu/exponential-backoff-plugin-registration
Add exponential backoff for plugin registration
2019-01-31 08:07:12 -08:00
dmaiocchi
fd708d173e refactor config functions 2019-01-31 16:48:18 +01:00
Jordan Liggitt
f100a762bc Stop using apps/v1beta1 in tests 2019-01-31 10:12:38 -05:00
Patrick Ohly
7b5e65977c e2e: "skeleton" as fallback, empty string as default
Not accepting --provider= (i.e. setting an empty provider name) broke
some test jobs. As suggested in
https://github.com/kubernetes/kubernetes/pull/73402#issuecomment-459368230,
now --provider= and not passing --provider at all both trigger a
message and then continue as if --provider=skeleton had been used.
2019-01-31 15:54:48 +01:00
danielqsj
cf1fb8a1cd fix format issue 2019-01-31 22:01:13 +08:00
Kubernetes Prow Robot
46fc4dd96a
Merge pull request #73577 from wojtek-t/remove_vmodule
Remove vmodule from apiserver to reduce lock contention
2019-01-31 04:59:42 -08:00
Daniel (Shijun) Qian
e72b32558c
Merge branch 'master' into keymutex 2019-01-31 20:50:57 +08:00
Kubernetes Prow Robot
927fd1f785
Merge pull request #73532 from andrewsykim/cp-node-helper
move cloud node helper functions to k8s.io/cloud-provider/node/helpers
2019-01-31 02:54:27 -08:00
wojtekt
3032d92736 Remove vmodule from apiserver to reduce lock contention 2019-01-31 10:53:44 +01:00