Commit Graph

113237 Commits

Author SHA1 Message Date
Mike Danese
6bdb8ed566 switch spdy round trip tests to simple http proxy
github.com/elazarl/goproxy does not properly handle upgrades over HTTP
proxy. The problem is this misinterpretation:

6691876326/vendor/github.com/elazarl/goproxy/proxy.go (L89-L95)

These should be stripped but recalculated then added back:

https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/net/http/httputil/reverseproxy.go;l=292-297;drc=f6d844510d5f1e3b3098eba255d9b633d45eac3b

Let's just stop using goproxy, and use the stdlib instead. The
functionality we need is straightforward to implement and goproxy is
overkill.
2023-01-18 18:31:50 +00:00
Kubernetes Prow Robot
c63434aaff
Merge pull request #110838 from soltysh/cronjob_improvements
CronJob controller cleanups
2023-01-18 09:44:34 -08:00
Maciej Szulik
be44d67566
Re-use common parts between getNextScheduleTime and nextScheduledTimeDuration
The two methods nextScheduledTimeDuration and getNextScheduleTime have a
lot of similarities, so this commit squashes the common parts together
along with getMostRecentScheduleTime to avoid code duplication.
2023-01-18 16:52:45 +01:00
Kubernetes Prow Robot
cc68c06f9c
Merge pull request #115163 from SataQiu/lock-AdvancedAuditing-gate-20230118
Lock the AdvancedAuditing feature gate to true
2023-01-18 07:12:41 -08:00
Kubernetes Prow Robot
4b2b4e19cc
Merge pull request #114523 from zshihang/token
graduate LegacyServiceAccountTokenTracking to beta
2023-01-18 07:12:33 -08:00
Clayton Coleman
95051a63b3
wait: Use a context implementation for ContextForChannel
ContextForChannel uses a goroutine to transform a channel close to
a context cancel. However, this exposes a synchronization issue if
we want to unify the underlying implementation between contextless
and with context - a ConditionFunc that closes the channel today
expects the behavior that no subsequent conditions will be invoked
(we have a test in wait_test.go TestUntilReturnsImmediately that
verifies this expectation). We can't unify the implementation
without ensuring this property holds.

To do that this commit changes from the goroutine propagation to
implementing context.Context and using stopCh as the Done(). We
then implement Err() by returning context.Canceled and stub the
other methods. Since our context cannot be explicitly cancelled
by users, we cease to return the cancelFn and callers that need
that behavior must wrap the context as normal.

This should be invisible to clients - they would already observe
the same behavior from the context, and the existing error
behavior of Poll* is preserved (which ignores ctx.Err()).

As a side effect, one less goroutine is created making it more
efficient.
2023-01-18 10:00:47 -05:00
Patrick Ohly
4add08dcce k8s.io/component-base/logs: relax flagset unit tests
A full string comparison might fail when the underlying libraries change how
they format the help text. A regex match is less strict, but still makes some
assumptions about the implementation.
2023-01-18 14:45:54 +01:00
Maciej Szulik
cb491a8d0f
Cleanups in controller utils
1. Squash two identical sorters byTime
2. Move helper for searching active jobs into utils to exist next to its
  counterpart
2023-01-18 13:40:23 +01:00
Richard Kovacs
bef16e817b Fix lint errors at local-up-cluster.sh 2023-01-18 12:20:33 +01:00
Kubernetes Prow Robot
d3f881f750
Merge pull request #115093 from xuzhenglun/too-large-resource-version-1.16
Fix bug in reflector not detecting "Too large resource version" error before 1.17.0
2023-01-18 03:12:46 -08:00
Viacheslav Panasovets
6adf60fdf4
Do not create endpoints if service of type ExternalName (#114814) 2023-01-18 03:12:34 -08:00
SataQiu
c25095b223 the AdvancedAuditing featuregate has been GA since v1.12, and is locked to ture in v1.27 2023-01-18 18:50:15 +08:00
Richard Kovacs
89539e80dc Fix lint errors at local-up-cluster.sh 2023-01-18 11:15:38 +01:00
Richard Kovacs
be4b3c5abd Use proper mktmp command in local-up-cluster.sh 2023-01-18 10:58:41 +01:00
Aditi Sharma
d83c37c311 Update CNI version to 1.2.0
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
2023-01-18 13:24:40 +05:30
Kubernetes Prow Robot
46f3821bf4
Merge pull request #114586 from andrewsykim/apiserver-lease-rename
Rename apiserver identity lease labels to apiserver.kubernetes.io/identity
2023-01-17 21:36:34 -08:00
Kubernetes Prow Robot
106332252b
Merge pull request #115129 from liggitt/gotools-1.20
bump honnef.co/go/tools to support go1.20
2023-01-17 20:28:33 -08:00
Sean Sullivan
84b226409a Refactor validation files into openapi/validation 2023-01-17 18:02:41 -08:00
Alexander Zielenski
ecd267d097 fix bug with param controllers being removed if used by more than one policy 2023-01-17 16:26:18 -08:00
Kubernetes Prow Robot
84200d0470
Merge pull request #115135 from Jefftree/rename-enum-integration
Rename enum openapi test
2023-01-17 16:06:47 -08:00
Kubernetes Prow Robot
20c17da142
Merge pull request #114446 from lengrongfu/feat/clean_up
clean up master-service-namespace
2023-01-17 16:06:35 -08:00
Kubernetes Prow Robot
7e0923899f
Merge pull request #114527 from alexzielenski/apiserver/policy/lockfree-refactor
refactor policy admission Validator to be lock free
2023-01-17 12:48:33 -08:00
Kubernetes Prow Robot
5e9fc39d17
Merge pull request #114878 from Nordix/ipvs-allow-any-sheduler
Ipvs: remove the scheduler validation
2023-01-17 11:18:46 -08:00
Kubernetes Prow Robot
c913e6ce62
Merge pull request #114542 from pacoxu/EphemeralContainers
cleanup: EphemeralContainers feature gate related codes
2023-01-17 11:18:34 -08:00
Kubernetes Prow Robot
b01afdca66
Merge pull request #115116 from smarterclayton/hide_wait
wait: Make WaitFor and WaitForWithContext private
2023-01-17 10:10:45 -08:00
Kubernetes Prow Robot
f7b02260f6
Merge pull request #114922 from ibihim/kmsv2-interface-move
[KMSv2] apiserver/kmsv2: mv Service interface into kmsv2
2023-01-17 10:10:33 -08:00
Jefftree
a26174155d Rename enum integration test 2023-01-17 17:22:24 +00:00
Jordan Liggitt
7a41b950cc
Fix shadowing lint error 2023-01-17 12:09:24 -05:00
Patrick Ohly
8251a63269 k8s.io/component-base/logs: unit test for command line help output
Both pflag and standard FlagSet are covered.
2023-01-17 17:32:50 +01:00
Kubernetes Prow Robot
5550064bc2
Merge pull request #115063 from kannon92/tracking-remove-comments
tracking with finalizers is the default way for the job controller so comments are not needed that say we are tracking with finalizers
2023-01-17 07:56:44 -08:00
Kubernetes Prow Robot
727b5a4b47
Merge pull request #114231 from helio/fix-windows-cpu-maximum
win: fix cpu count to calculate cpu_maximum
2023-01-17 07:56:33 -08:00
Jordan Liggitt
121088cb2a
bump honnef.co/go/tools to support go1.20 2023-01-17 10:42:55 -05:00
Kubernetes Prow Robot
7f8be71148
Merge pull request #115127 from soltysh/fix_logs
Wait for logs pod to complete before counting lines
2023-01-17 05:44:33 -08:00
Clayton Coleman
1dfe2225ac
wait: Make WaitFor and WaitForContext private
These methods are unused within the Kubernetes codebase and will be
replaced with a more general method that unifies Wait, Poll*, and
ExponentialBackoff within this package. A zero duration interval
passed to any of the other methods will provide equivalent function.
2023-01-17 08:39:15 -05:00
Maciej Szulik
3d3da44e96
Wait for logs pod to complete before counting lines 2023-01-17 13:39:35 +01:00
Kubernetes Prow Robot
3154010eec
Merge pull request #115117 from pacoxu/cleanup-kubectl-e2e
cleanup(kubectl-e2e): remove invalid comments
2023-01-17 02:54:44 -08:00
Kubernetes Prow Robot
1b95370225
Merge pull request #114886 from a7i/kubectl-hpa-v2
kubectl: use autoscaling v2 for hpa
2023-01-17 02:54:33 -08:00
Jan Safranek
b9c2449569 Rework createSELinuxMountPreHook to switch() 2023-01-17 11:23:19 +01:00
Jan Safranek
d2bb866d3f Remove useless Sprintf 2023-01-17 11:22:39 +01:00
Jan Safranek
de4ce7b58c Remove defer
Replace it with ginkgo.DeferCleanup
2023-01-17 11:22:12 +01:00
Kubernetes Prow Robot
7649afeffc
Merge pull request #114721 from jjjungkim/fix-typo
fix typo
2023-01-17 01:44:33 -08:00
Krzysztof Ostrowski
b7701b00ea
apiserver/kmsv2: mv Service interface into kmsv2
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
2023-01-17 10:05:16 +01:00
Kubernetes Prow Robot
f16e62ae0c
Merge pull request #114897 from kidddddddddddddddddddddd/volumebinding
feature(volumebinding): return Skip in PreFilter
2023-01-16 23:38:32 -08:00
Paco Xu
ae574993c2 cleanup(kubectl-e2e): remove invalid comments 2023-01-17 10:13:21 +08:00
Kubernetes Prow Robot
7b7b15b821
Merge pull request #115110 from HirazawaUi/delte-pkg-unused-functions
delete unused functions in pkg directory
2023-01-16 18:06:43 -08:00
Kubernetes Prow Robot
3d9b437df2
Merge pull request #115109 from HirazawaUi/delte-pkg-volume-unused-functions
delete unused functions in pkg/volume directory
2023-01-16 18:06:31 -08:00
Kubernetes Prow Robot
977465e310
Merge pull request #115103 from HirazawaUi/delte-pkg-util-unused-functions
delete unused functions in pkg/util directory
2023-01-16 16:58:10 -08:00
Kubernetes Prow Robot
7b01daba71
Merge pull request #115074 from yangjunmyfm192085/deleteklogv0-controller
use klog instead of klog.V(0)--controller manager part
2023-01-16 09:58:50 -08:00
Kubernetes Prow Robot
62d7937b2e
Merge pull request #115046 from pacoxu/default-container-e2e
add e2e test for kubectl default container annotation
2023-01-16 08:42:50 -08:00
HirazawaUi
3b18e80fb4 delete unused functions in pkg directory 2023-01-16 21:43:36 +08:00