Commit Graph

117461 Commits

Author SHA1 Message Date
Daniel Vega-Myhre
a9afaa1eee add feature gate 2023-06-27 18:07:17 +00:00
Kubernetes Prow Robot
b3d94ae74f
Merge pull request #118786 from pohly/dra-test-skip-prepare
dra: kubelet must skip NodePrepareResource if not used by any container
2023-06-27 09:58:32 -07:00
Mauren Berti
dfce076c6c
Update the template.pot file with latest message IDs.
Update the template.pot file with the current state of the messages in kubectl. That allows localized messages to be updated accordingly and picked up correctly.
2023-06-27 12:10:46 -04:00
Kubernetes Prow Robot
b82240cfb0
Merge pull request #118903 from champtar/revert-118631-ca-not-before
Revert "Make CA valid 1 hour in the past"
2023-06-27 08:57:00 -07:00
Kubernetes Prow Robot
76b2198da1
Merge pull request #118901 from dims/set-aws-specific-credential-provider-when-running-there
Set AWS specific credential provider when running there
2023-06-27 08:56:51 -07:00
Kubernetes Prow Robot
1c32c3bd9f
Merge pull request #118866 from neolit123/1.28-add-v1beta4-to-scheme
kubeadm: add v1beta4 to scheme; add --allow-experimental-api flag
2023-06-27 08:56:44 -07:00
Aldo Culquicondor
a4519665fe
Skip terminal Pods with a deletion timestamp from the Daemonset sync (#118716)
* Skip terminal Pods with a deletion timestamp from the Daemonset sync

Change-Id: I64a347a87c02ee2bd48be10e6fff380c8c81f742

* Review comments and fix integration test

Change-Id: I3eb5ec62bce8b4b150726a1e9b2b517c4e993713

* Include deleted terminal pods in history

Change-Id: I8b921157e6be1c809dd59f8035ec259ea4d96301
2023-06-27 08:56:33 -07:00
kidddddddddddddddddddddd
9c7166ff63 wait for eventhandlers to sync before run scheduler 2023-06-27 23:19:34 +08:00
Kubernetes Prow Robot
6dbb1c6cf0
Merge pull request #118902 from pohly/staticcheck-cleanup
Cleanup staticcheck workarounds, improve gomega calls, update to golangci-lint 1.53.3
2023-06-27 07:54:32 -07:00
Patrick Ohly
bde66bfb55 kubelet dra: restore skipping of unused resource claims
1aeec10efb removed iterating over containers in favor of iterating over pod
claims. This had the unintended consequence that NodePrepareResource gets
called unnecessarily when no container needs the claim. The more natural
behavior is to skip unused resources. This enables (theoretic, at this time)
use cases where some DRA driver relies on the controller part to influence
scheduling, but then doesn't use CDI with containers.
2023-06-27 16:02:31 +02:00
Patrick Ohly
874daa8b52 kubelet dra: fix checking of second pod which uses a claim
When a second pod wanted to use a claim, the obligatory sanity check whether
the pod is really allowed to use the claim ("reserved for") was skipped.
2023-06-27 16:01:11 +02:00
Davanum Srinivas
6c587b43e9
Cleanup pods at the end in Pod conditions e2e node test
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-06-27 09:36:00 -04:00
Etienne Champetier
56c5c8f7ee
Revert "Make CA valid 1 hour in the past" 2023-06-27 08:57:59 -04:00
Kubernetes Prow Robot
16fe4a4cce
Merge pull request #118899 from xmudrii/aws-rm-ccm
CHANGELOG-1.27: Add note for AWS in-tree provider removal
2023-06-27 05:50:41 -07:00
Kevin Hannon
ecd727e4c7
Fix PodGC test when PodDisruptionConditions disabled (#118805)
* test comment should match the code in podgc

* Update test/integration/podgc/podgc_test.go

Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>

* test comment should match the code in podgc

---------

Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
2023-06-27 05:50:29 -07:00
Madhav Jivrajani
bdbf07525f test: remove exception comments in discovery tests
The exception comments were added due to a false positive in
staticcheck. This has since been rectified.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2023-06-27 14:20:41 +02:00
Madhav Jivrajani
6fd830a075 hack/tools: bump golangci-lint and consequently staticcheck
This bump is done since the latest version of staticcheck includes
a fix for a false positive reported by us, discovered while bumping
to go1.20

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2023-06-27 14:20:41 +02:00
Patrick Ohly
1af5425696 hack: disable gomega.Consistently/Eventually check due to false positives
For example, this is a false positive that currently exists in the code base:

    test/e2e_node/dra_test.go:129:4: ginkgo-linter: use a function call in Consistently. This actually checks nothing, because Consistently receives the function returned value, instead of function itself, and this value is never changed; consider using `gomega.Consistently(ctx, e2epod.Get).WithArguments(f.ClientSet, pod).WithTimeout(podInPendingStateTimeout).Should(e2epod.BeInPhase(v1.PodPending),
    	"Pod should be in Pending state as resource preparation time outed")` instead (ginkgolinter)
    			gomega.Consistently(ctx, e2epod.Get(f.ClientSet, pod)).WithTimeout(podInPendingStateTimeout).Should(e2epod.BeInPhase(v1.PodPending),
    			^

It's a false positive because e2epod.Get returns the function that Consistently
is meant to call.

This could be worked around by assigning e2epod.Get(f.ClientSet, pod) to a
variable and then use that variable, but that is less readable.
2023-06-27 14:20:41 +02:00
Patrick Ohly
f618e61332 e2e: replace gomega.HaveLen(0) with gomega.BeEmpty()
The failure message becomes nicer. Found with the new ginkgolinter, for
example:

    test/e2e/apps/cronjob.go:113:3: ginkgo-linter: wrong length assertion; consider using `gomega.Expect(jobs.Items).To(gomega.BeEmpty())` instead (ginkgolinter)
     		gomega.Expect(jobs.Items).To(gomega.HaveLen(0))
     		^
2023-06-27 14:20:41 +02:00
Patrick Ohly
e7df337eba e2e: replace gomega.Equal(true/false) with gomega.BeTrue/BeFalse()
The failure message becomes a bit nicer. Found by the new ginkgolinter, for
example:

    test/e2e/windows/memory_limits.go:160:2: ginkgo-linter: wrong boolean assertion; consider using `gomega.Eventually(ctx, func() bool {
     eventList, err := f.ClientSet.CoreV1().Events(f.Namespace.Name).List(ctx, metav1.ListOptions{})
     ...
    }, 3*time.Minute, 10*time.Second).Should(gomega.BeTrue())` instead (ginkgolinter)
2023-06-27 14:20:20 +02:00
Patrick Ohly
8b33e8bdd1 e2e: fix gomega.Expect calls without assertions
"gomega.Expect" is not the same as "assert" in C: it always has to be combined
with a statement of what is expected.

Found with the new ginkgolinter, for example:

    test/e2e/node/pod_resize.go:242:3: ginkgo-linter: "Expect": missing assertion method. Expected "Should()", "To()", "ShouldNot()", "ToNot()" or "NotTo()" (ginkgolinter)
              gomega.Expect(found == true)
2023-06-27 14:20:20 +02:00
Davanum Srinivas
0ef1f2f2d8
Set AWS specific credential provider when running there
NOTE: we are not installing the ecr-credential-provider binary
itself here we are, we need to do it out-of-band from the test
suite itself before it runs.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-06-27 07:45:59 -04:00
Kubernetes Prow Robot
89b1d0ce3e
Merge pull request #118724 from soltysh/cronjob_most_recent
Update schedule logic to properly calculate missed schedules
2023-06-27 04:24:30 -07:00
Marko Mudrinić
b0f694f50a
CHANGELOG-1.27: Add note for AWS in-tree provider removal
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
2023-06-27 12:46:25 +02:00
Maciej Szulik
af1c9e49c4
Update schedule logic to properly calculate missed schedules
Before this change we've assumed a constant time between schedule runs,
which is not true for cases like "30 6-16/4 * * 1-5".
The fix is to calculate the potential next run using the fixed schedule
as the baseline, and then go back one schedule back and allow the cron
library to calculate the correct time.

This approach saves us from iterating multiple times between last
schedule time and now, if the cronjob for any reason wasn't running for
significant amount of time.
2023-06-27 11:29:30 +02:00
Kubernetes Prow Robot
9d50c0a025
Merge pull request #118889 from swetharepakula/extend-timeout
Extend Large Create Timeout to 60 min
2023-06-26 20:04:42 -07:00
Kubernetes Prow Robot
1d25ce8beb
Merge pull request #118392 from testwill/emptydir
chore: io/ioutil deprecated
2023-06-26 20:04:31 -07:00
Keerthan Reddy Mala
0033f65808 increase the log level for the GetTargetNodeName error message 2023-06-26 17:31:50 -07:00
Kubernetes Prow Robot
5e85f21e5b
Merge pull request #118888 from enj/enj/i/kms_interface_split
kmsv2: no-op: split transformer interface
2023-06-26 16:32:30 -07:00
Swetha Repakula
08198fe22b Extend Large Create Timeout to 60 min
* Load balancers are taking greater than 45 to provision
 * https://github.com/kubernetes/kubernetes/issues/118295
2023-06-26 15:32:34 -07:00
Kubernetes Prow Robot
421ca53be4
Merge pull request #118820 from logicalhan/processstart
Write process start time to prometheus options so that scraping clients can parse it first
2023-06-26 14:56:29 -07:00
Monis Khan
9354e78289
no-op: split transformer interface
Signed-off-by: Monis Khan <mok@microsoft.com>
2023-06-26 17:36:11 -04:00
Kubernetes Prow Robot
f7967af3bd
Merge pull request #118633 from sttts/sttts-controlplane-split
kube-apiserver: split apart generic control plane options
2023-06-26 13:56:29 -07:00
Daniel Vega-Myhre
2176053415 add completion index as pod label 2023-06-26 19:53:14 +00:00
Dr. Stefan Schimanski
8083d0d22e
pkg/controlplane/apiserver: remove temporary import restriction of cmd/kube-apiserver 2023-06-26 21:50:38 +02:00
Dr. Stefan Schimanski
764da8a01d
FIXUP: cmd/kube-apiserver/app/options: split apart controlplane part 2023-06-26 21:50:38 +02:00
Dr. Stefan Schimanski
1b3779baa0
MOVE: cmd/kube-apiserver/app/options: split apart controlplane part 2023-06-26 21:50:37 +02:00
Filip Křepinský
3df92362ab fix openapi/v3 non local apiservices aggregation
When resyncing APIServices (every minute), the AggregationController calls
AddUpdateAPIService immediately, but it may take some time before the
reconciliation of the controller calls UpdateAPIServiceSpec. This results in a
temporary downtime of discovery of these APIServices, which will stop reporting
of these in the aggregated openapi/v3 by specProxier. This fix ensures that old
discovery is kept during a time, when the AggregationController is reconciling.
2023-06-26 18:49:55 +02:00
Kubernetes Prow Robot
96d853f4b8
Merge pull request #118870 from SataQiu/kubeadm-clean-v1beta4
kubeadm: remove unused Kind and Resource functions from v1beta4 API
2023-06-26 09:40:29 -07:00
Kubernetes Prow Robot
9f5a3f5e90
Merge pull request #118868 from sttts/sttts-kube-apiserver-options-completion-move
cmd/kube-apiserver: move options completion into options package
2023-06-26 08:14:29 -07:00
SataQiu
4298953c26 kubeadm: remove unused Kind and Resource functions from v1beta4 API 2023-06-26 22:11:52 +08:00
Kubernetes Prow Robot
d9714078f8
Merge pull request #118551 from sanposhiho/event-to-register
feature(scheduler): implement ClusterEventWithHint to filter out useless events
2023-06-26 06:41:45 -07:00
Dr. Stefan Schimanski
6e079545c4
cmd/kube-apiserver: move options completion into options package 2023-06-26 15:20:40 +02:00
Kubernetes Prow Robot
a374d893f0
Merge pull request #118840 from AhmedGrati/fix-deployment-patch-e2e-test
fix: update deployment e2e tests
2023-06-26 04:49:44 -07:00
Lubomir I. Ivanov
f04484fe77 kubeadm: add the --allow-experimental-api flag to "config" commands
Add the flag --allow-experimental-api to the "config migrate" and
"config validate" commands. The flag allows validating / migrating-to
a unreleased / experimental API version.

Add a new experimentalAPIVersions map in validateSupportedVersion()
that contains v1beta4.
2023-06-26 13:50:47 +03:00
Lubomir I. Ivanov
0774f779d5 kubeadm: add v1beta4 to the kubeadm API scheme
The highest priority is still v1beta3.
2023-06-26 13:43:47 +03:00
Moshe Levi
38222014c6 kubelet pod-resources: add e2e for KubeletPodResourcesGet feature
Signed-off-by: Moshe Levi <moshele@nvidia.com>
2023-06-26 08:10:24 +03:00
Kubernetes Prow Robot
027ac5a426
Merge pull request #118762 from neolit123/1.28-kubeadm-add-v1beta4-boilerplate
kubeadm: add v1beta4 API boilerplate
2023-06-25 22:05:08 -07:00
Kubernetes Prow Robot
6cb0308dbf
Merge pull request #118857 from dims/better-backoff-delays-and-connection-timeout-talking-to-containerd
Better back off delays and connection timeout to talk to containerd
2023-06-25 16:53:08 -07:00
Davanum Srinivas
f7239e4095
Better back off delays and connection timeout to talk to containerd
Set up params similar to what we do in cadvisor:
e9068e3273/container/containerd/client.go (L59-L61)

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-06-25 16:25:28 -04:00