Commit Graph

222 Commits

Author SHA1 Message Date
Michał Woźniak
5a7c90fb76 Allow mutable scheduling directives for suspended Jobs 2025-11-05 19:37:33 +00:00
Ondra Kupka
575e9eb64c controller/job: Improve goroutine mgmt
Make sure all threads are terminated when Run returns.
2025-10-29 19:00:30 +01:00
Jordan Liggitt
91d135f344 Include relevant dimensions in pod controller indexing 2025-10-16 13:27:50 -04:00
Kubernetes Prow Robot
d03d25f47c Merge pull request #133985 from aditigupta96/api-waitfornamedcachesync-with-context
Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/
2025-09-16 17:18:09 -07:00
Aditi Gupta
af231d2153 Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/ 2025-09-16 14:51:34 -07:00
Maciej Szulik
46cc610e6f Drop PodIndexLabel after the feature GA-ed in 1.32
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
2025-09-11 19:32:48 +02:00
Michal Wozniak
ac86e67b7d Commonize filtering of Pods by Owner with all orphans in namespace 2025-06-30 08:07:21 +02:00
xigang
66c611125c Add namespace-aware orphan pod indexing
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-06-19 16:32:20 +08:00
xigang
91b4816c23 Optimize job controller performance: reduce work duration time & minimize cache locking
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-06-18 15:28:12 +08:00
Eric Lin
1f46b3fdbf Clean backoff record earlier
Once received job deletion event, it cleans the backoff records for that
job before enqueueing this job so that we can avoid a race condition
that the syncJob() may incorrect use stale backoff records for a newly created
job with same key.

Co-authored-by: Michal Wozniak <michalwozniak@google.com>
2025-06-06 18:31:38 +00:00
Kubernetes Prow Robot
fe5afa919b Merge pull request #130333 from kmala/job
handle job complete update delayed event
2025-04-25 17:55:22 -07:00
Keerthan Reddy Mala
d4fd41285b update the log message to reflect success and failed jobs 2025-04-08 10:21:02 -07:00
Keerthan Reddy Mala
551f3c7824 merge the integration tests into a single one 2025-04-07 17:37:19 -07:00
Keerthan Reddy Mala
1b8bbcac44 Add integration test 2025-03-20 15:04:44 -07:00
Kubernetes Prow Robot
1c756849d6 Merge pull request #130591 from fmuyassarov/devel/logging
Refine logging levels in job, IPAM, and replicaSet
2025-03-12 07:13:47 -07:00
Feruzjon Muyassarov
4c6971007b Refine logging levels in Job, IPAM, and ReplicaSet controllers.
Adjust logging levels in Job, IPAM, and ReplicaSet controllers from
V(0) to V(2), V(4), V(4) respectively to reduce noise. These logs
provide minimal value at the debug level (V(0)), so they have been
adjusted for better log clarity

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
2025-03-11 10:25:16 +02:00
Keerthan Reddy Mala
51fdd55e87 use sync map for the cache 2025-03-06 15:56:07 -08:00
Yuki Iwai
8202b791e9 Job: Use jobSuspended util for suspended detection
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2025-03-05 18:12:59 +09:00
Keerthan Reddy Mala
547c005cb7 handle job complete update delayed event 2025-03-04 14:42:13 -08:00
Yuki Iwai
5dda60ee4e Job: Add evaluation step comments in the syncJob
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-11-07 23:36:44 +09:00
Yuki Iwai
a23e7a42d3 Job: Refactor uncountedTerminatedPods to avoid casting everywhere
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-10-29 13:12:35 +09:00
Harish Kuna
0615ded5f7 keep delete handler and update handler consistent for finished jobs and offload mainqueue 2024-09-20 13:28:27 +00:00
Harish Kuna
77a3de3cfb Improve performance of Job controller delete event handler 2024-09-18 15:59:53 +00:00
Harish K
d66c9ef286 Update pkg/controller/job/job_controller.go
Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
2024-09-10 10:18:53 -07:00
Harish Kuna
e45eef1d51 Increase Job Controller Performance 2024-09-09 21:12:31 +00:00
古九
a1f0fc8f72 support the job controller handles the orphan pod using multi workers 2024-08-19 14:03:27 +08:00
Yuki Iwai
6e8dc2c250 Job: Extend the jobs_finished_total metric reason label with SuccessPolicy and CompletionsReached
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-23 09:29:02 +09:00
Yuki Iwai
594490fd77 Job: Add the CompletionsReached reason to the SuccessCriteriaMet condition
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-22 21:24:52 +09:00
Michal Wozniak
1be4df6e02 Cleanup Job controller isPodFailed function 2024-07-18 09:08:23 +02:00
carlory
dae05f3b88 cleanup after JobPodFailurePolicy is promoted to GA 2024-07-18 10:00:56 +08:00
Kubernetes Prow Robot
5d40866fae Merge pull request #125994 from carlory/fix-job-api
clean up codes after PodDisruptionConditions was promoted to GA
2024-07-17 14:37:09 -07:00
Michal Wozniak
fb7704ba03 Delay setting terminal Job conditions until all pods are terminal
Fix the integration test typecheck

Fix after rebase

# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-11 20:54:09 +02:00
carlory
850bc09e9b clean up codes after PodDisruptionConditions was promoted to GA and locked to default 2024-07-11 10:40:21 +08:00
Kubernetes Prow Robot
135f2e0372 Merge pull request #125997 from mimowo/job-comment-cleanup
Cleanup TODO comment in the Job controller
2024-07-10 12:15:39 -07:00
Michal Wozniak
8a8717c3a9 Cleanup TODO comment in the Job controller 2024-07-10 12:27:56 +02:00
Tomas Tormo
2aed11ec78 job_controller: Ignore FailureTarget!=True 2024-07-10 08:02:14 +00:00
Dejan Zele Pejchev
11b6e4c404 count ready pods when deleting active pods for failed jobs 2024-06-21 01:07:40 +02:00
Kubernetes Prow Robot
cc2946e5d1 Merge pull request #125515 from mimowo/refactor-terminating-counter
Refactor tracking of terminating pods in Job controller
2024-06-20 13:01:41 -07:00
Michal Wozniak
c12bcf4e94 Refactor enactJobFinished util function for Job controller 2024-06-20 13:02:54 +02:00
Michal Wozniak
8cec2c7470 Refactor tracking of terminating pods in Job controller 2024-06-20 09:35:56 +02:00
Kubernetes Prow Robot
bd88faee8b Merge pull request #125520 from mimowo/cleanup-success-policy-check
Remove redundant check in Job success policy code
2024-06-18 12:40:09 -07:00
Michal Wozniak
7a3d73d234 Remove redundant check in Job success policy code 2024-06-14 19:59:40 +02:00
Michal Wozniak
18a14bcff9 Remove unused parameter in Job controller function 2024-06-14 19:43:19 +02:00
Kubernetes Prow Robot
c49b140c45 Merge pull request #125175 from dejanzele/feat/count-terminating-for-failed-jobs
Count terminating pods when deleting active pods for failed jobs
2024-06-10 16:56:37 -07:00
Dejan Pejchev
7dd2948620 count terminating pods when deleting active pods for failed jobs 2024-06-04 11:31:00 +02:00
Tomas Tormo
ce56b2ca58 Remove JobReadyPods feature flag 2024-05-27 13:09:52 +00:00
Michal Wozniak
a6c9d5ba00 Do not remove Job's finalizer from Pod owned by a non-batch/v1 Job 2024-05-14 17:29:23 +02:00
Kubernetes Prow Robot
d2e6c51b05 Merge pull request #123537 from kaisoz/commonize-job-util-functions
Add the util pkg to commonize job util functions
2024-05-07 16:59:28 -07:00
Tomas Tormo
c856c412b9 Add util pkg to commonize job util functions 2024-05-07 09:27:46 +00:00
Alvaro Aleman
6d0ac8c561 Use the generic/typed workqueue throughout
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
2024-05-04 14:33:12 -04:00