Commit Graph

12798 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
e869f3c0d0 Merge pull request #136180 from bart0sh/PR215-migrate-kubelet_pods-to-contextual-logging
migrate kubelet_pods* to contextual logging
2026-01-17 06:59:22 +05:30
Kubernetes Prow Robot
a966be1a07 Merge pull request #136026 from KyungHwanKim-devs/fix-goroutine-leak-kubelet-pluginmanager
Fix potential goroutine leak in kubelet operation_executor_test
2026-01-17 06:59:15 +05:30
Kubernetes Prow Robot
ae76dd831d Merge pull request #136168 from bart0sh/PR214-DRA-kubelet-OWNERS-update
Add pohly and bart0sh as approvers for kubelet/cm/dra
2026-01-17 01:33:24 +05:30
qiuxue
aeb9002d14 fix(kubelet):resolve loop variable capture bug in WaitForAllPodsUnmount 2026-01-16 22:37:50 +08:00
Ed Bartosh
eb2cf5ad04 migrate kubelet_pods* to contextual logging 2026-01-15 12:30:24 +02:00
Kubernetes Prow Robot
b40830cca7 Merge pull request #135794 from AutuSnow/master
kubelet: resolve data race in WaitForAllPodsUnmount when collecting errors(#134083)
2026-01-15 11:09:37 +05:30
Kubernetes Prow Robot
cd8fc957c7 Merge pull request #135303 from vikasbolla/fix_pcr_flake
Fix context deadline exceeded in PodCertificate test
2026-01-15 00:27:46 +05:30
Kubernetes Prow Robot
616fff8247 Merge pull request #131317 from bitoku/fix-static-init
Fix:Static pod status is always Init:0/1 if unable to get init container status
2026-01-15 00:27:38 +05:30
Kubernetes Prow Robot
19d344fbee Merge pull request #135887 from ErikJiang/fix/log-validation-messages
fix log validation messages
2026-01-13 00:00:17 +05:30
Kubernetes Prow Robot
f366ba158a Merge pull request #135668 from yliaog/implicit
added unit test case to ensure implicit DRA extended resource is handled properly during pod admission at kubelet
2026-01-13 00:00:09 +05:30
Kubernetes Prow Robot
210881f0f0 Merge pull request #135485 from saschagrunert/fix-device-plugin-termination-grace-period
Fix device plugin admission failure after container restart
2026-01-12 22:24:22 +05:30
Kubernetes Prow Robot
af6c58193c Merge pull request #135369 from saschagrunert/serial-tests
test: Fix image credential pulls test node scheduling
2026-01-12 22:24:13 +05:30
Kubernetes Prow Robot
b9e2575a54 Merge pull request #135992 from bart0sh/PR212-migrate-remaining-kubelet-subdirs-to-contextual-logging
Migrate remaining kubelet subdirs to contextual logging
2026-01-12 19:58:41 +05:30
Sascha Grunert
172a65c71d Fix device plugin admission failure after container restart
When a container restarts before kubelet restarts, containerMap has
multiple entries (old exited + new running). GetContainerID() may
return the exited container, causing the running check to fail. Fixed
by checking if ANY container for the pod/name is running.

Also filter terminal pods from podresources since they no longer
consume resources, and fix test error handling to avoid exiting
Eventually immediately on transient errors.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2026-01-12 11:55:25 +01:00
Ed Bartosh
b0375e76f0 Add pohly and bart0sh as approvers for kubelet/cm/dra 2026-01-12 12:43:07 +02:00
Ed Bartosh
1c48267565 migrate pkg/kubelet/events to contextual logging 2026-01-12 12:36:59 +02:00
Ed Bartosh
597c20d050 migrate kubelet/stats to contextual logging 2026-01-12 12:36:59 +02:00
Ed Bartosh
1fa4951dd5 migrate kubelet/podcertificate to contextual logging 2026-01-12 12:36:58 +02:00
Ed Bartosh
152c2e5d1c migrate kubelet/images/pullmanager to contextual logging 2026-01-12 12:36:53 +02:00
yliao
e02f0e2ba5 added unit test case to ensure implicit DRA extended resource is handled properly during pod admission at kubelet 2026-01-10 16:57:08 +00:00
Kubernetes Prow Robot
03e8ca9faa Merge pull request #136115 from harche/remove_year
Remove year from runtime_test.go file copyright notice
2026-01-10 03:23:38 +05:30
Kubernetes Prow Robot
da22735138 Merge pull request #136041 from richabanker/update-metrics-docs-1.35
Update metrics docs 1.35
2026-01-10 02:13:41 +05:30
Kubernetes Prow Robot
c68de67df3 Merge pull request #136132 from pohly/ktesting-default-verbosity
ktesting: avoid increasing default verbosity
2026-01-09 22:17:50 +05:30
Patrick Ohly
36a95a05eb ktesting: avoid increasing default verbosity
Bumping to 5 is useful in unit tests. Those tend to not produce less output and
ideally use per-test output, so we end up keeping only the output of failed
tests where increased verbosity also in CI runs is useful.

But ktesting now also gets imported into e2e test binaries through the
framework. There the increased verbosity is apparently causing OOM killing in
some jobs which previously worked fine.

Long term we need a better solution than simply disabling the verbosity
change. We could modify each unit test to call SetDefaultVerbosity, but that's
tedious. Perhaps an env variable? It cannot be a command line flag because not
all unit tests accept `-v`.
2026-01-09 14:54:09 +01:00
Davanum Srinivas
1b33c52ef1 Fix data race in devicemanager PluginDisconnected logging
Don't log the endpoint struct in PluginDisconnected() - it contains
a gRPC client and logging it via reflection races with Close().

The logger walks the struct with reflection, reading gRPC internals,
while Close() is modifying mutex state in the background. Removing
the endpoint from the log avoids the race. The resourceName is already
logged which is enough to identify which endpoint disconnected.

This race becomes visible with gRPC v1.76.0+ due to timing changes
in buffer handling and goroutine lifecycle during Close(). The
ci-kubernetes-unit-dependencies job was hitting this ~10% of the time
when testing with updated dependencies.

CI failures:
- https://storage.googleapis.com/kubernetes-ci-logs/logs/ci-kubernetes-unit-dependencies/2009065501396832256/build-log.txt
- https://storage.googleapis.com/kubernetes-ci-logs/logs/ci-kubernetes-unit-dependencies/2008641956699181056/build-log.txt
- https://storage.googleapis.com/kubernetes-ci-logs/logs/ci-kubernetes-unit-dependencies/2007491912692404224/build-log.txt
- https://storage.googleapis.com/kubernetes-ci-logs/logs/ci-kubernetes-unit-dependencies/2007431281842851840/build-log.txt

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2026-01-09 08:19:33 -05:00
Harshal Patil
6027ac1f2c Remove year from runtime_test.go file copyright notice
Signed-off-by: Harshal Patil <12152047+harche@users.noreply.github.com>
2026-01-08 15:45:56 -05:00
Kubernetes Prow Robot
f22cda03cb Merge pull request #135358 from harche/sort_hanlders
Sort runtime handlers list coming from the CRI runtime
2026-01-09 02:11:39 +05:30
Kubernetes Prow Robot
ca1f339c3e Merge pull request #136060 from tallclair/config-mux
Clean up Pod config sources: remove dead code
2026-01-08 07:05:39 +05:30
Tim Allclair
99f08f0091 Remove unused SET config update type. 2026-01-07 16:46:01 -08:00
Tim Allclair
fca9563853 Remove unused config.Sync function. 2026-01-07 16:46:01 -08:00
Kubernetes Prow Robot
8ab1bc1633 Merge pull request #135725 from bart0sh/PR211-add-extended-resources-test-cases
Fix extended resource handling for DRA-backed resources on pod admission
2026-01-08 04:03:42 +05:30
kkh
d733195cfe Fix potential goroutine leak in operation_executor_test.go
If the test times out in isOperationRunConcurrently, the receiver channel stops listening. The goroutine spawned in startOperationAndBlock then blocks forever on ch <- nil.

This commit updates startOperationAndBlock to use a select statement. It now waits for either the send to complete or the quit channel to be closed (signaling test completion). This ensures the goroutine exits cleanly even if the receiver is gone.

Signed-off-by: kkh <kkhdevs@gmail.com>
2026-01-08 00:37:00 +09:00
Neeraj Krishna Gopalakrishna
92129d36bf Add negative validation for imageMinimumGCAge 2026-01-07 06:56:14 +05:30
Tim Allclair
414f4e2770 Remove unused Snapshot config source modes. 2026-01-06 15:00:19 -08:00
Tim Allclair
fa1dfe4181 Clean up config source update merging: remove code handling unused
update types.
2026-01-06 14:59:48 -08:00
Richa Banker
de68e0ae8b Update metrics docs list for v1.35 2026-01-06 09:25:56 -08:00
Kubernetes Prow Robot
f36be36c76 Merge pull request #136037 from pravk03/ndf-fix
Prevent nil pointer dereference in HandlePodUpdates
2026-01-06 11:16:38 +05:30
Kubernetes Prow Robot
0f89b13c79 Merge pull request #135227 from hime/master
Inverting DRAOperationsDuration metric by inverting 'is_error' label.
2026-01-06 05:24:38 +05:30
Praveen Krishna
1ff74821f9 Fix: Prevent nil pointer dereference in HandlePodUpdates
In HandlePodUpdates, oldPod is nil for a mirror pod. Adding a nil check to prevent panic when the NodeDeclaredFeatures feature gate is enabled.
2026-01-05 20:41:45 +00:00
Harshal Patil
a770f8342d Sort runtime handlers list coming from the CRI runtime
Signed-off-by: Harshal Patil <12152047+harche@users.noreply.github.com>
2026-01-05 14:56:42 -05:00
Ed Bartosh
882cd02253 test: Add extended resource handling test coverage
Add unit test cases for extended resource handling in kubelet lifecycle
predicates and scheduler admission checks for resources backed up by
DRA and Device plugins.
2026-01-02 16:08:57 +02:00
Ed Bartosh
c2361491f5 Fix extended resource handling for DRA-backed resources
In kubelet admission:
   - Remove extended resources from pod requirements if they are either
     backed by DRA or not present in node's allocatable resources

In scheduler (fit.go):
   - Remove fallback logic that delegated all resources to DRA when
     draManager is nil

These changes ensure that:
- DRA-backed extended resources are properly handled during pod admission
- DevicePlugin-backed extended resources still follow standard admission rules
2026-01-02 16:08:49 +02:00
Kubernetes Prow Robot
bf0e7b694f Merge pull request #135856 from natasha41575/static_pod_check
[InPlacePodVerticalScaling] remove ineffectual static pod feasibility check
2025-12-31 07:18:34 +05:30
Natasha Sarkar
9c7a83d30f remove ineffectual static pod check for resize 2025-12-30 17:35:32 +00:00
qiuxue
a844386202 fix: resolve data race in WaitForAllPodsUnmount when collecting errors 2025-12-29 15:51:55 +08:00
bo.jiang
b1d7cb00cf Fix log validation messages and example typo
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
2025-12-23 10:10:28 +08:00
Davanum Srinivas
95cf1f264d Update to github.com/google/cadvisor v0.55.1
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2025-12-21 08:13:06 -05:00
Kubernetes Prow Robot
0ea3824860 Merge pull request #135845 from skitt/drop-armon-circbuf
Replace armon/circbuf with k8s.io/utils/buffer
2025-12-19 07:40:37 -08:00
Stephen Kitt
3653ae2b9a Replace armon/circbuf with k8s.io/utils/buffer
This uses the new generic fixed ring implementation in k8s.io/utils.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2025-12-19 09:59:41 +01:00
Ayato Tokubi
5108449511 Refactor comment in convertToAPIContainerStatuses 2025-12-18 16:15:35 +00:00