Commit Graph

257 Commits

Author SHA1 Message Date
Yuan Wang
f2a4ffd5b8 Promote ContainerRestartRules to beta
Fix prober not running properly with containerRestartRules and add unit test coverage
2025-10-21 23:58:39 +00:00
Kubernetes Prow Robot
031f4d541a Merge pull request #133072 from AadiDev005/fix-sidecar-startup-probe
Fix startup probe worker termination for sidecar containers
2025-10-20 12:26:37 -07:00
Kubernetes Prow Robot
c02a198b55 Merge pull request #130487 from zhifei92/migrate-kubelet-prober-to-contextual-logging
chore(kubelet): migrate prober to contextual logging
2025-09-05 11:13:25 -07:00
aditya
c97f08793c Fix startup probe worker termination for sidecar containers
Fixes a bug where startup probe workers terminate incorrectly for sidecar
containers with restartPolicy=Always when the pod has restartPolicy=Never,
causing main containers to remain stuck in Initializing state.

Changes:
- Add container-level restart policy check for init containers only
- Extract complex boolean logic to named variable for readability
- Refactor test helper to use existing newWorker() function
- Add comprehensive unit and e2e tests for both scenarios
2025-08-17 11:46:09 +05:30
zhangzhifei16
b6f6731ab6 chore(kubelet): migrate prober to contextual logging.
chore: and add the context
2025-07-28 16:42:52 +08:00
Yuan Wang
9086e52fee Implement restart rules in kubelet 2025-07-24 16:49:54 +00:00
xigang
4f0d3eaa36 enhance exec probe logging with pod and container context
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-07-11 18:59:14 +08:00
Kubernetes Prow Robot
cf6cc0f5d7 Merge pull request #130381 from royalsflush/probe-total-beta
Bumps up prober_probe_total from alpha to beta
2025-04-30 18:39:54 -07:00
Thomas N Tomei
a53ea3357c Updates prober_total_total to BETA and updates the list of stable metrics 2025-04-18 10:53:10 +01:00
Chulong Li
d868eeb088 Migrate pkg/kubelet/status to contextual logging
Update with logger from context

Fix nil pointer issue in TestUpdateReadiness
2025-03-20 21:58:14 +08:00
Kubernetes Prow Robot
5db66add7e Merge pull request #130000 from saschagrunert/typos
Fix pod worker and prober log message typos
2025-03-03 19:55:42 -08:00
Tim Allclair
fe4671356c Call allocationManager directly 2025-02-21 09:28:37 -08:00
Sascha Grunert
b05d56e5a5 Fix pod worker and prober log message typos
Two small typos which should be fixed accordingly.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2025-02-06 11:52:49 +01:00
Gunju Kim
0bee0bcaa7 Promote SidecarContainers feature to GA 2025-02-02 17:45:36 +09:00
Kubernetes Prow Robot
f34d791b13 Merge pull request #125901 from jralmaraz/kubelet_prober
Report event for the cases when probe returned Unknown result
2025-01-09 05:20:33 -08:00
vivzbansal
763e810fb5 refactor code to add sidecar container support in IPPR 2024-11-07 21:20:48 +00:00
Kubernetes Prow Robot
2f3da71f99 Merge pull request #121206 from mochizuki875/fix_startup_probe_117153
Stop StartupProbe explicity when successThrethold is reached
2024-11-06 00:35:28 +00:00
jralmaraz
e5ffba17be Report event for the cases when probe returned Unknown result
keep log success
2024-10-24 17:01:55 +11:00
Kubernetes Prow Robot
5fa794db46 Merge pull request #119089 from mochizuki875/add_probe_triggered_log
Add probe triggered log and shift the periodics timer after manual run
2024-10-23 02:20:54 +01:00
Kubernetes Prow Robot
a7fcc89ac0 Merge pull request #125936 from sivchari/use-ptr
use utils/ptr package instead of utils/pointer
2024-10-07 01:02:04 +01:00
sivchari
4eab3cca0a use utils/ptr package instead of utils/pointer
Signed-off-by: sivchari <shibuuuu5@gmail.com>
2024-10-03 11:33:12 +09:00
Matthieu MOREL
fa0e38981c fix: enable compares rule from testifylint in module k8s.io/kubernetes
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-22 11:20:05 +02:00
Abhishek Kr Srivastav
95860cff1c Fix Go vet errors for master golang
Co-authored-by: Rajalakshmi-Girish <rajalakshmi.girish1@ibm.com>
Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
2024-09-20 12:36:38 +05:30
mochizuki875
6191fb8a29 remove probeTicker log 2024-08-30 14:36:07 +00:00
mochizuki875
b3f9f1682f shift the periodics timer 2024-08-30 06:50:58 +00:00
mochizuki875
f337511ba5 Add probe triggered log 2024-08-30 06:46:18 +00:00
mochizuki875
632f162d71 fix unit test 2024-08-26 08:39:22 +00:00
mochizuki875
a262c806d2 fix from rv comment 2024-08-26 03:04:32 +00:00
mochizuki875
ead21021fd add threshold check using w.onHold 2024-08-26 02:01:56 +00:00
mochizuki875
11ddb97c5f add status check of startupProbe 2024-08-26 02:01:56 +00:00
mochizuki875
aa9a9e86e1 Stop StartupProbe explicity when successThrethold is reached 2024-08-26 02:01:56 +00:00
Tim Allclair
bfa7297ddd Add tallclair back to sig-node-approvers 2024-08-22 13:17:31 -07:00
Marek Siarkowicz
3ee8178768 Cleanup defer from SetFeatureGateDuringTest function call 2024-04-24 20:25:29 +02:00
HyunSu1768
59bf8b02e6 Refactoring to encourage use of switch case 2024-02-16 19:50:13 +09:00
Kubernetes Prow Robot
af18989486 Merge pull request #116931 from my-git9/CreateListener-ut
[ut] increase covrage for kubelet/prober/results
2023-10-31 01:22:29 +01:00
git-jxj
a5b3a4b738 cleanup: Update deprecated FromInt to FromInt32 (#119858)
* redo commit

* apply suggestions from liggitt

* update Parse function based on suggestions
2023-08-16 09:33:01 -07:00
Kubernetes Prow Robot
d4fde1e92a Merge pull request #118549 from a7i/kubelet-prober-metric-pod
fix 'pod' in kubelet prober metrics
2023-07-26 18:28:06 -07:00
Gunju Kim
7ef2d674e2 Allow restartable init containers to have livenessProbe 2023-07-18 07:54:33 +09:00
Gunju Kim
2c8b37498e Allow restartable init containers to have readinessProbe 2023-07-18 07:54:33 +09:00
Todd Neal
ea1eb7f8f7 implement sidecar resource calculation 2023-07-08 07:26:13 +09:00
Gunju Kim
b94fa250c2 Sidecar: Implement lifecycle of the restartable init container
- Implement `computeInitContainerActions` to sets the actions for the
  init containers, including those with `RestartPolicyAlways`.
- Allow StartupProbe on the restartable init containers.
- Update PodPhase considering the restartable init containers.
- Update PodInitialized status and status manager considering the
  restartable init containers.

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
2023-07-08 07:26:12 +09:00
Amir Alavi
d73923c8eb fix 'pod' in kubelet prober metrics 2023-06-07 19:48:10 -04:00
Clayton Coleman
bb568844b6 kubelet: Separate the MirrorClient from the PodManager
The two are not coupled except accidentally. Separate them and
update callsites. This will reduce the scope of PodManager interface
to make exposing the pod worker cleaner.
2023-05-12 12:57:26 -04:00
Kubernetes Prow Robot
a2e2df61a1 Merge pull request #117198 from charles-chenzz/deprecated_function
replace ioutil with os, update doc in kubelet
2023-05-02 08:18:14 -07:00
Stephen Kitt
0ee9f1b7a7 kubelet: replace intstr.FromInt with intstr.FromInt32
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2023-05-01 09:17:35 +02:00
charles-chenzz
ccf7ddacfc replace ioutil with os, update doc 2023-04-13 09:02:46 +08:00
xin.li
55d471601b [ut] increase covrage for kubelet/prober/results
Signed-off-by: xin.li <xin.li@daocloud.io>
2023-04-02 18:55:41 +08:00
Sergey Kanzhelev
e360de48b2 GRPCContainerProbe is GA 2023-03-02 22:07:59 +00:00
Chen Wang
7db339dba2 This commit contains the following:
1. Scheduler bug-fix + scheduler-focussed E2E tests
2. Add cgroup v2 support for in-place pod resize
3. Enable full E2E pod resize test for containerd>=1.6.9 and EventedPLEG related changes.

Co-Authored-By: Vinay Kulkarni <vskibum@gmail.com>
2023-02-24 18:21:21 +00:00
Vinay Kulkarni
f2bd94a0de In-place Pod Vertical Scaling - core implementation
1. Core Kubelet changes to implement In-place Pod Vertical Scaling.
2. E2E tests for In-place Pod Vertical Scaling.
3. Refactor kubelet code and add missing tests (Derek's kubelet review)
4. Add a new hash over container fields without Resources field to allow feature gate toggling without restarting containers not using the feature.
5. Fix corner-case where resize A->B->A gets ignored
6. Add cgroup v2 support to pod resize E2E test.
KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources

Co-authored-by: Chen Wang <Chen.Wang1@ibm.com>
2023-02-24 18:21:21 +00:00