Commit Graph

63955 Commits

Author SHA1 Message Date
Kubernetes Submit Queue
63a05c8bc9
Merge pull request #60720 from dashpole/allocatable_flake
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[Flaky Test] Increase amount of memory filled by memory allocatable eviction test

**What this PR does / why we need it**:
MemoryAllocatableEviction tests have been somewhat flaky: https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-serial-gce-e2e&include-filter-by-regex=MemoryAllocatable
The failure on the flakes is ["Pod ran to completion"](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial/3785#k8sio-memoryallocatableeviction-slow-serial-disruptive-when-we-run-containers-that-should-cause-memorypressure-should-eventually-evict-all-of-the-correct-pods).
Looking at [an example log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial/3785/artifacts/tmp-node-e2e-6070a774-cos-stable-63-10032-71-0/kubelet.log) (and search for memory-hog-pod, we can see that this pod fails admission because the allocatable memory threshold has already been crossed.
`eviction manager: thresholds - ignoring grace period: threshold [signal=allocatableMemory.available, quantity=250Mi] observed 242404Ki`
There is likely memory usage because the allocatable cgroup is not low on memory, and thus has not reclaimed all pages belonging to previous test containers.  Of the 300Mi of capacity in the allocatalbe cgroup, 250Mi is reserved for the eviction threshold, and only 50 is left for the test.  Increasing this to a 400Mi cgroup limit, with 150Mi for pods should eliminate this flake.

**Release note**:
```release-note
NONE
```

/sig node
/kind bug
/priority critical-urgent
/assign @Random-Liu @yujuhong
2018-03-02 18:35:55 -08:00
Kubernetes Submit Queue
e111ccbe09
Merge pull request #60731 from agau4779/network-tiers-test
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Expect NetworkTier not to be set as GCE value (all uppercase)

**What this PR does / why we need it**:
Reverts L76 and L123 from this PR - https://github.com/kubernetes/kubernetes/pull/59941/files#diff-497d33fc55a7de6c5bde6cbe33ecbb3cL78 . NetworkTier is set on the mock Service in Camel Case, not all uppercase.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60721

**Release note**:
```release-note
NONE
```

/assign MrHohn nicksardo
2018-03-02 18:35:52 -08:00
Kubernetes Submit Queue
47e6463bbb
Merge pull request #60159 from jingxu97/Feb/localephemeralBeta
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Promote LocalStorageCapacityIsolation feature to beta

The LocalStorageCapacityIsolation feature added a new resource type ResourceEphemeralStorage "ephemeral-storage" so that this resource can be allocated, limited, and consumed as the same way as CPU/memory. All the features related to resource management (resource request/limit, quota, limitrange) are available for local ephemeral storage.

This local ephemeral storage represents the storage for root file system, which will be consumed by containers' writtable layer and logs. Some volumes such as emptyDir might also consume this storage.

Fixes issue #60160

This PR also fixes data race issues discovered after open the feature gate. Basically setNodeStatus function in kubelet could be called by multiple threads so the data needs lock protection. Put the fix with this PR for easy testing.

**Release note**:

```release-note
ACTION REQUIRED: LocalStorageCapacityIsolation feature is beta and enabled by default. 
```
2018-03-02 18:35:49 -08:00
Harry Zhang
ea5f0b1de2 Remove example change to seperate repo 2018-03-02 17:12:02 -08:00
Harry Zhang
009699fd22 Update generated types 2018-03-02 17:12:02 -08:00
Harry Zhang
b62d82422d Fix golints in extender 2018-03-02 17:12:02 -08:00
Harry Zhang
71603f2f85 Add preemption in scheduler extender
Add verb and preemption for scheduler extender

Update bazel

Use simple preemption in extender

Use node name instead of v1.Node

Fix support method

Fix preemption dup

Remove uneeded logics

Remove nodeInfo from param to extender

Update bazel for scheduler types

Mock extender cache with nodeInfo

Add nodeInfo as extender cache

Choose node name or node based on cache flag

Always return meta victims in result
2018-03-02 17:12:02 -08:00
Eric Tune
af4aec6976 Update README.md of sample-apiserver.
Mention CRDs as option.
Link to CRD vs Aggr. docs.
Mention apiserver-builder as alternative.
2018-03-02 16:56:29 -08:00
Bobby (Babak) Salamat
ebda9584f9 Auto-create system critical prioity classes at API server startup 2018-03-02 16:50:07 -08:00
Kubernetes Submit Queue
79257fe611
Merge pull request #60669 from ixdy/bazel-test-visibility
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing

**What this PR does / why we need it**: adds the common test packages `//test/e2e/...` and `//test/integration/...` to the `COMMON_testing` package group.

The immediate need for this is that #60580 unintentionally broke the integration tests under bazel since it added a new dependency on `//pkg/kubectl/cmd/util` without adding an appropriate entry to `//build/visible_to:COMMON_testing`, and the integration tests aren't currently run under bazel for PRs. 

This PR fixes this breakage and proactively fixes future breakages by adding all packages under `//test/e2e` or `//test/integration` to `COMMON_testing`.

**Release note**:

```release-note
NONE
```

/assign @BenTheElder @monopole 
/kind bug
/priority important-soon
/sig testing
cc @kad
2018-03-02 15:13:21 -08:00
Jing Xu
b2e744c620 Promote LocalStorageCapacityIsolation feature to beta
The LocalStorageCapacityIsolation feature added a new resource type
ResourceEphemeralStorage "ephemeral-storage" so that this resource can
be allocated, limited, and consumed as the same way as CPU/memory. All
the features related to resource management (resource request/limit, quota, limitrange) are avaiable for local ephemeral storage.

This local ephemeral storage represents the storage for root file system, which will be consumed by containers' writtable layer and logs. Some volumes such as emptyDir might also consume this storage.
2018-03-02 15:10:08 -08:00
Kubernetes Submit Queue
36d9a0a1a8
Merge pull request #60704 from lioncruise/patch-8
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix a grammatical error in a comment

Fix a grammatical error in a comment in scheduler's code. We should use a word's plural form after "one of".



**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-02 14:25:57 -08:00
Kubernetes Submit Queue
30eb1aa7c5
Merge pull request #60648 from bskiba/hpa-unready
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Do not count failed pods as unready in HPA controller

**What this PR does / why we need it**:
Currently, when performing a scale up, any failed pods (which can be present for example in case of evictions performed by kubelet) will be treated as unready. Unready pods are treated as if they had 0% utilization which will slow down or even block scale up.

After this change, failed pods are ignored in all calculations. This way they do not influence neither scale up nor scale down replica calculations.

@MaciekPytel @DirectXMan12 

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #55630

**Special notes for your reviewer**:

**Release note**:
```
Stop counting failed pods as unready in HPA controller to avoid failed pods incorrectly affecting scale up replica count calculation.
```
2018-03-02 14:25:54 -08:00
Kubernetes Submit Queue
41399e0eec
Merge pull request #60689 from nikhita/bump-cobra-bash-alias
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

bump(6644d4): spf13/cobra: support bash completion for aliases

Fixes kubernetes/kubectl#120

`spf13/cobra` was recently bumped in https://github.com/kubernetes/kubernetes/pull/60530. The changes between then and now are:

- Fix generated bash completion for Bash 3 (OSX): fd32f09af1 
- Try out CircleCI: be77323fc0 (but we don't vendor this in anyway)
-  Do not add a space after a single flag completion: 1a618fb24b
- Bash completion aliases: a1e4933ab7 (the commit that fixes kubernetes/kubectl#120)
-  Prefix bash functions with root command name: 6644d46b81 (the commit that completely fixes https://github.com/kubernetes/kubernetes/issues/60517)

No license changes.

**Release note**:

```release-note
NONE
```

/cc mengqiy cblecker sttts
2018-03-02 14:25:51 -08:00
Kubernetes Submit Queue
6f1ee5775e
Merge pull request #60732 from ixdy/update-gazelle
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update gazelle to latest to fix vendoring issue

**What this PR does / why we need it**: Fixes #60730 for the master branch. There are otherwise no functional differences.

**Release note**:

```release-note
NONE
```

/priority critical-urgent
/milestone v1.10
/kind bug
/sig testing
2018-03-02 14:25:47 -08:00
Serguei Bezverkhi
5113037627 Swithcing to Official CSI 0.2.0 tag 2018-03-02 16:59:24 -05:00
Jun Xiang Tee
9758a0fedd improve daemonset's retry creating failed daemon pods e2e test 2018-03-02 13:37:58 -08:00
Ashley Gau
d21cbd716b requires string input 2018-03-02 12:14:15 -08:00
Jeff Grafton
0c1f69a213 Update gazelle to latest to fix vendoring issue 2018-03-02 11:58:31 -08:00
Ashley Gau
f923359522 Expect NetworkTier not to be set as GCE value (all uppercase) 2018-03-02 11:56:43 -08:00
Michelle Au
c4851c06d7 Cap max number of nodes to use for local PV e2e tests 2018-03-02 11:54:50 -08:00
Filipe Brandenburger
cea4c98508 Remove mapping to /host/lib from fluentd-gcp container.
This mapping is no longer needed since fluentd-gcp v2.0.16, in which it
started using a container image based on Debian Stretch, in which the
systemd libraries already include support for all the supported
compression algorithms.

The /run.sh in the image no longer accesses /host/lib anyways, so let's
stop mapping it here.

Related changes:
- fluentd-gcp on GoogleCloudPlatform/k8s-stackdriver#101
- fluentd-es on GoogleCloudPlatform/google-fluentd#80
2018-03-02 10:20:08 -08:00
David Ashpole
395bea9d83 increase amount of memory filled by memory allocatable eviction test 2018-03-02 10:00:03 -08:00
Dan Williams
394d928756 kubelet: notify systemd that kubelet has started
The notify call has no side-effects if systemd is not used or
not installed.

Fixes: https://github.com/kubernetes/kubernetes/issues/59079
2018-03-02 10:59:53 -06:00
Nikhita Raghunath
bae2db8b95 bump(6644d4): spf13/cobra: support bash completion for aliases 2018-03-02 21:28:13 +05:30
Jan Safranek
b9ad4cb57b Fix iSCSI image
- create 120MB LUN instead of 1MB for volume_io tests
- increase verbosity
- rebase to Fedora 26
  - targetcli now requires running dbus, so run it
2018-03-02 16:41:39 +01:00
Shijun Qin
158257473a
Fix a grammatical error in a comment
Fix a grammatical error in a comment in scheduler's code. We should use a word's plural form after "one of".
2018-03-02 21:30:44 +08:00
Kubernetes Submit Queue
ae1fc13aee
Merge pull request #60386 from k82cn/k8s_60163
Automatic merge from submit-queue (batch tested with PRs 60683, 60386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Added unschedulabe predicate.

Signed-off-by: Da K. Ma <madaxa@cn.ibm.com>

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60163

**Release note**:
```release-note
None
```
2018-03-02 03:41:50 -08:00
Kubernetes Submit Queue
164890bab7
Merge pull request #60683 from nilebox/pod-template-validation-fix
Automatic merge from submit-queue (batch tested with PRs 60683, 60386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix PodTemplate validation

**What this PR does / why we need it**:
This is a bugfix for pod template validation, which can be reproduced by deleting with "foreground deletion" mode (`DeleteOptions.PropagationPolicy = metav1.DeletePropagationForeground`).
Because of this bug GC will never delete a pod template with `foregroundDeletion` finalizer.

**Special notes for your reviewer**:
The issue was originally found and confirmed in the PR #59851, where switching to foreground deletion in `kubectl` broke a unit test revealing this bug.
Extracted for easier backporting to releases as suggested in https://github.com/kubernetes/kubernetes/pull/59851#discussion_r171576397

/cc @liggitt @caesarxuchao 
/sig api-machinery

```release-note
NONE
```
2018-03-02 03:41:47 -08:00
chentao1596
efb4c37270 fix some ineffectual assignments and misspellings for the package of 'pkg/kubelet/volumemanager' 2018-03-02 17:00:38 +08:00
Ryan Hitchman
ba16cd9071 Make sh2ju use awk instead of bc.
awk is available in all of our test runners (as part of busybox or debian base packages), bc is not.
2018-03-01 23:47:50 -08:00
hangaoshuai
805ac2c0f0 update Mount propagation version in comment 2018-03-02 13:03:30 +08:00
lcfang
7f38898abd fix the bad err 2018-03-02 12:14:35 +08:00
Nail Islamov
0d36ab2f39
Bugfix: Fix ordering of ValidateObjectMetaUpdate method arguments for PodTemplate validation 2018-03-02 14:36:20 +11:00
Kubernetes Submit Queue
f9f5677b3e
Merge pull request #60618 from rmmh/verify-explicit
Automatic merge from submit-queue (batch tested with PRs 60530, 60618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add support for `make verify WHAT=typecheck`

This will be used to make the typecheck job emit junit and avoids duplicating the rest of the verify logic.

**Release note**:
```release-note
NONE
```
2018-03-01 18:49:44 -08:00
Kubernetes Submit Queue
6605b0a645
Merge pull request #60530 from superbrothers/fix-60517
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix kubectl completion so that file names are listed

**What this PR does / why we need it**:
This PR fixes kubectl completion so that file names are listed with `--filename`. I tested in bash and zsh. This problem is caused by spf13/cobra#520, so I updates vendor github.com/spf13/cobra to just before that commit.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60517 

**Special notes for your reviewer**: @janetkuo @mengqiy @eparis 

**Release note**:

```release-note
NONE
```
2018-03-01 18:18:07 -08:00
CJ Cullen
3d2bfc2e67 Update cluster-proportional-autoscaler-amd64 in typha addon to w/ fix for CVE-2016-8859 2018-03-01 17:54:16 -08:00
hangaoshuai
ebec856cd3 fix todo: use a better way to keep this label unique in the tests 2018-03-02 09:33:43 +08:00
Kubernetes Submit Queue
71c89b4562
Merge pull request #60664 from jiayingz/dp_serial
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Moves the DevicePlugin e2e_node test back to Serial

I forgot the fact that the DevicePlugin test itself restarts Kubelet
for testing purpose. Move that test back to Serial but constructs
a smaller test without kubelet restart that we may run during presubmit.



**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes https://github.com/kubernetes/kubernetes/issues/60604

**Special notes for your reviewer**:

**Release note**:

```release-note

```
2018-03-01 17:14:56 -08:00
Kubernetes Submit Queue
060a66ae20
Merge pull request #60591 from MrHohn/fix-probableEOF-panic
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[e2e] Fix panicing ingress jobs

**What this PR does / why we need it**:
When a nil error is passed into IsProbableEOF(), test will panic. Ref https://github.com/kubernetes/kubernetes/issues/60381#issuecomment-369353511.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60381

**Special notes for your reviewer**:
/assign @shyamjvs 
cc @krzyzacy 

**Release note**:

```release-note
NONE
```
2018-03-01 15:23:57 -08:00
Kubernetes Submit Queue
5520e07fd1
Merge pull request #60456 from kow3ns/ds-conformance
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Adds daemonset conformance tests

**What this PR does / why we need it**: Adds conformance tests for deamonset

```release-note
Conformance tests are added for the DaemonSet kinds in the apps/v1 group version. Deprecated versions of DaemonSet will not be tested for conformance, and conformance is only applicable to release 1.10 and later.
```
2018-03-01 15:23:54 -08:00
Kubernetes Submit Queue
16980f21d1
Merge pull request #52077 from krmayankk/runas
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

API Changes for RunAsGroup

First set of api changes for feature https://github.com/kubernetes/community/pull/756
```release-note
Add ability to control primary GID of containers through pod Spec and PodSecurityPolicy
```
2018-03-01 15:23:51 -08:00
Ryan Hitchman
d295ca1134 Add support for make verify WHAT=typecheck.
This will be used to make the typecheck job emit junit and avoids
duplicating the rest of the verify logic.
2018-03-01 15:03:24 -08:00
Kenneth Owens
afd3fc3ee9 Add selector to DaemonSet in newDaemonSet function so that the v1 apis function for e2e 2018-03-01 14:49:22 -08:00
Jeff Grafton
046d9a0e53 Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing 2018-03-01 14:26:39 -08:00
Jiaying Zhang
6d7e6599f1 I forgot the fact that the DevicePlugin test itself restarts Kubelet
for testing purpose. Move that test back to Serial but constructs
a smaller test without kubelet restart that we may run during presubmit.
2018-03-01 14:02:09 -08:00
Srini Brahmaroutu
62204f6262 Adding details to Conformance Tests using RFC 2119 standards. 2018-03-01 12:12:55 -08:00
Kubernetes Submit Queue
209cdd9048
Merge pull request #60237 from crassirostris/audit-use-buffered-backend
Automatic merge from submit-queue (batch tested with PRs 60542, 60237). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Audit use buffered backend

This is the next step after https://github.com/kubernetes/kubernetes/pull/60076

This PR fixes https://github.com/kubernetes/kubernetes/issues/53020, to address https://github.com/kubernetes/kubernetes/issues/53006 later

In this PR buffered backend, introduced in https://github.com/kubernetes/kubernetes/pull/60076, is used to replace ad-hoc solution for webhook and add an ability to enable buffering for the log audit backend.

```release-note
Log audit backend can now be configured to perform batching before writing events to disk.
```

/cc @sttts @tallclair @ericchiang @CaoShuFeng
2018-03-01 11:42:48 -08:00
Kubernetes Submit Queue
571b1e20aa
Merge pull request #60542 from liggitt/terminating-crd
Automatic merge from submit-queue (batch tested with PRs 60542, 60237). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Allow update/patch of CRs while CRD is terminating

Fixes #60538

Update/patch need to be allowed so finalizers can act on custom resources for terminating CRDs

```release-note
Fixes potential deadlock when deleting CustomResourceDefinition for custom resources with finalizers
```
2018-03-01 11:42:45 -08:00
Kubernetes Submit Queue
46f05b0c2b
Merge pull request #60520 from shyamjvs/retry-delete-operations
Automatic merge from submit-queue (batch tested with PRs 60623, 60625, 60520). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add retries to resource deletions in testing framework

Fix https://github.com/kubernetes/kubernetes/issues/55860
(last piece towards fixing it hopefully)

/cc @wojtek-t 

```release-note
NONE
```
2018-03-01 09:03:52 -08:00