/* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package persistentvolumeclaim import ( "fmt" "reflect" "testing" "k8s.io/apimachinery/pkg/util/diff" utilfeature "k8s.io/apiserver/pkg/util/feature" featuregatetesting "k8s.io/component-base/featuregate/testing" "k8s.io/kubernetes/pkg/apis/core" "k8s.io/kubernetes/pkg/features" ) func TestDropDisabledSnapshotDataSource(t *testing.T) { pvcWithoutDataSource := func() *core.PersistentVolumeClaim { return &core.PersistentVolumeClaim{ Spec: core.PersistentVolumeClaimSpec{ DataSource: nil, }, } } apiGroup := "snapshot.storage.k8s.io" pvcWithDataSource := func() *core.PersistentVolumeClaim { return &core.PersistentVolumeClaim{ Spec: core.PersistentVolumeClaimSpec{ DataSource: &core.TypedLocalObjectReference{ APIGroup: &apiGroup, Kind: "VolumeSnapshot", Name: "test_snapshot", }, }, } } pvcInfo := []struct { description string hasDataSource bool pvc func() *core.PersistentVolumeClaim }{ { description: "pvc without DataSource", hasDataSource: false, pvc: pvcWithoutDataSource, }, { description: "pvc with DataSource", hasDataSource: true, pvc: pvcWithDataSource, }, { description: "is nil", hasDataSource: false, pvc: func() *core.PersistentVolumeClaim { return nil }, }, } for _, enabled := range []bool{true, false} { for _, oldpvcInfo := range pvcInfo { for _, newpvcInfo := range pvcInfo { oldPvcHasDataSource, oldpvc := oldpvcInfo.hasDataSource, oldpvcInfo.pvc() newPvcHasDataSource, newpvc := newpvcInfo.hasDataSource, newpvcInfo.pvc() if newpvc == nil { continue } t.Run(fmt.Sprintf("feature enabled=%v, old pvc %v, new pvc %v", enabled, oldpvcInfo.description, newpvcInfo.description), func(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeSnapshotDataSource, enabled)() var oldpvcSpec *core.PersistentVolumeClaimSpec if oldpvc != nil { oldpvcSpec = &oldpvc.Spec } DropDisabledFields(&newpvc.Spec, oldpvcSpec) // old pvc should never be changed if !reflect.DeepEqual(oldpvc, oldpvcInfo.pvc()) { t.Errorf("old pvc changed: %v", diff.ObjectReflectDiff(oldpvc, oldpvcInfo.pvc())) } switch { case enabled || oldPvcHasDataSource: // new pvc should not be changed if the feature is enabled, or if the old pvc had DataSource if !reflect.DeepEqual(newpvc, newpvcInfo.pvc()) { t.Errorf("new pvc changed: %v", diff.ObjectReflectDiff(newpvc, newpvcInfo.pvc())) } case newPvcHasDataSource: // new pvc should be changed if reflect.DeepEqual(newpvc, newpvcInfo.pvc()) { t.Errorf("new pvc was not changed") } // new pvc should not have DataSource if !reflect.DeepEqual(newpvc, pvcWithoutDataSource()) { t.Errorf("new pvc had DataSource: %v", diff.ObjectReflectDiff(newpvc, pvcWithoutDataSource())) } default: // new pvc should not need to be changed if !reflect.DeepEqual(newpvc, newpvcInfo.pvc()) { t.Errorf("new pvc changed: %v", diff.ObjectReflectDiff(newpvc, newpvcInfo.pvc())) } } }) } } } } // TestPVCDataSourceSpecFilter checks to ensure the DropDisabledFields function behaves correctly for PVCDataSource featuregate func TestPVCDataSourceSpecFilter(t *testing.T) { apiGroup := "" validSpec := core.PersistentVolumeClaimSpec{ DataSource: &core.TypedLocalObjectReference{ APIGroup: &apiGroup, Kind: "PersistentVolumeClaim", Name: "test_clone", }, } validSpecNilAPIGroup := core.PersistentVolumeClaimSpec{ DataSource: &core.TypedLocalObjectReference{ Kind: "PersistentVolumeClaim", Name: "test_clone", }, } invalidAPIGroup := "invalid.pvc.api.group" invalidSpec := core.PersistentVolumeClaimSpec{ DataSource: &core.TypedLocalObjectReference{ APIGroup: &invalidAPIGroup, Kind: "PersistentVolumeClaim", Name: "test_clone_invalid", }, } var tests = map[string]struct { spec core.PersistentVolumeClaimSpec want *core.TypedLocalObjectReference }{ "enabled with empty ds": { spec: core.PersistentVolumeClaimSpec{}, want: nil, }, "enabled with invalid spec": { spec: invalidSpec, want: nil, }, "enabled with valid spec": { spec: validSpec, want: validSpec.DataSource, }, "enabled with valid spec but nil APIGroup": { spec: validSpecNilAPIGroup, want: validSpecNilAPIGroup.DataSource, }, } for testName, test := range tests { t.Run(testName, func(t *testing.T) { DropDisabledFields(&test.spec, nil) if test.spec.DataSource != test.want { t.Errorf("expected drop datasource condition was not met, test: %s, spec: %v, expected: %v", testName, test.spec, test.want) } }) } }