mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-29 06:27:05 +00:00
096c3e8f2d
Panicing if not running in a test and if the component-base/version variables are empty is not ideal. At some point sections of kubeadm could be exposed as a library and if these sections import the constants package, they would panic on the library users unless they set the version information in component-base with ldflags. Instead: - If the component-base version is empty, return a placeholder version that should indicate to users that build kubeadm that something is not right (e.g. they did not use 'make'). During library usage or unit tests this version should not be relevant. - Update unit tests to use hardcoded versions instead of the versions from the constants package. Using the constants package for testing is good but during unit tests these versions are already placeholders since unit tests do not populate the actual component-base versions (e.g. 1.23).
234 lines
9.2 KiB
Go
234 lines
9.2 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package upgrade
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"k8s.io/apimachinery/pkg/util/version"
|
|
)
|
|
|
|
func TestEnforceVersionPolicies(t *testing.T) {
|
|
minimumKubeletVersion := version.MustParseSemantic("v1.3.0")
|
|
minimumControlPlaneVersion := version.MustParseSemantic("v1.3.0")
|
|
currentKubernetesVersion := version.MustParseSemantic("v1.4.0")
|
|
tests := []struct {
|
|
name string
|
|
vg *fakeVersionGetter
|
|
expectedMandatoryErrs int
|
|
expectedSkippableErrs int
|
|
allowExperimental, allowRCs bool
|
|
newK8sVersion string
|
|
}{
|
|
{
|
|
name: "minor upgrade",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeadmVersion: minimumControlPlaneVersion.WithPatch(5).String(),
|
|
},
|
|
newK8sVersion: minimumControlPlaneVersion.WithPatch(5).String(),
|
|
},
|
|
{
|
|
name: "major upgrade",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumControlPlaneVersion.WithPatch(2).String(),
|
|
kubeadmVersion: currentKubernetesVersion.WithPatch(1).String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.String(),
|
|
},
|
|
{
|
|
name: "downgrade",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.String(),
|
|
kubeadmVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
},
|
|
newK8sVersion: minimumControlPlaneVersion.WithPatch(2).String(),
|
|
},
|
|
{
|
|
name: "same version upgrade",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
},
|
|
newK8sVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
},
|
|
{
|
|
name: "new version must be higher than v1.12.0",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: "v1.12.3",
|
|
kubeletVersion: "v1.12.3",
|
|
kubeadmVersion: "v1.12.3",
|
|
},
|
|
newK8sVersion: "v1.10.10",
|
|
expectedMandatoryErrs: 1, // version must be higher than v1.12.0
|
|
expectedSkippableErrs: 1, // can't upgrade old k8s with newer kubeadm
|
|
},
|
|
{
|
|
name: "upgrading two minor versions in one go is not supported",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: "v1.11.3",
|
|
kubeletVersion: "v1.11.3",
|
|
kubeadmVersion: "v1.13.0",
|
|
},
|
|
newK8sVersion: "v1.13.0",
|
|
expectedMandatoryErrs: 1, // can't upgrade two minor versions
|
|
expectedSkippableErrs: 1, // kubelet <-> apiserver skew too large
|
|
},
|
|
{
|
|
name: "downgrading two minor versions in one go is not supported",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: currentKubernetesVersion.WithMinor(currentKubernetesVersion.Minor() + 2).String(),
|
|
kubeletVersion: currentKubernetesVersion.WithMinor(currentKubernetesVersion.Minor() + 2).String(),
|
|
kubeadmVersion: currentKubernetesVersion.String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.String(),
|
|
expectedMandatoryErrs: 1, // can't downgrade two minor versions
|
|
},
|
|
{
|
|
name: "kubeadm version must be higher than the new kube version. However, patch version skews may be forced",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
},
|
|
newK8sVersion: minimumControlPlaneVersion.WithPatch(5).String(),
|
|
expectedSkippableErrs: 1,
|
|
},
|
|
{
|
|
name: "kubeadm version must be higher than the new kube version. Trying to upgrade k8s to a higher minor version than kubeadm itself should never be supported",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.String(),
|
|
expectedMandatoryErrs: 1,
|
|
},
|
|
{
|
|
name: "the maximum skew between the cluster version and the kubelet versions should be one minor version. This may be forced through though.",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: "v1.12.0",
|
|
kubeletVersion: "v1.10.8",
|
|
kubeadmVersion: "v1.12.0",
|
|
},
|
|
newK8sVersion: "v1.12.0",
|
|
expectedSkippableErrs: 1,
|
|
},
|
|
{
|
|
name: "experimental upgrades supported if the flag is set",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: currentKubernetesVersion.WithPreRelease("beta.1").String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.WithPreRelease("beta.1").String(),
|
|
allowExperimental: true,
|
|
},
|
|
{
|
|
name: "release candidate upgrades supported if the flag is set",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: currentKubernetesVersion.WithPreRelease("rc.1").String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.WithPreRelease("rc.1").String(),
|
|
allowRCs: true,
|
|
},
|
|
{
|
|
name: "release candidate upgrades supported if the flag is set",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: currentKubernetesVersion.WithPreRelease("rc.1").String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.WithPreRelease("rc.1").String(),
|
|
allowExperimental: true,
|
|
},
|
|
{
|
|
name: "the user should not be able to upgrade to an experimental version if they haven't opted into that",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: currentKubernetesVersion.WithPreRelease("beta.1").String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.WithPreRelease("beta.1").String(),
|
|
allowRCs: true,
|
|
expectedSkippableErrs: 1,
|
|
},
|
|
{
|
|
name: "the user should not be able to upgrade to an release candidate version if they haven't opted into that",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: currentKubernetesVersion.WithPreRelease("rc.1").String(),
|
|
},
|
|
newK8sVersion: currentKubernetesVersion.WithPreRelease("rc.1").String(),
|
|
expectedSkippableErrs: 1,
|
|
},
|
|
{
|
|
name: "the user can't use a newer minor version of kubeadm to upgrade an older version of kubeadm",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.WithPatch(3).String(),
|
|
kubeletVersion: minimumKubeletVersion.WithPatch(3).String(),
|
|
kubeadmVersion: currentKubernetesVersion.String(),
|
|
},
|
|
newK8sVersion: minimumControlPlaneVersion.WithPatch(6).String(),
|
|
expectedSkippableErrs: 1, // can't upgrade old k8s with newer kubeadm
|
|
},
|
|
{
|
|
name: "build release supported at MinimumControlPlaneVersion",
|
|
vg: &fakeVersionGetter{
|
|
clusterVersion: minimumControlPlaneVersion.String(),
|
|
kubeletVersion: minimumControlPlaneVersion.String(),
|
|
kubeadmVersion: minimumControlPlaneVersion.WithBuildMetadata("build").String(),
|
|
},
|
|
newK8sVersion: minimumControlPlaneVersion.WithBuildMetadata("build").String(),
|
|
},
|
|
}
|
|
|
|
for _, rt := range tests {
|
|
t.Run(rt.name, func(t *testing.T) {
|
|
|
|
newK8sVer, err := version.ParseSemantic(rt.newK8sVersion)
|
|
if err != nil {
|
|
t.Fatalf("couldn't parse version %s: %v", rt.newK8sVersion, err)
|
|
}
|
|
|
|
actualSkewErrs := EnforceVersionPolicies(rt.vg, rt.newK8sVersion, newK8sVer, rt.allowExperimental, rt.allowRCs)
|
|
if actualSkewErrs == nil {
|
|
// No errors were seen. Report unit test failure if we expected to see errors
|
|
if rt.expectedMandatoryErrs+rt.expectedSkippableErrs > 0 {
|
|
t.Errorf("failed TestEnforceVersionPolicies\n\texpected errors but got none")
|
|
}
|
|
// Otherwise, just move on with the next test
|
|
return
|
|
}
|
|
|
|
if len(actualSkewErrs.Skippable) != rt.expectedSkippableErrs {
|
|
t.Errorf("failed TestEnforceVersionPolicies\n\texpected skippable errors: %d\n\tgot skippable errors: %d\n%#v\n%#v", rt.expectedSkippableErrs, len(actualSkewErrs.Skippable), *rt.vg, actualSkewErrs)
|
|
}
|
|
if len(actualSkewErrs.Mandatory) != rt.expectedMandatoryErrs {
|
|
t.Errorf("failed TestEnforceVersionPolicies\n\texpected mandatory errors: %d\n\tgot mandatory errors: %d\n%#v\n%#v", rt.expectedMandatoryErrs, len(actualSkewErrs.Mandatory), *rt.vg, actualSkewErrs)
|
|
}
|
|
})
|
|
}
|
|
}
|