kubernetes/pkg/scheduler/extender_test.go
Kante Yin febf95cc43 Stop Cache in scheduler when test tears down
Signed-off-by: Kante Yin <kerthcet@gmail.com>
2022-12-22 15:38:38 +08:00

521 lines
15 KiB
Go

/*
Copyright 2015 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package scheduler
import (
"context"
"reflect"
"testing"
"time"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/client-go/informers"
clientsetfake "k8s.io/client-go/kubernetes/fake"
extenderv1 "k8s.io/kube-scheduler/extender/v1"
schedulerapi "k8s.io/kubernetes/pkg/scheduler/apis/config"
"k8s.io/kubernetes/pkg/scheduler/framework"
"k8s.io/kubernetes/pkg/scheduler/framework/fake"
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultbinder"
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/queuesort"
"k8s.io/kubernetes/pkg/scheduler/framework/runtime"
internalcache "k8s.io/kubernetes/pkg/scheduler/internal/cache"
internalqueue "k8s.io/kubernetes/pkg/scheduler/internal/queue"
st "k8s.io/kubernetes/pkg/scheduler/testing"
)
func TestSchedulerWithExtenders(t *testing.T) {
tests := []struct {
name string
registerPlugins []st.RegisterPluginFunc
extenders []st.FakeExtender
nodes []string
expectedResult ScheduleResult
expectsErr bool
}{
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
},
{
ExtenderName: "FakeExtender2",
Predicates: []st.FitPredicate{st.ErrorPredicateExtender},
},
},
nodes: []string{"node1", "node2"},
expectsErr: true,
name: "test 1",
},
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
},
{
ExtenderName: "FakeExtender2",
Predicates: []st.FitPredicate{st.FalsePredicateExtender},
},
},
nodes: []string{"node1", "node2"},
expectsErr: true,
name: "test 2",
},
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
},
{
ExtenderName: "FakeExtender2",
Predicates: []st.FitPredicate{st.Node1PredicateExtender},
},
},
nodes: []string{"node1", "node2"},
expectedResult: ScheduleResult{
SuggestedHost: "node1",
EvaluatedNodes: 2,
FeasibleNodes: 1,
},
name: "test 3",
},
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.Node2PredicateExtender},
},
{
ExtenderName: "FakeExtender2",
Predicates: []st.FitPredicate{st.Node1PredicateExtender},
},
},
nodes: []string{"node1", "node2"},
expectsErr: true,
name: "test 4",
},
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
Prioritizers: []st.PriorityConfig{{Function: st.ErrorPrioritizerExtender, Weight: 10}},
Weight: 1,
},
},
nodes: []string{"node1"},
expectedResult: ScheduleResult{
SuggestedHost: "node1",
EvaluatedNodes: 1,
FeasibleNodes: 1,
},
name: "test 5",
},
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
Prioritizers: []st.PriorityConfig{{Function: st.Node1PrioritizerExtender, Weight: 10}},
Weight: 1,
},
{
ExtenderName: "FakeExtender2",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
Prioritizers: []st.PriorityConfig{{Function: st.Node2PrioritizerExtender, Weight: 10}},
Weight: 5,
},
},
nodes: []string{"node1", "node2"},
expectedResult: ScheduleResult{
SuggestedHost: "node2",
EvaluatedNodes: 2,
FeasibleNodes: 2,
},
name: "test 6",
},
{
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterScorePlugin("Node2Prioritizer", st.NewNode2PrioritizerPlugin(), 20),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.TruePredicateExtender},
Prioritizers: []st.PriorityConfig{{Function: st.Node1PrioritizerExtender, Weight: 10}},
Weight: 1,
},
},
nodes: []string{"node1", "node2"},
expectedResult: ScheduleResult{
SuggestedHost: "node2",
EvaluatedNodes: 2,
FeasibleNodes: 2,
}, // node2 has higher score
name: "test 7",
},
{
// Scheduler is expected to not send pod to extender in
// Filter/Prioritize phases if the extender is not interested in
// the pod.
//
// If scheduler sends the pod by mistake, the test would fail
// because of the errors from errorPredicateExtender and/or
// errorPrioritizerExtender.
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterScorePlugin("Node2Prioritizer", st.NewNode2PrioritizerPlugin(), 1),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.ErrorPredicateExtender},
Prioritizers: []st.PriorityConfig{{Function: st.ErrorPrioritizerExtender, Weight: 10}},
UnInterested: true,
},
},
nodes: []string{"node1", "node2"},
expectsErr: false,
expectedResult: ScheduleResult{
SuggestedHost: "node2",
EvaluatedNodes: 2,
FeasibleNodes: 2,
}, // node2 has higher score
name: "test 8",
},
{
// Scheduling is expected to not fail in
// Filter/Prioritize phases if the extender is not available and ignorable.
//
// If scheduler did not ignore the extender, the test would fail
// because of the errors from errorPredicateExtender.
registerPlugins: []st.RegisterPluginFunc{
st.RegisterFilterPlugin("TrueFilter", st.NewTrueFilterPlugin),
st.RegisterQueueSortPlugin(queuesort.Name, queuesort.New),
st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New),
},
extenders: []st.FakeExtender{
{
ExtenderName: "FakeExtender1",
Predicates: []st.FitPredicate{st.ErrorPredicateExtender},
Ignorable: true,
},
{
ExtenderName: "FakeExtender2",
Predicates: []st.FitPredicate{st.Node1PredicateExtender},
},
},
nodes: []string{"node1", "node2"},
expectsErr: false,
expectedResult: ScheduleResult{
SuggestedHost: "node1",
EvaluatedNodes: 2,
FeasibleNodes: 1,
},
name: "test 9",
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
client := clientsetfake.NewSimpleClientset()
informerFactory := informers.NewSharedInformerFactory(client, 0)
var extenders []framework.Extender
for ii := range test.extenders {
extenders = append(extenders, &test.extenders[ii])
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
cache := internalcache.New(time.Duration(0), ctx.Done())
for _, name := range test.nodes {
cache.AddNode(createNode(name))
}
fwk, err := st.NewFramework(
test.registerPlugins, "", ctx.Done(),
runtime.WithClientSet(client),
runtime.WithInformerFactory(informerFactory),
runtime.WithPodNominator(internalqueue.NewPodNominator(informerFactory.Core().V1().Pods().Lister())),
)
if err != nil {
t.Fatal(err)
}
sched := &Scheduler{
Cache: cache,
nodeInfoSnapshot: emptySnapshot,
percentageOfNodesToScore: schedulerapi.DefaultPercentageOfNodesToScore,
Extenders: extenders,
}
sched.applyDefaultHandlers()
podIgnored := &v1.Pod{}
result, err := sched.SchedulePod(ctx, fwk, framework.NewCycleState(), podIgnored)
if test.expectsErr {
if err == nil {
t.Errorf("Unexpected non-error, result %+v", result)
}
} else {
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
if !reflect.DeepEqual(result, test.expectedResult) {
t.Errorf("Expected: %+v, Saw: %+v", test.expectedResult, result)
}
}
})
}
}
func createNode(name string) *v1.Node {
return &v1.Node{ObjectMeta: metav1.ObjectMeta{Name: name}}
}
func TestIsInterested(t *testing.T) {
mem := &HTTPExtender{
managedResources: sets.NewString(),
}
mem.managedResources.Insert("memory")
for _, tc := range []struct {
label string
extender *HTTPExtender
pod *v1.Pod
want bool
}{
{
label: "Empty managed resources",
extender: &HTTPExtender{
managedResources: sets.NewString(),
},
pod: &v1.Pod{},
want: true,
},
{
label: "Managed memory, empty resources",
extender: mem,
pod: st.MakePod().Container("app").Obj(),
want: false,
},
{
label: "Managed memory, container memory with Requests",
extender: mem,
pod: st.MakePod().Req(map[v1.ResourceName]string{
"memory": "0",
}).Obj(),
want: true,
},
{
label: "Managed memory, container memory with Limits",
extender: mem,
pod: st.MakePod().Lim(map[v1.ResourceName]string{
"memory": "0",
}).Obj(),
want: true,
},
{
label: "Managed memory, init container memory",
extender: mem,
pod: st.MakePod().Container("app").InitReq(map[v1.ResourceName]string{
"memory": "0",
}).Obj(),
want: true,
},
} {
t.Run(tc.label, func(t *testing.T) {
if got := tc.extender.IsInterested(tc.pod); got != tc.want {
t.Fatalf("IsInterested(%v) = %v, wanted %v", tc.pod, got, tc.want)
}
})
}
}
func TestConvertToMetaVictims(t *testing.T) {
tests := []struct {
name string
nodeNameToVictims map[string]*extenderv1.Victims
want map[string]*extenderv1.MetaVictims
}{
{
name: "test NumPDBViolations is transferred from nodeNameToVictims to nodeNameToMetaVictims",
nodeNameToVictims: map[string]*extenderv1.Victims{
"node1": {
Pods: []*v1.Pod{
st.MakePod().Name("pod1").UID("uid1").Obj(),
st.MakePod().Name("pod3").UID("uid3").Obj(),
},
NumPDBViolations: 1,
},
"node2": {
Pods: []*v1.Pod{
st.MakePod().Name("pod2").UID("uid2").Obj(),
st.MakePod().Name("pod4").UID("uid4").Obj(),
},
NumPDBViolations: 2,
},
},
want: map[string]*extenderv1.MetaVictims{
"node1": {
Pods: []*extenderv1.MetaPod{
{UID: "uid1"},
{UID: "uid3"},
},
NumPDBViolations: 1,
},
"node2": {
Pods: []*extenderv1.MetaPod{
{UID: "uid2"},
{UID: "uid4"},
},
NumPDBViolations: 2,
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := convertToMetaVictims(tt.nodeNameToVictims); !reflect.DeepEqual(got, tt.want) {
t.Errorf("convertToMetaVictims() = %v, want %v", got, tt.want)
}
})
}
}
func TestConvertToVictims(t *testing.T) {
tests := []struct {
name string
httpExtender *HTTPExtender
nodeNameToMetaVictims map[string]*extenderv1.MetaVictims
nodeNames []string
podsInNodeList []*v1.Pod
nodeInfos framework.NodeInfoLister
want map[string]*extenderv1.Victims
wantErr bool
}{
{
name: "test NumPDBViolations is transferred from NodeNameToMetaVictims to newNodeNameToVictims",
httpExtender: &HTTPExtender{},
nodeNameToMetaVictims: map[string]*extenderv1.MetaVictims{
"node1": {
Pods: []*extenderv1.MetaPod{
{UID: "uid1"},
{UID: "uid3"},
},
NumPDBViolations: 1,
},
"node2": {
Pods: []*extenderv1.MetaPod{
{UID: "uid2"},
{UID: "uid4"},
},
NumPDBViolations: 2,
},
},
nodeNames: []string{"node1", "node2"},
podsInNodeList: []*v1.Pod{
st.MakePod().Name("pod1").UID("uid1").Obj(),
st.MakePod().Name("pod2").UID("uid2").Obj(),
st.MakePod().Name("pod3").UID("uid3").Obj(),
st.MakePod().Name("pod4").UID("uid4").Obj(),
},
nodeInfos: nil,
want: map[string]*extenderv1.Victims{
"node1": {
Pods: []*v1.Pod{
st.MakePod().Name("pod1").UID("uid1").Obj(),
st.MakePod().Name("pod3").UID("uid3").Obj(),
},
NumPDBViolations: 1,
},
"node2": {
Pods: []*v1.Pod{
st.MakePod().Name("pod2").UID("uid2").Obj(),
st.MakePod().Name("pod4").UID("uid4").Obj(),
},
NumPDBViolations: 2,
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// nodeInfos instantiations
nodeInfoList := make([]*framework.NodeInfo, 0, len(tt.nodeNames))
for i, nm := range tt.nodeNames {
nodeInfo := framework.NewNodeInfo()
node := createNode(nm)
nodeInfo.SetNode(node)
nodeInfo.AddPod(tt.podsInNodeList[i])
nodeInfo.AddPod(tt.podsInNodeList[i+2])
nodeInfoList = append(nodeInfoList, nodeInfo)
}
tt.nodeInfos = fake.NodeInfoLister(nodeInfoList)
got, err := tt.httpExtender.convertToVictims(tt.nodeNameToMetaVictims, tt.nodeInfos)
if (err != nil) != tt.wantErr {
t.Errorf("convertToVictims() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(got, tt.want) {
t.Errorf("convertToVictims() got = %v, want %v", got, tt.want)
}
})
}
}