mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-11-03 23:40:03 +00:00
b7630e4168
This PR adds trailing unit tests to check the service cluster IP range and improves the code coverage of k8s.io/kubernetes/cmd/kube-apiserver/app from 5.7% to 6.2%. 1) Dual stack IPv4/IPv6 2) Invalid IPv4, IPv6 mask 3) missing IPv4, IPv6 mask 4) invalid IP address format The tests 2, 3, 4 are suggsted by Antonio Ojea.
82 lines
3.3 KiB
Go
82 lines
3.3 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package app
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestGetServiceIPAndRanges(t *testing.T) {
|
|
tests := []struct {
|
|
body string
|
|
apiServerServiceIP string
|
|
primaryServiceIPRange string
|
|
secondaryServiceIPRange string
|
|
expectedError bool
|
|
}{
|
|
{"", "10.0.0.1", "10.0.0.0/24", "<nil>", false},
|
|
{"192.0.2.1/24", "192.0.2.1", "192.0.2.0/24", "<nil>", false},
|
|
{"192.0.2.1/24,192.168.128.0/17", "192.0.2.1", "192.0.2.0/24", "192.168.128.0/17", false},
|
|
// Dual stack IPv4/IPv6
|
|
{"192.0.2.1/24,2001:db2:1:3:4::1/112", "192.0.2.1", "192.0.2.0/24", "2001:db2:1:3:4::/112", false},
|
|
// Dual stack IPv6/IPv4
|
|
{"2001:db2:1:3:4::1/112,192.0.2.1/24", "2001:db2:1:3:4::1", "2001:db2:1:3:4::/112", "192.0.2.0/24", false},
|
|
|
|
{"192.0.2.1/30,192.168.128.0/17", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[0] IPv4 mask
|
|
{"192.0.2.1/33,192.168.128.0/17", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[1] IPv4 mask
|
|
{"192.0.2.1/24,192.168.128.0/33", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[0] IPv6 mask
|
|
{"2001:db2:1:3:4::1/129,192.0.2.1/24", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[1] IPv6 mask
|
|
{"192.0.2.1/24,2001:db2:1:3:4::1/129", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[0] missing IPv4 mask
|
|
{"192.0.2.1,192.168.128.0/17", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[1] missing IPv4 mask
|
|
{"192.0.2.1/24,192.168.128.1", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[0] missing IPv6 mask
|
|
{"2001:db2:1:3:4::1,192.0.2.1/24", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[1] missing IPv6 mask
|
|
{"192.0.2.1/24,2001:db2:1:3:4::1", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[0] IP address format
|
|
{"bad.ip.range,192.168.0.2/24", "<nil>", "<nil>", "<nil>", true},
|
|
// Invalid ip range[1] IP address format
|
|
{"192.168.0.2/24,bad.ip.range", "<nil>", "<nil>", "<nil>", true},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
apiServerServiceIP, primaryServiceIPRange, secondaryServiceIPRange, err := getServiceIPAndRanges(test.body)
|
|
|
|
if apiServerServiceIP.String() != test.apiServerServiceIP {
|
|
t.Errorf("expected apiServerServiceIP: %s, got: %s", test.apiServerServiceIP, apiServerServiceIP.String())
|
|
}
|
|
|
|
if primaryServiceIPRange.String() != test.primaryServiceIPRange {
|
|
t.Errorf("expected primaryServiceIPRange: %s, got: %s", test.primaryServiceIPRange, primaryServiceIPRange.String())
|
|
}
|
|
|
|
if secondaryServiceIPRange.String() != test.secondaryServiceIPRange {
|
|
t.Errorf("expected secondaryServiceIPRange: %s, got: %s", test.secondaryServiceIPRange, secondaryServiceIPRange.String())
|
|
}
|
|
|
|
if (err == nil) == test.expectedError {
|
|
t.Errorf("expected err to be: %t, but it was %t", test.expectedError, !test.expectedError)
|
|
}
|
|
}
|
|
}
|