mirror of
				https://github.com/k3s-io/kubernetes.git
				synced 2025-10-31 13:50:01 +00:00 
			
		
		
		
	Previously, the verious Merge() policies of the TopologyManager all eturned their own lifecycle.PodAdmitResult result. However, for consistency in any failed admits, this is better handled in the top-level Topology manager, with each policy only returning a boolean about whether or not they would like to admit the pod or not. This commit changes the semantics to match this logic.
		
			
				
	
	
		
			48 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			48 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
| Copyright 2019 The Kubernetes Authors.
 | |
| 
 | |
| Licensed under the Apache License, Version 2.0 (the "License");
 | |
| you may not use this file except in compliance with the License.
 | |
| You may obtain a copy of the License at
 | |
| 
 | |
|     http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
| Unless required by applicable law or agreed to in writing, software
 | |
| distributed under the License is distributed on an "AS IS" BASIS,
 | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| See the License for the specific language governing permissions and
 | |
| limitations under the License.
 | |
| */
 | |
| 
 | |
| package topologymanager
 | |
| 
 | |
| type bestEffortPolicy struct {
 | |
| 	//List of NUMA Nodes available on the underlying machine
 | |
| 	numaNodes []int
 | |
| }
 | |
| 
 | |
| var _ Policy = &bestEffortPolicy{}
 | |
| 
 | |
| // PolicyBestEffort policy name.
 | |
| const PolicyBestEffort string = "best-effort"
 | |
| 
 | |
| // NewBestEffortPolicy returns best-effort policy.
 | |
| func NewBestEffortPolicy(numaNodes []int) Policy {
 | |
| 	return &bestEffortPolicy{numaNodes: numaNodes}
 | |
| }
 | |
| 
 | |
| func (p *bestEffortPolicy) Name() string {
 | |
| 	return PolicyBestEffort
 | |
| }
 | |
| 
 | |
| func (p *bestEffortPolicy) canAdmitPodResult(hint *TopologyHint) bool {
 | |
| 	return true
 | |
| }
 | |
| 
 | |
| func (p *bestEffortPolicy) Merge(providersHints []map[string][]TopologyHint) (TopologyHint, bool) {
 | |
| 	filteredProvidersHints := filterProvidersHints(providersHints)
 | |
| 	bestHint := mergeFilteredHints(p.numaNodes, filteredProvidersHints)
 | |
| 	admit := p.canAdmitPodResult(&bestHint)
 | |
| 	return bestHint, admit
 | |
| }
 |