mirror of
				https://github.com/k3s-io/kubernetes.git
				synced 2025-10-31 13:50:01 +00:00 
			
		
		
		
	Errors from staticcheck: pkg/volume/azure_dd/azure_common.go:68:2: var winDiskNumFormat is unused (U1000) pkg/volume/csi/csi_block.go:97:2: field volumeInfo is unused (U1000) pkg/volume/csi/csi_block_test.go:56:6: func prepareBlockUnmapperTest is unused (U1000) pkg/volume/csi/csi_client.go:108:2: const initialDuration is unused (U1000) pkg/volume/csi/csi_client.go:109:2: const factor is unused (U1000) pkg/volume/csi/csi_client.go:110:2: const steps is unused (U1000) pkg/volume/csi/csi_client_test.go:83:8: this value of err is never used (SA4006) pkg/volume/csi/csi_mounter.go:76:2: field options is unused (U1000) pkg/volume/csi/csi_mounter_test.go:454:13: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:766:16: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:861:13: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:1186:13: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:1249:13: this value of err is never used (SA4006) pkg/volume/csi/csi_test.go:305:5: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002) pkg/volume/flexvolume/probe_test.go:67:10: this value of err is never used (SA4006) pkg/volume/iscsi/iscsi_test.go:95:2: field attachCalled is unused (U1000) pkg/volume/iscsi/iscsi_test.go:96:2: field detachCalled is unused (U1000) pkg/volume/iscsi/iscsi_test.go:501:24: this value of err is never used (SA4006) pkg/volume/iscsi/iscsi_util_test.go:159:2: this value of exist is never used (SA4006) pkg/volume/local/local.go:351:57: argument devicePath is overwritten before first use (SA4009) pkg/volume/plugins_test.go:119:2: this value of plug is never used (SA4006) pkg/volume/plugins_test.go:125:2: this value of plug is never used (SA4006) pkg/volume/quobyte/quobyte.go:474:23: this result of append is never used, except maybe in other appends (SA4010) pkg/volume/quobyte/quobyte.go:477:23: this result of append is never used, except maybe in other appends (SA4010) pkg/volume/quobyte/quobyte.go:480:23: this result of append is never used, except maybe in other appends (SA4010) pkg/volume/rbd/rbd.go:886:2: field adminSecret is unused (U1000) pkg/volume/rbd/rbd.go:887:2: field adminID is unused (U1000) pkg/volume/rbd/rbd.go:888:2: field imageFormat is unused (U1000) pkg/volume/rbd/rbd.go:889:2: field imageFeatures is unused (U1000) pkg/volume/storageos/storageos.go:302:2: field secretName is unused (U1000) pkg/volume/storageos/storageos_util_test.go:43:2: field apiAddr is unused (U1000) pkg/volume/storageos/storageos_util_test.go:44:2: field apiUser is unused (U1000) pkg/volume/storageos/storageos_util_test.go:45:2: field apiPass is unused (U1000) pkg/volume/storageos/storageos_util_test.go:46:2: field apiVersion is unused (U1000) pkg/volume/util/atomic_writer_test.go:756:49: argument err is overwritten before first use (SA4009) pkg/volume/util/fsquota/common/quota_linux_common.go:37:2: const acct is unused (U1000) pkg/volume/util/fsquota/common/quota_linux_common.go:38:2: const enforcing is unused (U1000) pkg/volume/util/fsquota/project.go:168:31: identical expressions on the left and right side of the '==' operator (SA4000) pkg/volume/util/fsquota/quota_linux.go:306:50: argument poduid is overwritten before first use (SA4009) pkg/volume/util/fsquota/quota_linux_test.go:558:16: this value of err is never used (SA4006) pkg/volume/util/subpath/subpath_linux.go:232:81: argument err is overwritten before first use (SA4009) pkg/volume/util/subpath/subpath_linux_test.go:579:73: argument err is overwritten before first use (SA4009)
		
			
				
	
	
		
			228 lines
		
	
	
		
			6.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			228 lines
		
	
	
		
			6.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
| Copyright 2017 The Kubernetes Authors.
 | |
| 
 | |
| Licensed under the Apache License, Version 2.0 (the "License");
 | |
| you may not use this file except in compliance with the License.
 | |
| You may obtain a copy of the License at
 | |
| 
 | |
|     http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
| Unless required by applicable law or agreed to in writing, software
 | |
| distributed under the License is distributed on an "AS IS" BASIS,
 | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| See the License for the specific language governing permissions and
 | |
| limitations under the License.
 | |
| */
 | |
| 
 | |
| package storageos
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"os"
 | |
| 	"testing"
 | |
| 
 | |
| 	storageostypes "github.com/storageos/go-api/types"
 | |
| 	"k8s.io/utils/mount"
 | |
| 
 | |
| 	v1 "k8s.io/api/core/v1"
 | |
| 	utiltesting "k8s.io/client-go/util/testing"
 | |
| 	"k8s.io/kubernetes/pkg/volume"
 | |
| 	volumetest "k8s.io/kubernetes/pkg/volume/testing"
 | |
| )
 | |
| 
 | |
| var testVolName = "storageos-test-vol"
 | |
| var testPVName = "storageos-test-pv"
 | |
| var testNamespace = "storageos-test-namespace"
 | |
| var testSize = 1
 | |
| var testDesc = "testdescription"
 | |
| var testPool = "testpool"
 | |
| var testFSType = "ext2"
 | |
| var testVolUUID = "01c43d34-89f8-83d3-422b-43536a0f25e6"
 | |
| 
 | |
| func GetAPIConfig() *storageosAPIConfig {
 | |
| 	return &storageosAPIConfig{
 | |
| 		apiAddr:    "http://5.6.7.8:9999",
 | |
| 		apiUser:    "abc",
 | |
| 		apiPass:    "123",
 | |
| 		apiVersion: "10",
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestClient(t *testing.T) {
 | |
| 	util := storageosUtil{}
 | |
| 	err := util.NewAPI(GetAPIConfig())
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("error getting api config: %v", err)
 | |
| 	}
 | |
| 	if util.api == nil {
 | |
| 		t.Errorf("client() unexpectedly returned nil")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| type fakeAPI struct{}
 | |
| 
 | |
| func (f fakeAPI) Volume(namespace string, ref string) (*storageostypes.Volume, error) {
 | |
| 	if namespace == testNamespace && ref == testVolName {
 | |
| 		return &storageostypes.Volume{
 | |
| 			ID:        "01c43d34-89f8-83d3-422b-43536a0f25e6",
 | |
| 			Name:      ref,
 | |
| 			Pool:      "default",
 | |
| 			Namespace: namespace,
 | |
| 			Size:      5,
 | |
| 		}, nil
 | |
| 	}
 | |
| 	return nil, fmt.Errorf("not found")
 | |
| }
 | |
| func (f fakeAPI) VolumeCreate(opts storageostypes.VolumeCreateOptions) (*storageostypes.Volume, error) {
 | |
| 
 | |
| 	// Append a label from the api
 | |
| 	labels := opts.Labels
 | |
| 	labels["labelfromapi"] = "apilabel"
 | |
| 
 | |
| 	return &storageostypes.Volume{
 | |
| 		ID:          testVolUUID,
 | |
| 		Name:        opts.Name,
 | |
| 		Namespace:   opts.Namespace,
 | |
| 		Description: opts.Description,
 | |
| 		Pool:        opts.Pool,
 | |
| 		Size:        opts.Size,
 | |
| 		FSType:      opts.FSType,
 | |
| 		Labels:      labels,
 | |
| 	}, nil
 | |
| }
 | |
| func (f fakeAPI) VolumeMount(opts storageostypes.VolumeMountOptions) error {
 | |
| 	return nil
 | |
| }
 | |
| func (f fakeAPI) VolumeUnmount(opts storageostypes.VolumeUnmountOptions) error {
 | |
| 	return nil
 | |
| }
 | |
| func (f fakeAPI) VolumeDelete(opts storageostypes.DeleteOptions) error {
 | |
| 	return nil
 | |
| }
 | |
| func (f fakeAPI) Node(ref string) (*storageostypes.Node, error) {
 | |
| 	return &storageostypes.Node{}, nil
 | |
| }
 | |
| 
 | |
| func TestCreateVolume(t *testing.T) {
 | |
| 
 | |
| 	tmpDir, err := utiltesting.MkTmpdir("storageos_test")
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("can't make a temp dir: %v", err)
 | |
| 	}
 | |
| 	defer os.RemoveAll(tmpDir)
 | |
| 	plugMgr := volume.VolumePluginMgr{}
 | |
| 	plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
 | |
| 	plug, _ := plugMgr.FindPluginByName("kubernetes.io/storageos")
 | |
| 
 | |
| 	// Use real util with stubbed api
 | |
| 	util := &storageosUtil{}
 | |
| 	util.api = fakeAPI{}
 | |
| 
 | |
| 	labels := map[string]string{
 | |
| 		"labelA": "valueA",
 | |
| 		"labelB": "valueB",
 | |
| 	}
 | |
| 
 | |
| 	options := volume.VolumeOptions{
 | |
| 		PVName:                        testPVName,
 | |
| 		PVC:                           volumetest.CreateTestPVC(fmt.Sprintf("%dGi", testSize), []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce}),
 | |
| 		PersistentVolumeReclaimPolicy: v1.PersistentVolumeReclaimDelete,
 | |
| 	}
 | |
| 
 | |
| 	provisioner := &storageosProvisioner{
 | |
| 		storageosMounter: &storageosMounter{
 | |
| 			storageos: &storageos{
 | |
| 				pvName:       testPVName,
 | |
| 				volName:      testVolName,
 | |
| 				volNamespace: testNamespace,
 | |
| 				sizeGB:       testSize,
 | |
| 				pool:         testPool,
 | |
| 				description:  testDesc,
 | |
| 				fsType:       testFSType,
 | |
| 				labels:       labels,
 | |
| 				manager:      util,
 | |
| 				plugin:       plug.(*storageosPlugin),
 | |
| 			},
 | |
| 		},
 | |
| 		options: options,
 | |
| 	}
 | |
| 
 | |
| 	vol, err := util.CreateVolume(provisioner)
 | |
| 	if err != nil {
 | |
| 		t.Errorf("CreateVolume() returned error: %v", err)
 | |
| 	}
 | |
| 	if vol == nil {
 | |
| 		t.Fatalf("CreateVolume() vol is empty")
 | |
| 	}
 | |
| 	if vol.ID == "" {
 | |
| 		t.Error("CreateVolume() vol ID is empty")
 | |
| 	}
 | |
| 	if vol.Name != testVolName {
 | |
| 		t.Errorf("CreateVolume() returned unexpected Name %s", vol.Name)
 | |
| 	}
 | |
| 	if vol.Namespace != testNamespace {
 | |
| 		t.Errorf("CreateVolume() returned unexpected Namespace %s", vol.Namespace)
 | |
| 	}
 | |
| 	if vol.Pool != testPool {
 | |
| 		t.Errorf("CreateVolume() returned unexpected Pool %s", vol.Pool)
 | |
| 	}
 | |
| 	if vol.FSType != testFSType {
 | |
| 		t.Errorf("CreateVolume() returned unexpected FSType %s", vol.FSType)
 | |
| 	}
 | |
| 	if vol.SizeGB != testSize {
 | |
| 		t.Errorf("CreateVolume() returned unexpected Size %d", vol.SizeGB)
 | |
| 	}
 | |
| 	if len(vol.Labels) == 0 {
 | |
| 		t.Error("CreateVolume() Labels are empty")
 | |
| 	} else {
 | |
| 		var val string
 | |
| 		var ok bool
 | |
| 		for k, v := range labels {
 | |
| 			if val, ok = vol.Labels[k]; !ok {
 | |
| 				t.Errorf("CreateVolume() Label %s not set", k)
 | |
| 			}
 | |
| 			if val != v {
 | |
| 				t.Errorf("CreateVolume() returned unexpected Label value %s", val)
 | |
| 			}
 | |
| 		}
 | |
| 		if val, ok = vol.Labels["labelfromapi"]; !ok {
 | |
| 			t.Error("CreateVolume() Label from api not set")
 | |
| 		}
 | |
| 		if val != "apilabel" {
 | |
| 			t.Errorf("CreateVolume() returned unexpected Label value %s", val)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestAttachVolume(t *testing.T) {
 | |
| 	tmpDir, err := utiltesting.MkTmpdir("storageos_test")
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("can't make a temp dir: %v", err)
 | |
| 	}
 | |
| 	defer os.RemoveAll(tmpDir)
 | |
| 	plugMgr := volume.VolumePluginMgr{}
 | |
| 	plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
 | |
| 	plug, _ := plugMgr.FindPluginByName("kubernetes.io/storageos")
 | |
| 
 | |
| 	// Use real util with stubbed api
 | |
| 	util := &storageosUtil{}
 | |
| 	util.api = fakeAPI{}
 | |
| 
 | |
| 	mounter := &storageosMounter{
 | |
| 		storageos: &storageos{
 | |
| 			volName:      testVolName,
 | |
| 			volNamespace: testNamespace,
 | |
| 			manager:      util,
 | |
| 			mounter:      mount.NewFakeMounter(nil),
 | |
| 			plugin:       plug.(*storageosPlugin),
 | |
| 		},
 | |
| 		deviceDir: tmpDir,
 | |
| 	}
 | |
| 	if err != nil {
 | |
| 		t.Errorf("Failed to make a new Mounter: %v", err)
 | |
| 	}
 | |
| 	if mounter == nil {
 | |
| 		t.Errorf("Got a nil Mounter")
 | |
| 	}
 | |
| }
 |