mirror of
https://github.com/k3s-io/kubernetes.git
synced 2026-01-17 07:14:58 +00:00
03fc51f74f
Automatic merge from submit-queue Stabilize map order in kubectl describe Refs #25251. Add `SortedResourceNames()` methods to map type aliases in order to achieve stable output order for `kubectl` descriptors. This affects QoS classes, resource limits, and resource requests. A few remarks: 1. I couldn't find map usages for described fields other than the ones mentioned above. Then again, I failed to identify those programmatically/systematically. Pointers given, I'd be happy to cover any gaps within this PR or along additional ones. 1. It's somewhat difficult to deterministically test a function that brings reliable ordering to Go maps due to its randomizing nature. None of the possibilities I came up with (rely a "probabilistic testing" against repeatedly created maps, add complexity through additional interfaces) seemed very appealing to me, so I went with testing my `sort.Interface` implementation and the changed logic in `kubectl.describeContainers()`. 1. It's apparently not possible to implement a single function that sorts any map's keys generically in Go without producing lots of boilerplate: a `map[<key type>]interface{}` is different from any other map type and thus requires explicit iteration on the caller site to convert back and forth. Unfortunately, this makes it hard to completely avoid code/test duplication. Please let me know what you think.