Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue 49670bee18
Merge pull request #66429 from andyzhangx/acr-sp-fix
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix acr could not be listed in sp issue

**What this PR does / why we need it**:
after granting sp access to azure ACR , pull image from ACR would fail, and after wait about 15-30min(or restart kubelet directly), pull image would succeed. Root cause is that `servicePrincipalToken` needs to be refreshed when doing `registryClient.List`, otherwise it will always return empty registry list. Pull image error would be like following:
```
Events:
  Type     Reason                 Age              From                               Message
  ----     ------                 ----             ----                               -------
  Warning  FailedScheduling       8m (x3 over 8m)  default-scheduler                  0/1 nodes are available: 1 Insufficient cpu.
  Normal   Scheduled              8m               default-scheduler                  Successfully assigned nginx-server-776564f79c-zhtjk to aks-nodepool1-20881069-0
  Normal   SuccessfulMountVolume  8m               kubelet, aks-nodepool1-20881069-0  MountVolume.SetUp succeeded for volume "default-token-4t7tk"
  Normal   SuccessfulMountVolume  8m               kubelet, aks-nodepool1-20881069-0  MountVolume.SetUp succeeded for volume "pvc-5c1f0521-739f-11e8-9b69-0a58ac1f09c2"
  Warning  Failed                 8m (x5 over 8m)  kubelet, aks-nodepool1-20881069-0  Error: ImagePullBackOff
  Normal   BackOff                8m (x5 over 8m)  kubelet, aks-nodepool1-20881069-0  Back-off pulling image "andyacr.azurecr.io/nginx-server:1.0.0"
  Warning  Failed                 8m (x2 over 8m)  kubelet, aks-nodepool1-20881069-0  Error: ErrImagePull
  Warning  Failed                 8m (x2 over 8m)  kubelet, aks-nodepool1-20881069-0  Failed to pull image "andyacr.azurecr.io/nginx-server:1.0.0": rpc error: code = Unknown desc = Error response from daemon: Get https://andyacr.azurecr.io/v2/nginx-server/manifests/1.0.0: unauthorized: authentication required
```

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65225

**Special notes for your reviewer**:
After discuss with dong, `registryClient.List` won't be necessary, instead we return `{"*.azurecr.io", "*.azurecr.cn", "*.azurecr.de", "*.azurecr.us"}` like aws, gce code logic, it will do the url matching.
I will cherry pick this PR to all supported version, every version has this issue.

**Release note**:

```
fix acr could not be listed in sp issue
```

/sig azure
/assign @feiskyer @khenidak @brendandburns @karataliu
2018-07-22 21:18:26 -07:00
.github housekeeping: improved language used in ISSUE_TEMPLATE.md 2018-06-05 20:14:27 +10:00
api Move api rules list under api-approvers-owned package 2018-07-20 10:16:08 -04:00
build Merge pull request #66463 from m1kola/docs_how_to_build_specific_binary 2018-07-20 17:21:43 -07:00
cluster Merge pull request #66152 from Random-Liu/update-crictl 2018-07-20 12:12:09 -07:00
cmd Merge pull request #66341 from runiq/kubeadm-no-uid-in-spec 2018-07-20 16:02:05 -07:00
docs Merge pull request #63418 from roycaihw/openapi-delete-path 2018-07-17 07:44:44 -07:00
Godeps Update Godeps after removing influx tests 2018-07-19 21:12:11 -04:00
hack Merge pull request #66061 from cofyc/prefer_using_process_environments 2018-07-20 18:51:09 -07:00
logo
pkg Merge pull request #66429 from andyzhangx/acr-sp-fix 2018-07-22 21:18:26 -07:00
plugin Merge pull request #65572 from yue9944882/fixes-admission-operation-mismatch-for-create-on-update 2018-07-19 10:42:54 -07:00
staging Merge pull request #65558 from apelisse/dry-run-feature-gate 2018-07-20 18:51:14 -07:00
test Merge pull request #66405 from davidz627/fix/subpathTestTimeout 2018-07-20 16:02:08 -07:00
third_party Update to gazelle 0.12.0 and run hack/update-bazel.sh 2018-06-22 16:22:18 -07:00
translations Merge pull request #64773 from MasayaAoyama/add-port-foward-examples 2018-06-20 14:21:14 -07:00
vendor Update Godeps after removing influx tests 2018-07-19 21:12:11 -04:00
.bazelrc
.generated_files
.gitattributes
.gitignore Don't gitignore pkg/generated/bindata.go 2018-07-09 11:35:01 -07:00
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md Typo fix: toto -> to 2018-06-12 23:12:39 +08:00
CHANGELOG-1.5.md
CHANGELOG-1.6.md
CHANGELOG-1.7.md Update CHANGELOG-1.7.md for v1.7.16. 2018-04-04 13:07:30 +00:00
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.15. 2018-07-11 21:32:48 +00:00
CHANGELOG-1.9.md Update CHANGELOG-1.9.md for v1.9.9. 2018-06-29 05:49:31 +00:00
CHANGELOG-1.10.md Update CHANGELOG-1.10.md for v1.10.5. 2018-06-21 13:07:14 +00:00
CHANGELOG-1.11.md Update CHANGELOG-1.11.md for v1.11.1. 2018-07-17 20:03:54 +00:00
CHANGELOG.md Insert human curated 1.11 release notes and set current version 2018-06-27 19:19:19 -04:00
code-of-conduct.md
CONTRIBUTING.md
LICENSE
Makefile
Makefile.generated_files
OWNERS root OWNERS: escape backslashes 2018-04-13 10:42:22 -07:00
OWNERS_ALIASES add sjenning to sig-node-reviewers 2018-06-26 14:07:44 -05:00
README.md
SECURITY_CONTACTS add PST to main SECURITY_CONTACTS as formality 2018-05-24 10:52:33 -04:00
SUPPORT.md
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts; providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide, and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics