Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue a4eb2f96d0
Merge pull request #57610 from vikaschoudhary16/remove-redundant-sleep
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove redundant sleep from ReRegistration unit test case

/kind cleanup
/sig node

**What this PR does / why we need it**:
Once upon a time, there was a race in the device plugin registration logic.  At that time, [list()](5cac9fc984/pkg/kubelet/deviceplugin/manager.go (L206)) and [listAndWatch()](5cac9fc984/pkg/kubelet/deviceplugin/manager.go (L224)) used to be separate functions. Race was there for taking manager.mutex lock from two places. [One, from within the m.addEndpoint()](5cac9fc984/pkg/kubelet/deviceplugin/manager.go (L214)) and the [second, from within m.Devices()](5cac9fc984/pkg/kubelet/deviceplugin/manager.go (L137)).  This race was making `TestDevicePluginReRegistration` flaky as explained below.
 	
```
1.     p1.Register(socketName, testResourceName)
2.  	// Wait for the first callback to be issued.
3.  	<-callbackChan
4.        devices := m.Devices()  
```
* L#1 leads to eventually **asynchronous** invocation of m.addEndpoint(), let say **thread1**.
* L#3 holds the test case execution till the [callback gets invoked](5cac9fc984/pkg/kubelet/deviceplugin/endpoint.go (L108)). This means test case execution waits on channel till the **thread1**  reaches the point where [e.list() call completes in the addEndpoint.](5cac9fc984/pkg/kubelet/deviceplugin/manager.go (L206)) 
* L#4 triggers a new thread. thread1 and this new thread are both racing for m.mutex.Lock(). Former, in the addEndpoint() and later one in the m.Devices(). If m.Devices wins the race, result is the test case failure because endpoint gets added in the manager only after taking mutex.Lock() in the addEndpoint().

To deal with this flake, we added `Sleep` between L#3 and L#4.  `Sleep` was getting some extra time to addEndpoint() and thus making thread1 win the race each time.

Above explained race scenario got fixed and merged sometime back in this PR:
[Deviceplugin refactoring: merge func list and listwatch in endpoint into one](https://github.com/kubernetes/kubernetes/pull/52149)
With the above PR, callback function is invoked from e.run() which makes sure that test case waits on channel till the endpoint is added and devices are updated
Above explained race scenario does not exist now, therefore removing redundant sleeps from the test case.

Tested:
go test -race -count 500 k8s.io/kubernetes/pkg/kubelet/cm/deviceplugin -run TestDevicePluginReRegistration  -timeout 5h

Related #52616 #56026 

**Special notes for your reviewer**:

**Release note**:

```release-note
None
```
/cc @vishh @derekwaynecarr @jiayingz @RenaudWasTaken @lichuqiang @ScorpioCPH @tengqm @mindprince @ConnorDoyle @jeremyeder
2017-12-27 14:53:21 -08:00
.github
api Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
build Bump rules_go to 0.8.1 2017-12-23 13:12:02 -08:00
cluster Update helper scripts to find binaries in new bazel-bin paths 2017-12-23 13:13:09 -08:00
cmd Merge pull request #57594 from m1093782566/hairpin 2017-12-26 03:59:59 -08:00
docs Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
examples Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
Godeps Merge pull request #57520 from nicksardo/update-gce 2017-12-22 21:03:53 -08:00
hack Update helper scripts to find binaries in new bazel-bin paths 2017-12-23 13:13:09 -08:00
logo
pkg Merge pull request #57610 from vikaschoudhary16/remove-redundant-sleep 2017-12-27 14:53:21 -08:00
plugin Merge pull request #57132 from zjj2wry/kube-schedule-initflag 2017-12-25 10:53:28 -08:00
staging Switch go binaries from (hacky) static to pure Go 2017-12-23 13:13:09 -08:00
test Merge pull request #57604 from ianchakeres/lv-prov-config 2017-12-27 13:13:15 -08:00
third_party Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
translations
vendor Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
.bazelrc
.generated_files
.gitattributes
.gitignore
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
CHANGELOG-1.5.md Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
CHANGELOG-1.6.md Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
CHANGELOG-1.7.md Update CHANGELOG-1.7.md for v1.7.11. 2017-11-25 16:37:13 -05:00
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.6. 2017-12-21 09:50:30 -08:00
CHANGELOG-1.9.md Update CHANGELOG-1.9.md for v1.9.0. 2017-12-15 14:15:58 -08:00
CHANGELOG-1.10.md Add CHANGELOG-1.10.md for v1.10.0-alpha.1. 2017-12-18 13:41:16 -08:00
CHANGELOG.md
code-of-conduct.md Update code-of-conduct.md 2017-12-20 13:33:36 -05:00
CONTRIBUTING.md Pointed to community/contributors/guide/README.md 2017-12-15 22:08:34 +05:30
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES fabiano no longer a thing 2017-12-19 16:37:12 -02:00
README.md Reword double negative; link to readme 2017-12-07 20:58:47 -06:00
SUPPORT.md
Vagrantfile
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts, providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics