mirror of
				https://github.com/k3s-io/kubernetes.git
				synced 2025-10-31 05:40:42 +00:00 
			
		
		
		
	This also revealed that the regex for Context was too generous and would catch things like SecurityContext or ContextWithFoo(...) calls This ensures that test suites with a ineligible tag in their top-level Describe will be rejected from promotion to conformance
		
			
				
	
	
		
			202 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			202 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
| Copyright 2016 The Kubernetes Authors.
 | |
| 
 | |
| Licensed under the Apache License, Version 2.0 (the "License");
 | |
| you may not use this file except in compliance with the License.
 | |
| You may obtain a copy of the License at
 | |
| 
 | |
|     http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
| Unless required by applicable law or agreed to in writing, software
 | |
| distributed under the License is distributed on an "AS IS" BASIS,
 | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| See the License for the specific language governing permissions and
 | |
| limitations under the License.
 | |
| */
 | |
| 
 | |
| package main
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"reflect"
 | |
| 	"testing"
 | |
| )
 | |
| 
 | |
| var conformanceCases = []struct {
 | |
| 	filename string
 | |
| 	code     string
 | |
| 	output   []conformanceData
 | |
| }{
 | |
| 	// Go unit test
 | |
| 	{"test/list/main_test.go", `
 | |
| var num = 3
 | |
| func Helper(x int) { return x / 0 }
 | |
| var _ = Describe("Feature", func() {
 | |
| /*
 | |
|    Testname: Kubelet-OutputToLogs
 | |
|    Description: By default the stdout and stderr from the process
 | |
|    being executed in a pod MUST be sent to the pod's logs.
 | |
| */
 | |
|  framework.ConformanceIt("validates describe with ConformanceIt", func() {})
 | |
| })`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/test/list/main_test.go#L11", TestName: "Kubelet-OutputToLogs",
 | |
| 		Description: `By default the stdout and stderr from the process
 | |
| being executed in a pod MUST be sent to the pod's logs.` + "\n\n"}},
 | |
| 	},
 | |
| 	// Describe + It
 | |
| 	{"e2e/foo.go", `
 | |
| var _ = Describe("Feature", func() {
 | |
| 	//It should have comment
 | |
| 	framework.ConformanceIt("should work properly", func() {})
 | |
| })`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L5", TestName: "Feature should work properly", Description: "It should have comment\n\n"}},
 | |
| 	},
 | |
| 	// KubeDescribe + It
 | |
| 	{"e2e/foo.go", `
 | |
| var _ = framework.KubeDescribe("Feature", func() {
 | |
| 	/*It should have comment*/
 | |
| 	framework.ConformanceIt("should work properly", func() {})
 | |
| })`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L5", TestName: "Feature should work properly", Description: "It should have comment\n\n"}},
 | |
| 	},
 | |
| 	// KubeDescribe + Context + It
 | |
| 	{"e2e/foo.go", `
 | |
| var _ = framework.KubeDescribe("Feature", func() {
 | |
| 	Context("when offline", func() {
 | |
| 		//Testname: Kubelet-OutputToLogs
 | |
| 		//Description: By default the stdout and stderr from the process
 | |
| 		//being executed in a pod MUST be sent to the pod's logs.
 | |
| 		framework.ConformanceIt("should work", func() {})
 | |
| 	})
 | |
| })`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L8", TestName: "Kubelet-OutputToLogs",
 | |
| 		Description: `By default the stdout and stderr from the process
 | |
| being executed in a pod MUST be sent to the pod's logs.` + "\n\n"}},
 | |
| 	},
 | |
| 	// SIGDescribe + KubeDescribe + It, Describe + KubeDescribe + It
 | |
| 	{"e2e/foo.go", `
 | |
| var _ = framework.SIGDescribe("Feature", func() {
 | |
| 	KubeDescribe("Described by", func() {
 | |
| 		// Description: description1
 | |
| 		framework.ConformanceIt("A ConformanceIt", func() {})
 | |
| 	})
 | |
| 	Describe("Also described via", func() {
 | |
| 		KubeDescribe("A nested", func() {
 | |
| 			// Description: description2
 | |
| 			framework.ConformanceIt("ConformanceIt", func() {})
 | |
| 		})
 | |
| 	})
 | |
| })`, []conformanceData{
 | |
| 		{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L6", TestName: "Feature Described by A ConformanceIt", Description: "description1\n\n"},
 | |
| 		{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L11", TestName: "Feature Also described via A nested ConformanceIt", Description: "description2\n\n"},
 | |
| 	}},
 | |
| 	// KubeDescribe + Context + It
 | |
| 	{"e2e/foo.go", `
 | |
| var _ = framework.KubeDescribe("Feature", func() {
 | |
| 	Context("with context", func() {
 | |
| 		//Description: By default the stdout and stderr from the process
 | |
| 		//being executed in a pod MUST be sent to the pod's logs.
 | |
| 		framework.ConformanceIt("should work", func() {})
 | |
| 	})
 | |
| })`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L7", TestName: "Feature with context should work",
 | |
| 		Description: `By default the stdout and stderr from the process
 | |
| being executed in a pod MUST be sent to the pod's logs.` + "\n\n"}},
 | |
| 	},
 | |
| 	{"e2e/foo.go", `
 | |
| var _ = framework.KubeDescribe("Feature", func() {
 | |
| 	Context("with context and extra spaces before It block should still pick up Testname", func() {
 | |
| 		//					Testname: Test with spaces		
 | |
| 		//Description: Should pick up testname even if it is not within 3 spaces
 | |
| 		//even when executed from memory.
 | |
| 		framework.ConformanceIt("should work", func() {})
 | |
| 	})
 | |
| })`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L8", TestName: "Test with spaces",
 | |
| 		Description: `Should pick up testname even if it is not within 3 spaces
 | |
| even when executed from memory.` + "\n\n"}},
 | |
| 	},
 | |
| }
 | |
| 
 | |
| func TestConformance(t *testing.T) {
 | |
| 	for _, test := range conformanceCases {
 | |
| 		code := "package test\n" + test.code
 | |
| 		*confDoc = true
 | |
| 		tests := scanfile(test.filename, code)
 | |
| 		if !reflect.DeepEqual(tests, test.output) {
 | |
| 			t.Errorf("code:\n%s\ngot  %+v\nwant %+v",
 | |
| 				code, tests, test.output)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestNormalizeTestNames(t *testing.T) {
 | |
| 	testCases := []struct {
 | |
| 		rawName        string
 | |
| 		normalizedName string
 | |
| 	}{
 | |
| 		{
 | |
| 			"should have monotonically increasing restart count  [Slow]",
 | |
| 			"should have monotonically increasing restart count",
 | |
| 		},
 | |
| 		{
 | |
| 			" should check is all data is printed  ",
 | |
| 			"should check is all data is printed",
 | |
| 		},
 | |
| 	}
 | |
| 	for i, tc := range testCases {
 | |
| 		actualName := normalizeTestName(tc.rawName)
 | |
| 		if actualName != tc.normalizedName {
 | |
| 			t.Errorf("test case[%d]: expected normalized name %q, got %q", i, tc.normalizedName, actualName)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestValidateTestName(t *testing.T) {
 | |
| 	testCases := []struct {
 | |
| 		testName  string
 | |
| 		tagString string
 | |
| 	}{
 | |
| 		{
 | |
| 			"a test case with no tags",
 | |
| 			"",
 | |
| 		},
 | |
| 		{
 | |
| 			"a test case with valid tags [LinuxOnly] [NodeConformance] [Serial]",
 | |
| 			"",
 | |
| 		},
 | |
| 		{
 | |
| 			"a flaky test case that is invalid [Flaky]",
 | |
| 			"[Flaky]",
 | |
| 		},
 | |
| 		{
 | |
| 			"a disruptive test case that is invalid [Disruptive]",
 | |
| 			"[Disruptive]",
 | |
| 		},
 | |
| 		{
 | |
| 			"a feature test case that is invalid [Feature:Awesome]",
 | |
| 			"[Feature:Awesome]",
 | |
| 		},
 | |
| 		{
 | |
| 			"an alpha test case that is invalid [Alpha]",
 | |
| 			"[Alpha]",
 | |
| 		},
 | |
| 		{
 | |
| 			"a test case with multiple invalid tags [Flaky][Disruptive] [Feature:Awesome] [Alpha]",
 | |
| 			"[Flaky],[Disruptive],[Feature:Awesome],[Alpha]",
 | |
| 		},
 | |
| 		{
 | |
| 			"[sig-awesome] [Disruptive] a test case with valid and invalid tags [Alpha] [Serial] [Flaky]",
 | |
| 			"[Disruptive],[Alpha],[Flaky]",
 | |
| 		},
 | |
| 	}
 | |
| 	for i, tc := range testCases {
 | |
| 		err := validateTestName(tc.testName)
 | |
| 		if err != nil {
 | |
| 			if tc.tagString == "" {
 | |
| 				t.Errorf("test case[%d]: expected no validate error, got %q", i, err.Error())
 | |
| 			} else {
 | |
| 				expectedMsg := fmt.Sprintf("'%s' cannot have invalid tags %s", tc.testName, tc.tagString)
 | |
| 				actualMsg := err.Error()
 | |
| 				if actualMsg != expectedMsg {
 | |
| 					t.Errorf("test case[%d]: expected error message %q, got %q", i, expectedMsg, actualMsg)
 | |
| 				}
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| }
 |