Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue b265f7c682
Merge pull request #65582 from dtaniwaki/fix-test-failure-of-truncated-time
Automatic merge from submit-queue (batch tested with PRs 65582, 65480, 65310, 65644, 65645). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix test failure of truncated time

**What this PR does / why we need it**:

The test of `TestFsStoreAssignedModified` in `pkg/kubelet/kubeletconfig/checkpoint/store` fails in my environment like below.

```
$ make test WHAT=./pkg/kubelet/kubeletconfig/checkpoint/store/
Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admissionregistration.k8s.io/v1beta1,admission.k8s.io/v1beta1,apps/v1beta1,apps/v1beta2,apps/v1,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2beta1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,coordination.k8s.io/v1beta1,extensions/v1beta1,events.k8s.io/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,scheduling.k8s.io/v1beta1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,storage.k8s.io/v1alpha1,
+++ [0628 22:53:39] Running tests without code coverage
--- FAIL: TestFsStoreAssignedModified (0.00s)
        fsstore_test.go:316: expect "2018-06-28T22:53:43+09:00" but got "2018-06-28T22:53:43+09:00"
FAIL
FAIL    k8s.io/kubernetes/pkg/kubelet/kubeletconfig/checkpoint/store    0.236s
make: *** [test] Error 1
```

My environment is
OS: macOS Sierra Version 10.12.6
File System: Journaled HFS+

The error message confused me because the comparing times looked the same in the error log. If we know certain systems truncate times, I think we can just compare less precise times to avoid confusions in tests.

**Special notes for your reviewer**:
N/A

**Release note**:

```release-note
NONE
```
2018-06-29 20:14:06 -07:00
.github housekeeping: improved language used in ISSUE_TEMPLATE.md 2018-06-05 20:14:27 +10:00
api Fix comments about default mount propagation 2018-06-28 17:04:41 -04:00
build Merge pull request #65319 from MaciekPytel/gke_manifests 2018-06-29 12:15:05 -07:00
cluster Merge pull request #65586 from juju-solutions/feature/prep-1.11 2018-06-29 18:30:19 -07:00
cmd add scrape port to service 2018-06-28 13:26:11 -04:00
docs Fix comments about default mount propagation 2018-06-28 17:04:41 -04:00
Godeps revendor GCE API Go client 2018-06-26 11:29:55 -07:00
hack Merge pull request #65600 from liggitt/use-openapi-print-columns 2018-06-28 22:13:45 -07:00
logo
pkg Merge pull request #65582 from dtaniwaki/fix-test-failure-of-truncated-time 2018-06-29 20:14:06 -07:00
plugin Run hack/update-bazel.sh 2018-06-22 16:22:57 -07:00
staging Merge pull request #65390 from cfork/test 2018-06-29 18:30:16 -07:00
test Revert "Make no. of services in load test configurable" 2018-06-29 11:33:14 +02:00
third_party Update to gazelle 0.12.0 and run hack/update-bazel.sh 2018-06-22 16:22:18 -07:00
translations Merge pull request #64773 from MasayaAoyama/add-port-foward-examples 2018-06-20 14:21:14 -07:00
vendor revendor GCE API Go client 2018-06-26 11:29:55 -07:00
.bazelrc
.generated_files
.gitattributes
.gitignore
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md Typo fix: toto -> to 2018-06-12 23:12:39 +08:00
CHANGELOG-1.5.md
CHANGELOG-1.6.md
CHANGELOG-1.7.md
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.14. 2018-06-19 16:56:29 +00:00
CHANGELOG-1.9.md Update CHANGELOG-1.9.md for v1.9.9. 2018-06-29 05:49:31 +00:00
CHANGELOG-1.10.md Update CHANGELOG-1.10.md for v1.10.5. 2018-06-21 13:07:14 +00:00
CHANGELOG-1.11.md Fix K8s-Storage-Plugins repo 2018-06-28 10:36:05 +00:00
CHANGELOG.md Insert human curated 1.11 release notes and set current version 2018-06-27 19:19:19 -04:00
code-of-conduct.md
CONTRIBUTING.md
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES Merge pull request #63478 from feiskyer/milestone 2018-06-19 18:44:54 -07:00
README.md
SECURITY_CONTACTS
SUPPORT.md
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts; providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide, and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics