mirror of
				https://github.com/k3s-io/kubernetes.git
				synced 2025-11-03 23:40:03 +00:00 
			
		
		
		
	Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Supplement unit test for kubectl logs **What this PR does / why we need it**: Supplement unit test for kubectl logs **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
		
			
				
	
	
		
			202 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			202 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
Copyright 2014 The Kubernetes Authors.
 | 
						|
 | 
						|
Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
you may not use this file except in compliance with the License.
 | 
						|
You may obtain a copy of the License at
 | 
						|
 | 
						|
    http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 | 
						|
Unless required by applicable law or agreed to in writing, software
 | 
						|
distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
See the License for the specific language governing permissions and
 | 
						|
limitations under the License.
 | 
						|
*/
 | 
						|
 | 
						|
package cmd
 | 
						|
 | 
						|
import (
 | 
						|
	"bytes"
 | 
						|
	"io/ioutil"
 | 
						|
	"net/http"
 | 
						|
	"os"
 | 
						|
	"strings"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/spf13/cobra"
 | 
						|
 | 
						|
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 | 
						|
	"k8s.io/client-go/rest/fake"
 | 
						|
	api "k8s.io/kubernetes/pkg/apis/core"
 | 
						|
	cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing"
 | 
						|
)
 | 
						|
 | 
						|
func TestLog(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		name, version, podPath, logPath, container string
 | 
						|
		pod                                        *api.Pod
 | 
						|
	}{
 | 
						|
		{
 | 
						|
			name:    "v1 - pod log",
 | 
						|
			version: "v1",
 | 
						|
			podPath: "/namespaces/test/pods/foo",
 | 
						|
			logPath: "/api/v1/namespaces/test/pods/foo/log",
 | 
						|
			pod:     testPod(),
 | 
						|
		},
 | 
						|
	}
 | 
						|
	for _, test := range tests {
 | 
						|
		logContent := "test log content"
 | 
						|
		f, tf, codec, ns := cmdtesting.NewAPIFactory()
 | 
						|
		tf.Client = &fake.RESTClient{
 | 
						|
			NegotiatedSerializer: ns,
 | 
						|
			Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
 | 
						|
				switch p, m := req.URL.Path, req.Method; {
 | 
						|
				case p == test.podPath && m == "GET":
 | 
						|
					body := objBody(codec, test.pod)
 | 
						|
					return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: body}, nil
 | 
						|
				case p == test.logPath && m == "GET":
 | 
						|
					body := ioutil.NopCloser(bytes.NewBufferString(logContent))
 | 
						|
					return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: body}, nil
 | 
						|
				default:
 | 
						|
					// Ensures no GET is performed when deleting by name
 | 
						|
					t.Errorf("%s: unexpected request: %#v\n%#v", test.name, req.URL, req)
 | 
						|
					return nil, nil
 | 
						|
				}
 | 
						|
			}),
 | 
						|
		}
 | 
						|
		tf.Namespace = "test"
 | 
						|
		tf.ClientConfig = defaultClientConfig()
 | 
						|
		buf := bytes.NewBuffer([]byte{})
 | 
						|
 | 
						|
		cmd := NewCmdLogs(f, buf)
 | 
						|
		cmd.Flags().Set("namespace", "test")
 | 
						|
		cmd.Run(cmd, []string{"foo"})
 | 
						|
 | 
						|
		if buf.String() != logContent {
 | 
						|
			t.Errorf("%s: did not get expected log content. Got: %s", test.name, buf.String())
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func testPod() *api.Pod {
 | 
						|
	return &api.Pod{
 | 
						|
		ObjectMeta: metav1.ObjectMeta{Name: "foo", Namespace: "test", ResourceVersion: "10"},
 | 
						|
		Spec: api.PodSpec{
 | 
						|
			RestartPolicy: api.RestartPolicyAlways,
 | 
						|
			DNSPolicy:     api.DNSClusterFirst,
 | 
						|
			Containers: []api.Container{
 | 
						|
				{
 | 
						|
					Name: "bar",
 | 
						|
				},
 | 
						|
			},
 | 
						|
		},
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestValidateLogFlags(t *testing.T) {
 | 
						|
	f, _, _, _ := cmdtesting.NewAPIFactory()
 | 
						|
 | 
						|
	tests := []struct {
 | 
						|
		name     string
 | 
						|
		flags    map[string]string
 | 
						|
		expected string
 | 
						|
	}{
 | 
						|
		{
 | 
						|
			name:     "since & since-time",
 | 
						|
			flags:    map[string]string{"since": "1h", "since-time": "2006-01-02T15:04:05Z"},
 | 
						|
			expected: "at most one of `sinceTime` or `sinceSeconds` may be specified",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "negative since-time",
 | 
						|
			flags:    map[string]string{"since": "-1s"},
 | 
						|
			expected: "must be greater than 0",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "negative limit-bytes",
 | 
						|
			flags:    map[string]string{"limit-bytes": "-100"},
 | 
						|
			expected: "must be greater than 0",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "negative tail",
 | 
						|
			flags:    map[string]string{"tail": "-100"},
 | 
						|
			expected: "must be greater than or equal to 0",
 | 
						|
		},
 | 
						|
	}
 | 
						|
	for _, test := range tests {
 | 
						|
		cmd := NewCmdLogs(f, bytes.NewBuffer([]byte{}))
 | 
						|
		out := ""
 | 
						|
		for flag, value := range test.flags {
 | 
						|
			cmd.Flags().Set(flag, value)
 | 
						|
		}
 | 
						|
		// checkErr breaks tests in case of errors, plus we just
 | 
						|
		// need to check errors returned by the command validation
 | 
						|
		o := &LogsOptions{}
 | 
						|
		cmd.Run = func(cmd *cobra.Command, args []string) {
 | 
						|
			o.Complete(f, os.Stdout, cmd, args)
 | 
						|
			out = o.Validate().Error()
 | 
						|
		}
 | 
						|
		cmd.Run(cmd, []string{"foo"})
 | 
						|
 | 
						|
		if !strings.Contains(out, test.expected) {
 | 
						|
			t.Errorf("%s: expected to find:\n\t%s\nfound:\n\t%s\n", test.name, test.expected, out)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestLogComplete(t *testing.T) {
 | 
						|
	f, _, _, _ := cmdtesting.NewAPIFactory()
 | 
						|
 | 
						|
	tests := []struct {
 | 
						|
		name     string
 | 
						|
		args     []string
 | 
						|
		flags    map[string]string
 | 
						|
		expected string
 | 
						|
	}{
 | 
						|
		{
 | 
						|
			name:     "No args case",
 | 
						|
			flags:    map[string]string{"selector": ""},
 | 
						|
			expected: "'logs (POD | TYPE/NAME) [CONTAINER_NAME]'.\nPOD or TYPE/NAME is a required argument for the logs command",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "One args case",
 | 
						|
			args:     []string{"foo"},
 | 
						|
			flags:    map[string]string{"selector": "foo"},
 | 
						|
			expected: "only a selector (-l) or a POD name is allowed",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "Two args case",
 | 
						|
			args:     []string{"foo", "foo1"},
 | 
						|
			flags:    map[string]string{"container": "foo1"},
 | 
						|
			expected: "only one of -c or an inline [CONTAINER] arg is allowed",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "More than two args case",
 | 
						|
			args:     []string{"foo", "foo1", "foo2"},
 | 
						|
			flags:    map[string]string{"tail": "1"},
 | 
						|
			expected: "'logs (POD | TYPE/NAME) [CONTAINER_NAME]'.\nPOD or TYPE/NAME is a required argument for the logs command",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name:     "follow and selecter conflict",
 | 
						|
			flags:    map[string]string{"selector": "foo", "follow": "true"},
 | 
						|
			expected: "only one of follow (-f) or selector (-l) is allowed",
 | 
						|
		},
 | 
						|
	}
 | 
						|
	for _, test := range tests {
 | 
						|
		cmd := NewCmdLogs(f, bytes.NewBuffer([]byte{}))
 | 
						|
		var err error
 | 
						|
		out := ""
 | 
						|
		for flag, value := range test.flags {
 | 
						|
			cmd.Flags().Set(flag, value)
 | 
						|
		}
 | 
						|
		// checkErr breaks tests in case of errors, plus we just
 | 
						|
		// need to check errors returned by the command validation
 | 
						|
		o := &LogsOptions{}
 | 
						|
		err = o.Complete(f, os.Stdout, cmd, test.args)
 | 
						|
		out = err.Error()
 | 
						|
		if !strings.Contains(out, test.expected) {
 | 
						|
			t.Errorf("%s: expected to find:\n\t%s\nfound:\n\t%s\n", test.name, test.expected, out)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |