kubernetes

mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-06 07:57:35 +00:00

Files

Kubernetes Submit Queue bfdd94c6a0 Merge pull request #59170 from cofyc/fix_kubelet_volume_metrics

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix kubelet PVC stale metrics

**What this PR does / why we need it**:

Volumes on each node changes, we should not only add PVC metrics into
gauge vector. It's better use a collector to collector metrics from internal
stats.

Currently, if a PV (bound to a PVC `testpv`)  is attached and used by node A, then migrated to node B or just deleted from node A later.  `testpvc` metrics will not disappear from kubelet on node A. After a long running time, `kubelet` process will keep a lot of stale volume metrics in memory.

For these dynamic metrics, it's better to use a collector to collect metrics from a data source (`StatsProvider` here), like [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics) scraping metrics from kube-apiserver.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes https://github.com/kubernetes/kubernetes/issues/57686

**Special notes for your reviewer**:

**Release note**:

```release-note
Fix kubelet PVC stale metrics
```

2018-02-15 18:44:08 -08:00

portforward

Fix typos

2018-02-13 16:17:37 +08:00

remotecommand

fix all the typos across the project

2018-02-11 11:04:14 +08:00

stats

Fix kubelet PVC metrics using a volume stats collector.

2018-02-11 23:48:06 +08:00

streaming

Increment CRI version from v1alpha1 to v1alpha2