Files
kubernetes/test/e2e/common/node/pod_level_resources.go
Kubernetes Prow Robot cba95d3e42 Merge pull request #132601 from toVersus/test/more-pod-level-resources
[PodLevelResources] Add more comprehensive test cases to kubelet
2025-10-20 14:26:36 -07:00

474 lines
20 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/*
Copyright 2024 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package node
import (
"context"
"fmt"
"strconv"
"time"
"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
utilerrors "k8s.io/apimachinery/pkg/util/errors"
"k8s.io/kubernetes/pkg/features"
"k8s.io/kubernetes/test/e2e/common/node/framework/cgroups"
"k8s.io/kubernetes/test/e2e/feature"
"k8s.io/kubernetes/test/e2e/framework"
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
imageutils "k8s.io/kubernetes/test/utils/image"
admissionapi "k8s.io/pod-security-admission/api"
)
var (
cmd = e2epod.InfiniteSleepCommand
)
var _ = SIGDescribe("Pod Level Resources", framework.WithSerial(), feature.PodLevelResources, framework.WithFeatureGate(features.PodLevelResources), func() {
f := framework.NewDefaultFramework("pod-level-resources-tests")
f.NamespacePodSecurityLevel = admissionapi.LevelPrivileged
ginkgo.BeforeEach(func(ctx context.Context) {
_, err := e2enode.GetRandomReadySchedulableNode(ctx, f.ClientSet)
framework.ExpectNoError(err)
if framework.NodeOSDistroIs("windows") {
e2eskipper.Skipf("not supported on windows -- skipping")
}
// skip the test on nodes with cgroupv2 not enabled.
if !isCgroupv2Node(f, ctx) {
e2eskipper.Skipf("not supported on cgroupv1 -- skipping")
}
})
podLevelResourcesTests(f)
})
// isCgroupv2Node creates a small pod and check if it is running on a node
// with cgroupv2 enabled.
// TODO: refactor to mark this test with cgroupv2 label, and rather check
// the label in the test job, to tun this test on a node with cgroupv2.
func isCgroupv2Node(f *framework.Framework, ctx context.Context) bool {
podClient := e2epod.NewPodClient(f)
containerResources := cgroups.ContainerResources{CPULim: "1m", MemReq: "1Mi"}
cgroupv2Testpod := &v1.Pod{
ObjectMeta: makeObjectMetadata("cgroupv2-check", f.Namespace.Name),
Spec: v1.PodSpec{
Containers: []v1.Container{
{
Name: "cgroupv2-check",
Image: imageutils.GetE2EImage(imageutils.BusyBox),
Command: []string{"/bin/sh", "-c", cmd},
Resources: *containerResources.ResourceRequirements(),
},
},
},
}
pod := podClient.CreateSync(ctx, cgroupv2Testpod)
defer func() {
framework.Logf("Deleting %q pod", cgroupv2Testpod.Name)
delErr := e2epod.DeletePodWithWait(ctx, f.ClientSet, pod)
framework.ExpectNoError(delErr, "failed to delete pod %s", delErr)
}()
return cgroups.IsPodOnCgroupv2Node(f, pod)
}
func makeObjectMetadata(name, namespace string) metav1.ObjectMeta {
return metav1.ObjectMeta{
Name: "testpod", Namespace: namespace,
Labels: map[string]string{"time": strconv.Itoa(time.Now().Nanosecond())},
}
}
type containerInfo struct {
Name string
Resources *cgroups.ContainerResources
}
func makePod(metadata *metav1.ObjectMeta, podResources *cgroups.ContainerResources, containers []containerInfo) *v1.Pod {
var testContainers []v1.Container
for _, container := range containers {
c := cgroups.MakeContainerWithResources(container.Name, container.Resources, cmd)
testContainers = append(testContainers, c)
}
pod := &v1.Pod{
ObjectMeta: *metadata,
Spec: v1.PodSpec{
Containers: testContainers,
},
}
cgroups.ConfigureHostPathForPodCgroup(pod)
if podResources != nil {
res := podResources.ResourceRequirements()
pod.Spec.Resources = res
}
return pod
}
func verifyPodResources(gotPod v1.Pod, inputInfo, expectedInfo *cgroups.ContainerResources) {
ginkgo.GinkgoHelper()
var expectedResources *v1.ResourceRequirements
// expectedResources will be nil if pod-level resources are not set in the test
// case input.
if inputInfo != nil {
expectedResources = expectedInfo.ResourceRequirements()
}
gomega.Expect(expectedResources).To(gomega.Equal(gotPod.Spec.Resources))
}
func verifyQoS(gotPod v1.Pod, expectedQoS v1.PodQOSClass) {
ginkgo.GinkgoHelper()
gomega.Expect(expectedQoS).To(gomega.Equal(gotPod.Status.QOSClass))
}
func podLevelResourcesTests(f *framework.Framework) {
type expectedPodConfig struct {
qos v1.PodQOSClass
// totalPodResources represents the aggregate resource requests
// and limits for the pod. If pod-level resource specifications
// are specified, totalPodResources is equal to pod-level resources.
// Otherwise, it is calculated by aggregating resource requests and
// limits from all containers within the pod.
totalPodResources *cgroups.ContainerResources
}
type testCase struct {
name string
podResources *cgroups.ContainerResources
containers []containerInfo
expected expectedPodConfig
// If expectedPodLevelResourcesOverride is not specified,
// we check the PodSpec to verify whether the API server correctly injected default values
// by comparing it with expected.totalPodResources. In most cases, this comparison works fine.
// However, if pod-level limits are not specified and all containers have their limits set,
// the cgroup for the pod will be configured with the aggregated container-level limits.
// Still, the pod-level limits field itself will not have default values set.
// To cover this pattern, we allow overriding the values when comparing against the PodSpec.
expectedPodLevelResourcesOverride *cgroups.ContainerResources
}
tests := []testCase{
{
name: "Guaranteed QoS pod with only container resources",
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "50m", MemReq: "70Mi", MemLim: "70Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "70m", CPULim: "70m", MemReq: "50Mi", MemLim: "50Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSGuaranteed,
totalPodResources: &cgroups.ContainerResources{CPUReq: "120m", CPULim: "120m", MemReq: "120Mi", MemLim: "120Mi"},
},
},
{
name: "Guaranteed QoS pod, no container resources",
podResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
containers: []containerInfo{{Name: "c1"}, {Name: "c2"}},
expected: expectedPodConfig{
qos: v1.PodQOSGuaranteed,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
},
},
{
name: "Guaranteed QoS pod with other container resources",
podResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSGuaranteed,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
},
},
{
name: "Guaranteed QoS pod, 1 container with resources",
podResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"}},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSGuaranteed,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
},
},
{
name: "Guaranteed QoS pod, pod resources limits, no container resources",
podResources: &cgroups.ContainerResources{CPULim: "100m", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1"},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSGuaranteed,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources limits, container resources limits",
podResources: &cgroups.ContainerResources{CPULim: "100m", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPULim: "50m", MemLim: "50Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPULim: "30m", MemLim: "30Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "80m", CPULim: "100m", MemReq: "80Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources limits, container resources requests",
podResources: &cgroups.ContainerResources{CPULim: "100m", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", MemReq: "50Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "30m", MemReq: "30Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "80m", CPULim: "100m", MemReq: "80Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources requests, no container resources",
podResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
containers: []containerInfo{{Name: "c1"}, {Name: "c2"}},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources requests, container resources requests",
podResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", MemReq: "50Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "30m", MemReq: "30Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources requests, container resources requests and partial limits",
podResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "50m", MemReq: "50Mi", MemLim: "50Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "30m", MemReq: "30Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources requests, container resources limits",
podResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPULim: "50m", MemLim: "50Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPULim: "50m", MemLim: "50Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"},
},
expectedPodLevelResourcesOverride: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
{
name: "Burstable QoS pod, pod resources requests, partial container resources limits",
podResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPULim: "50m", MemLim: "50Mi"}},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
// If container-level limits are not specified for all containers,
// cpu.max and memory.max will not be set.
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
expectedPodLevelResourcesOverride: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
{
name: "Burstable QoS pod, pod resources requests, container resources requests and limits",
podResources: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "30m", CPULim: "30m", MemReq: "30Mi", MemLim: "30Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "30m", CPULim: "30m", MemReq: "30Mi", MemLim: "30Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
// At first glance, this may seem invalid. However, the value of CPUReq is only used
// to calculate the ratio for cpu.weight (i.e., CPU shares), and the absolute value
// of CPUReq is not directly applied. Therefore, its not a problem even if CPUReq
// exceeds CPULim. Similarly, when the MemoryQoS feature is disabled, MemReq is not
// used for memory.min, so its also fine for MemReq to exceed MemLim.
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "60m", MemReq: "100Mi", MemLim: "60Mi"},
},
expectedPodLevelResourcesOverride: &cgroups.ContainerResources{CPUReq: "100m", MemReq: "100Mi"},
},
{
name: "Burstable QoS pod, no container resources",
podResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1"},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod with yet some other container resources",
podResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "20m", CPULim: "100m", MemReq: "20Mi", MemLim: "100Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPUReq: "30m", CPULim: "100m", MemReq: "30Mi", MemLim: "100Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, 1 container with resources",
podResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "20m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"}},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources requests and limits, container resources limits",
podResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPULim: "30m", MemLim: "30Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{CPULim: "20m", MemLim: "20Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, pod resources requests and limits, container resources requests",
podResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "50m", MemReq: "30Mi"}},
{Name: "c2", Resources: &cgroups.ContainerResources{MemReq: "20Mi"}},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "50m", CPULim: "100m", MemReq: "50Mi", MemLim: "100Mi"},
},
},
{
name: "Burstable QoS pod, partial requests in pod level resources, 1 container with guaranteed resources",
podResources: &cgroups.ContainerResources{CPUReq: "", CPULim: "200m", MemReq: "200Mi", MemLim: "200Mi"},
containers: []containerInfo{
{Name: "c1", Resources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "100m", MemReq: "100Mi", MemLim: "100Mi"}},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSBurstable,
totalPodResources: &cgroups.ContainerResources{CPUReq: "100m", CPULim: "200m", MemReq: "200Mi", MemLim: "200Mi"},
},
},
{
name: "BestEffort QoS no pod resources, no container resources",
containers: []containerInfo{
{Name: "c1"},
{Name: "c2"},
},
expected: expectedPodConfig{
qos: v1.PodQOSBestEffort,
totalPodResources: &cgroups.ContainerResources{CPUReq: "", CPULim: "", MemReq: "", MemLim: ""},
},
},
}
for _, tc := range tests {
ginkgo.It(tc.name, func(ctx context.Context) {
podMetadata := makeObjectMetadata("testpod", f.Namespace.Name)
testPod := makePod(&podMetadata, tc.podResources, tc.containers)
ginkgo.By("creating pods")
podClient := e2epod.NewPodClient(f)
pod := podClient.CreateSync(ctx, testPod)
ginkgo.By("verifying pod resources are as expected")
expectedPodResources := tc.expected.totalPodResources
if tc.expectedPodLevelResourcesOverride != nil {
expectedPodResources = tc.expectedPodLevelResourcesOverride
}
verifyPodResources(*pod, tc.podResources, expectedPodResources)
ginkgo.By("verifying pod QoS as expected")
verifyQoS(*pod, tc.expected.qos)
ginkgo.By("verifying pod cgroup values")
err := cgroups.VerifyPodCgroups(ctx, f, pod, tc.expected.totalPodResources)
framework.ExpectNoError(err, "failed to verify pod's cgroup values: %v", err)
ginkgo.By("verifying containers cgroup limits are same as pod container's cgroup limits")
err = verifyContainersCgroupLimits(f, pod)
framework.ExpectNoError(err, "failed to verify containers cgroup values: %v", err)
ginkgo.By("deleting pods")
delErr := e2epod.DeletePodWithWait(ctx, f.ClientSet, pod)
framework.ExpectNoError(delErr, "failed to delete pod %s", delErr)
})
}
}
func verifyContainersCgroupLimits(f *framework.Framework, pod *v1.Pod) error {
var errs []error
for _, container := range pod.Spec.Containers {
if pod.Spec.Resources != nil && pod.Spec.Resources.Limits.Memory() != nil &&
container.Resources.Limits.Memory() == nil {
err := cgroups.VerifyContainerMemoryLimit(f, pod, container.Name, &container.Resources, true)
if err != nil {
errs = append(errs, fmt.Errorf("failed to verify memory limit cgroup value: %w", err))
}
}
if pod.Spec.Resources != nil && pod.Spec.Resources.Limits.Cpu() != nil &&
container.Resources.Limits.Cpu() == nil {
err := cgroups.VerifyContainerCPULimit(f, pod, container.Name, &container.Resources, true)
if err != nil {
errs = append(errs, fmt.Errorf("failed to verify cpu limit cgroup value: %w", err))
}
}
}
return utilerrors.NewAggregate(errs)
}