Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue d8680a3c43
Merge pull request #57549 from andyzhangx/azurediskid-fix
Automatic merge from submit-queue (batch tested with PRs 56382, 57549). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix azure disk not available issue when device name changed

**What this PR does / why we need it**:
There is possibility that device name(`/dev/sd*`) would change when attach/detach data disk in Azure VM according to  [Troubleshoot Linux VM device name change](https://docs.microsoft.com/en-us/azure/virtual-machines/linux/troubleshoot-device-names-problems). 
And We did hit this issue, see customer [case](https://github.com/Azure/acs-engine/issues/1918). 
This PR would use `/dev/disk/by-id` instead of `/dev/sd*` for azure disk and `/dev/disk/by-id` would not change even device name changed.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #57444

**Special notes for your reviewer**:
In a customer [case](https://github.com/Azure/acs-engine/issues/1918), customer is unable to use azure disk in StatefulSet since /dev/sd* changed after detach/attach disk. 
we are using `/dev/sd*`(code is [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/azure_dd/azure_common_linux.go#L140)) to "mount -bind" k8s path, while `/dev/sd*` could be changed when VM is attach/detaching data disks, see [Troubleshoot Linux VM device name change](https://docs.microsoft.com/en-us/azure/virtual-machines/linux/troubleshoot-device-names-problems)
And I have also checked related AWS, GCE code, they are using `/dev/disk/by-id/` other than `/dev/sd*`, see [aws code](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/aws_ebs/aws_util.go#L228)  
[gce code](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/gce_pd/gce_util.go#L278)

**Release note**:

```
fix azure disk not available when device name changed
```
/sig azure
/assign @rootfs 
@karataliu @brendandburns @khenidak
2018-01-04 06:40:34 -08:00
.github
api Generate specs after fixing typo in documentation. 2018-01-02 17:59:53 +00:00
build Bump rules_go to 0.8.1 2017-12-23 13:12:02 -08:00
cluster Remove comments in get-kube.sh that imply support for environments 2018-01-03 22:07:32 -08:00
cmd Merge pull request #56615 from hzxuzhonghu/validate-admission-control 2018-01-04 02:02:31 -08:00
docs Run update-api-reference-docs.sh. 2018-01-03 00:18:03 +00:00
examples Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
Godeps Run godep-save.sh and update-staging-godeps.sh 2018-01-02 22:00:44 -08:00
hack Merge pull request #57805 from liggitt/test-grep-pipe-fix 2018-01-03 15:40:43 -08:00
logo
pkg Merge pull request #57549 from andyzhangx/azurediskid-fix 2018-01-04 06:40:34 -08:00
plugin Merge pull request #56317 from guangxuli/refactor_priority_CalculateAntiAffinityPriority 2018-01-04 03:22:42 -08:00
staging Merge pull request #57821 from hzxuzhonghu/hard-code 2018-01-04 03:22:39 -08:00
test Merge pull request #56382 from mikkeloscar/e2e-psp-and-rbac 2018-01-04 06:40:31 -08:00
third_party Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
translations
vendor Run godep-save.sh and update-staging-godeps.sh 2018-01-02 22:00:44 -08:00
.bazelrc
.generated_files
.gitattributes
.gitignore
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
CHANGELOG-1.5.md Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
CHANGELOG-1.6.md Revert k8s.gcr.io vanity domain 2017-12-22 14:36:16 -08:00
CHANGELOG-1.7.md Update CHANGELOG-1.7.md for v1.7.12. 2017-12-29 13:42:49 +01:00
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.6. 2017-12-21 09:50:30 -08:00
CHANGELOG-1.9.md
CHANGELOG-1.10.md
CHANGELOG.md
code-of-conduct.md Update code-of-conduct.md 2017-12-20 13:33:36 -05:00
CONTRIBUTING.md
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES fabiano no longer a thing 2017-12-19 16:37:12 -02:00
README.md
SUPPORT.md
Vagrantfile
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts, providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics