Kubernetes Submit Queue 0a284c1cde Merge pull request #66082 from sjenning/fix-is-critical-checks ...

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

move feature gate checks inside IsCriticalPod

Currently `IsCriticalPod()` calls throughout the code are protected by `utilfeature.DefaultFeatureGate.Enabled(features.ExperimentalCriticalPodAnnotation)`.

However, with Pod Priority, this gate could be disabled which skips the priority check inside IsCriticalPod().

This PR moves the feature gate checking inside `IsCriticalPod()` and handles both situations properly.

@aveshagarwal @ravisantoshgudimetla @derekwaynecarr 
/sig node
/sig scheduling
/king bug

2018-08-01 11:47:08 -07:00

..

util

Run hack/update-bazel.sh

2018-06-22 16:22:57 -07:00

BUILD

Safe encode template hash value to make it consistent with resource name

2018-07-13 09:52:26 -07:00

daemon_controller_test.go

Safe encode template hash value to make it consistent with resource name

2018-07-13 09:52:26 -07:00

daemon_controller.go

move feature gate checks inside IsCriticalPod

2018-07-11 16:10:05 -05:00

doc.go

…

OWNERS

…

update_test.go

Update the DaemonSet controller to use the apps/v1 API

2018-02-22 11:38:54 -08:00

update.go

Safe encode template hash value to make it consistent with resource name

2018-07-13 09:52:26 -07:00