mirror of
				https://github.com/k3s-io/kubernetes.git
				synced 2025-11-04 07:49:35 +00:00 
			
		
		
		
	
		
			
				
	
	
		
			110 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			110 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
Copyright 2018 The Kubernetes Authors.
 | 
						|
 | 
						|
Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
you may not use this file except in compliance with the License.
 | 
						|
You may obtain a copy of the License at
 | 
						|
 | 
						|
    http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 | 
						|
Unless required by applicable law or agreed to in writing, software
 | 
						|
distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
See the License for the specific language governing permissions and
 | 
						|
limitations under the License.
 | 
						|
*/
 | 
						|
 | 
						|
package persistentvolume
 | 
						|
 | 
						|
import (
 | 
						|
	"reflect"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"k8s.io/apimachinery/pkg/util/diff"
 | 
						|
	utilfeature "k8s.io/apiserver/pkg/util/feature"
 | 
						|
	featuregatetesting "k8s.io/component-base/featuregate/testing"
 | 
						|
	api "k8s.io/kubernetes/pkg/apis/core"
 | 
						|
	"k8s.io/kubernetes/pkg/features"
 | 
						|
)
 | 
						|
 | 
						|
func TestDropDisabledFields(t *testing.T) {
 | 
						|
	secretRef := &api.SecretReference{
 | 
						|
		Name:      "expansion-secret",
 | 
						|
		Namespace: "default",
 | 
						|
	}
 | 
						|
 | 
						|
	tests := map[string]struct {
 | 
						|
		oldSpec             *api.PersistentVolumeSpec
 | 
						|
		newSpec             *api.PersistentVolumeSpec
 | 
						|
		expectOldSpec       *api.PersistentVolumeSpec
 | 
						|
		expectNewSpec       *api.PersistentVolumeSpec
 | 
						|
		csiExpansionEnabled bool
 | 
						|
	}{
 | 
						|
		"disabled csi expansion clears secrets": {
 | 
						|
			csiExpansionEnabled: false,
 | 
						|
			newSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectNewSpec:       specWithCSISecrets(nil),
 | 
						|
			oldSpec:             nil,
 | 
						|
			expectOldSpec:       nil,
 | 
						|
		},
 | 
						|
		"enabled csi expansion preserve secrets": {
 | 
						|
			csiExpansionEnabled: true,
 | 
						|
			newSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectNewSpec:       specWithCSISecrets(secretRef),
 | 
						|
			oldSpec:             nil,
 | 
						|
			expectOldSpec:       nil,
 | 
						|
		},
 | 
						|
		"enabled csi expansion preserve secrets when both old and new have it": {
 | 
						|
			csiExpansionEnabled: true,
 | 
						|
			newSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectNewSpec:       specWithCSISecrets(secretRef),
 | 
						|
			oldSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectOldSpec:       specWithCSISecrets(secretRef),
 | 
						|
		},
 | 
						|
		"disabled csi expansion old pv had secrets": {
 | 
						|
			csiExpansionEnabled: false,
 | 
						|
			newSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectNewSpec:       specWithCSISecrets(secretRef),
 | 
						|
			oldSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectOldSpec:       specWithCSISecrets(secretRef),
 | 
						|
		},
 | 
						|
		"enabled csi expansion preserves secrets when old pv did not had secrets": {
 | 
						|
			csiExpansionEnabled: true,
 | 
						|
			newSpec:             specWithCSISecrets(secretRef),
 | 
						|
			expectNewSpec:       specWithCSISecrets(secretRef),
 | 
						|
			oldSpec:             specWithCSISecrets(nil),
 | 
						|
			expectOldSpec:       specWithCSISecrets(nil),
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	for name, tc := range tests {
 | 
						|
		t.Run(name, func(t *testing.T) {
 | 
						|
			defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ExpandCSIVolumes, tc.csiExpansionEnabled)()
 | 
						|
 | 
						|
			DropDisabledFields(tc.newSpec, tc.oldSpec)
 | 
						|
			if !reflect.DeepEqual(tc.newSpec, tc.expectNewSpec) {
 | 
						|
				t.Error(diff.ObjectReflectDiff(tc.newSpec, tc.expectNewSpec))
 | 
						|
			}
 | 
						|
			if !reflect.DeepEqual(tc.oldSpec, tc.expectOldSpec) {
 | 
						|
				t.Error(diff.ObjectReflectDiff(tc.oldSpec, tc.expectOldSpec))
 | 
						|
			}
 | 
						|
		})
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func specWithCSISecrets(secret *api.SecretReference) *api.PersistentVolumeSpec {
 | 
						|
	pvSpec := &api.PersistentVolumeSpec{
 | 
						|
		PersistentVolumeSource: api.PersistentVolumeSource{
 | 
						|
			CSI: &api.CSIPersistentVolumeSource{
 | 
						|
				Driver:       "com.google.gcepd",
 | 
						|
				VolumeHandle: "foobar",
 | 
						|
			},
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	if secret != nil {
 | 
						|
		pvSpec.CSI.ControllerExpandSecretRef = secret
 | 
						|
	}
 | 
						|
	return pvSpec
 | 
						|
}
 |