Changed sync tappers to start only when sync tappers config is true (#562)

agent/main.go

@@ -131,6 +131,10 @@ func main() {
 			}
 		}
 
+		if config.Config.SyncTappers {
+			startSyncingTappers()
+		}
+
 		hostApi(outputItemsChannel)
 	} else if *harsReaderMode {
 		outputItemsChannel := make(chan *tapApi.OutputChannelItem, 1000)
@@ -260,20 +264,6 @@ func hostApi(socketHarOutputChannel chan<- *tapApi.OutputChannelItem) {
 	routes.StatusRoutes(app)
 	routes.NotFoundRoute(app)
 
-	if config.Config.DaemonMode {
-		ctx, cancel := context.WithCancel(context.Background())
-		defer cancel()
-
-		kubernetesProvider, err := kubernetes.NewProviderInCluster()
-		if err != nil {
-			logger.Log.Fatalf("error creating k8s provider: %+v", err)
-		}
-
-		if _, err := startMizuTapperSyncer(ctx, kubernetesProvider); err != nil {
-			logger.Log.Fatalf("error initializing tapper syncer: %+v", err)
-		}
-	}
-
 	utils.StartServer(app)
 }
 
@@ -461,6 +451,20 @@ func handleIncomingMessageAsTapper(socketConnection *websocket.Conn) {
 	}
 }
 
+func startSyncingTappers() {
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+
+	kubernetesProvider, err := kubernetes.NewProviderInCluster()
+	if err != nil {
+		logger.Log.Fatalf("error creating k8s provider: %+v", err)
+	}
+
+	if _, err := startMizuTapperSyncer(ctx, kubernetesProvider); err != nil {
+		logger.Log.Fatalf("error initializing tapper syncer: %+v", err)
+	}
+}
+
 func startMizuTapperSyncer(ctx context.Context, provider *kubernetes.Provider) (*kubernetes.MizuTapperSyncer, error) {
 	tapperSyncer, err := kubernetes.CreateAndStartMizuTapperSyncer(ctx, provider, kubernetes.TapperSyncerConfig{
 		TargetNamespaces:         config.Config.TargetNamespaces,

agent/pkg/config/config.go

@@ -56,6 +56,6 @@ func getDefaultConfig() (*shared.MizuAgentConfig, error) {
 		TapTargetRegex:    *regex,
 		MaxDBSizeBytes:    defaultMaxDatabaseSizeBytes,
 		AgentDatabasePath: DefaultDatabasePath,
-		DaemonMode:        false,
+		SyncTappers:       false,
 	}, nil
 }

agent/pkg/controllers/status_controller.go

@@ -17,7 +17,7 @@ import (
 )
 
 func HealthCheck(c *gin.Context) {
-	if config.Config.DaemonMode {
+	if config.Config.SyncTappers {
 		if providers.ExpectedTapperAmount != providers.TappersCount {
 			c.JSON(http.StatusInternalServerError, fmt.Sprintf("expecting more tappers than are actually connected (%d expected, %d connected)", providers.ExpectedTapperAmount, providers.TappersCount))
 			return