From 318247ea73bc7189034bf266ff166cd516b0bbb8 Mon Sep 17 00:00:00 2001 From: Roee Gadot Date: Thu, 29 Apr 2021 10:16:57 +0300 Subject: [PATCH] no message --- cli/README.md | 2 +- cli/cmd/root.go | 2 +- tap/src/tcp_stream_factory.go | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cli/README.md b/cli/README.md index 01dd24ba7..f88b6f0ab 100644 --- a/cli/README.md +++ b/cli/README.md @@ -7,7 +7,7 @@ | flag | default | purpose | |----------------------|------------------|--------------------------------------------------------------------------------------------------------------| | `--no-dashboard` | `false` | Don't host the dashboard (not applicable at the moment) | -| `--dashboard-port` | `3000` | local port that dashboard will be forwarded to | +| `--dashboard-port` | `8899` | local port that dashboard will be forwarded to | | `--namespace` | | use namespace different than the one found in kubeconfig | | `--kubeconfig` | | Path to custom kubeconfig file | diff --git a/cli/cmd/root.go b/cli/cmd/root.go index ae192e4d6..fdcd29b44 100644 --- a/cli/cmd/root.go +++ b/cli/cmd/root.go @@ -32,7 +32,7 @@ func init() { rootCmd.Flags().BoolVarP(&config.Configuration.DisplayVersion, "version", "v", false, "Print the version and exit") rootCmd.Flags().BoolVarP(&config.Configuration.Quiet, "quiet", "q", false, "No stdout output") rootCmd.Flags().BoolVarP(&config.Configuration.NoDashboard, "no-dashboard", "", false, "Dont host a dashboard") - rootCmd.Flags().Uint16VarP(&config.Configuration.DashboardPort, "dashboard-port", "p", 3000, "Provide a custom port for the dashboard webserver") + rootCmd.Flags().Uint16VarP(&config.Configuration.DashboardPort, "dashboard-port", "p", 8899, "Provide a custom port for the dashboard webserver") rootCmd.Flags().StringVarP(&config.Configuration.Namespace, "namespace", "n", "", "Namespace selector") rootCmd.Flags().BoolVarP(&config.Configuration.AllNamespaces, "all-namespaces", "A", false, "Select all namespaces") rootCmd.Flags().StringVarP(&config.Configuration.KubeConfigPath, "kubeconfig", "k", "", "Path to kubeconfig file") diff --git a/tap/src/tcp_stream_factory.go b/tap/src/tcp_stream_factory.go index bf69f2622..fc510a8cc 100644 --- a/tap/src/tcp_stream_factory.go +++ b/tap/src/tcp_stream_factory.go @@ -84,6 +84,8 @@ func (factory *tcpStreamFactory) WaitGoRoutines() { } func (factory *tcpStreamFactory) shouldTap(dstIP string, dstPort int) bool { + return true // TODO: this is only for checking it now + if hostMode { return inArrayString(hostAppAddresses, fmt.Sprintf("%s:%d", dstIP, dstPort)) } else {