From 7dcacf14f23e625d606d0d17ec7c9668d9b729df Mon Sep 17 00:00:00 2001 From: Alon Girmonsky <1990761+alongir@users.noreply.github.com> Date: Fri, 3 Oct 2025 07:26:50 -0700 Subject: [PATCH] Removed the !error && !dns and disabled support chat option by default (#1792) * removed the !error && !dns * removed the default "!dns && !error" * changed support option to false --- config/configStruct.go | 2 +- config/configStructs/tapConfig.go | 2 +- helm-chart/README.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/configStruct.go b/config/configStruct.go index 6092173fc..0f8d9a5fd 100644 --- a/config/configStruct.go +++ b/config/configStruct.go @@ -178,7 +178,7 @@ type ConfigStruct struct { CloudLicenseEnabled bool `yaml:"cloudLicenseEnabled" json:"cloudLicenseEnabled" default:"true"` AiAssistantEnabled bool `yaml:"aiAssistantEnabled" json:"aiAssistantEnabled" default:"true"` DemoModeEnabled bool `yaml:"demoModeEnabled" json:"demoModeEnabled" default:"false"` - SupportChatEnabled bool `yaml:"supportChatEnabled" json:"supportChatEnabled" default:"true"` + SupportChatEnabled bool `yaml:"supportChatEnabled" json:"supportChatEnabled" default:"false"` BetaEnabled bool `yaml:"betaEnabled" json:"betaEnabled" default:"false"` InternetConnectivity bool `yaml:"internetConnectivity" json:"internetConnectivity" default:"true"` Scripting configStructs.ScriptingConfig `yaml:"scripting" json:"scripting"` diff --git a/config/configStructs/tapConfig.go b/config/configStructs/tapConfig.go index 0c701fc61..a872c370c 100644 --- a/config/configStructs/tapConfig.go +++ b/config/configStructs/tapConfig.go @@ -352,7 +352,7 @@ type TapConfig struct { Watchdog WatchdogConfig `yaml:"watchdog" json:"watchdog"` Gitops GitopsConfig `yaml:"gitops" json:"gitops"` Sentry SentryConfig `yaml:"sentry" json:"sentry"` - DefaultFilter string `yaml:"defaultFilter" json:"defaultFilter" default:"!dns and !error"` + DefaultFilter string `yaml:"defaultFilter" json:"defaultFilter" default:""` LiveConfigMapChangesDisabled bool `yaml:"liveConfigMapChangesDisabled" json:"liveConfigMapChangesDisabled" default:"false"` GlobalFilter string `yaml:"globalFilter" json:"globalFilter" default:""` EnabledDissectors []string `yaml:"enabledDissectors" json:"enabledDissectors"` diff --git a/helm-chart/README.md b/helm-chart/README.md index 29dcf97b8..5d8d4a196 100644 --- a/helm-chart/README.md +++ b/helm-chart/README.md @@ -210,7 +210,7 @@ Example for overriding image names: | `tap.secrets` | List of secrets to be used as source for environment variables (e.g. `kubeshark-license`) | `[]` | | `tap.sentry.enabled` | Enable sending of error logs to Sentry | `true` (only for qualified users) | | `tap.sentry.environment` | Sentry environment to label error logs with | `production` | -| `tap.defaultFilter` | Sets the default dashboard KFL filter (e.g. `http`). By default, this value is set to filter out noisy protocols such as DNS, UDP, ICMP and TCP. The user can easily change this, **temporarily**, in the Dashboard. For a permanent change, you should change this value in the `values.yaml` or `config.yaml` file. | `"!dns and !error"` | +| `tap.defaultFilter` | Sets the default dashboard KFL filter (e.g. `http`). By default, this value is set to filter out noisy protocols such as DNS, UDP, ICMP and TCP. The user can easily change this, **temporarily**, in the Dashboard. For a permanent change, you should change this value in the `values.yaml` or `config.yaml` file. | `""` | | `tap.liveConfigMapChangesDisabled` | If set to `true`, all user functionality (scripting, targeting settings, global & default KFL modification, traffic recording, traffic capturing on/off, protocol dissectors) involving dynamic ConfigMap changes from UI will be disabled | `false` | | `tap.globalFilter` | Prepends to any KFL filter and can be used to limit what is visible in the dashboard. For example, `redact("request.headers.Authorization")` will redact the appropriate field. Another example `!dns` will not show any DNS traffic. | `""` | | `tap.metrics.port` | Pod port used to expose Prometheus metrics | `49100` |