github/kubeshark
1
0
Fork 0
mirror of https://github.com/kubeshark/kubeshark.git synced 2025-09-20 01:32:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

TRA-3311 validate xml before parsing

Browse Source 
TRA-3311 validate xml before parsing
This commit is contained in:
RamiBerm
2021-06-07 11:43:04 +03:00
committed by GitHub
parent ba7b97cf7b b7d3ff6eb8
commit 8b4d813bd8
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
api/pkg/sensitiveDataFiltering/messageSensitiveDataCleaner.go
View File

@@ -2,6 +2,8 @@ package sensitiveDataFiltering
import ( import (
"encoding/json" "encoding/json"
"encoding/xml"
"errors"
"fmt" "fmt"
"mizuserver/pkg/tap" "mizuserver/pkg/tap"
"net/url" "net/url"
@@ -103,6 +105,9 @@ func filterPlainText(bytes []byte, options *shared.TrafficFilteringOptions) []by
} }
func filterXmlEtree(bytes []byte) ([]byte, error) { func filterXmlEtree(bytes []byte) ([]byte, error) {
if !IsValidXML(bytes) {
return nil, errors.New("Invalid XML")
}
xmlDoc := etree.NewDocument() xmlDoc := etree.NewDocument()
err := xmlDoc.ReadFromBytes(bytes) err := xmlDoc.ReadFromBytes(bytes)
if err != nil { if err != nil {
@@ -113,6 +118,10 @@ func filterXmlEtree(bytes []byte) ([]byte, error) {
return xmlDoc.WriteToBytes() return xmlDoc.WriteToBytes()
} }
func IsValidXML(data []byte) bool {
return xml.Unmarshal(data, new(interface{})) == nil
}
func filterXmlElement(element *etree.Element) { func filterXmlElement(element *etree.Element) {
for i, attribute := range element.Attr { for i, attribute := range element.Attr {
if isFieldNameSensitive(attribute.Key) { if isFieldNameSensitive(attribute.Key) {