From 9144d98d04766bd7065511de84abb17aa8d58545 Mon Sep 17 00:00:00 2001 From: "M. Mert Yildiran" Date: Wed, 25 Sep 2024 21:29:21 +0300 Subject: [PATCH] Add `udp` to list of enabled dissectors (#1616) * Add `udp` to list of enabled dissectors * ignore udp as part of a global filter * have globalFilter ignore udp and icmp * Have globalFilter ignore udp and icmp * Update README.md --------- Co-authored-by: Alon Girmonsky <1990761+alongir@users.noreply.github.com> --- config/configStruct.go | 1 + config/configStructs/tapConfig.go | 2 +- helm-chart/README.md | 2 +- helm-chart/values.yaml | 1 + manifests/complete.yaml | 4 ++-- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/config/configStruct.go b/config/configStruct.go index c63c909be..e9f79dd6a 100644 --- a/config/configStruct.go +++ b/config/configStruct.go @@ -83,6 +83,7 @@ func CreateDefaultConfig() ConfigStruct { "sctp", "syscall", "tcp", + "udp", "ws", }, }, diff --git a/config/configStructs/tapConfig.go b/config/configStructs/tapConfig.go index 218946ea0..d4a0b1252 100644 --- a/config/configStructs/tapConfig.go +++ b/config/configStructs/tapConfig.go @@ -216,7 +216,7 @@ type TapConfig struct { KernelModule KernelModuleConfig `yaml:"kernelModule" json:"kernelModule"` Telemetry TelemetryConfig `yaml:"telemetry" json:"telemetry"` Sentry SentryConfig `yaml:"sentry" json:"sentry"` - DefaultFilter string `yaml:"defaultFilter" json:"defaultFilter" default:"!dns and !tcp"` + DefaultFilter string `yaml:"defaultFilter" json:"defaultFilter" default:"!dns and !tcp and !udp and !icmp"` ScriptingDisabled bool `yaml:"scriptingDisabled" json:"scriptingDisabled" default:"false"` TargetedPodsUpdateDisabled bool `yaml:"targetedPodsUpdateDisabled" json:"targetedPodsUpdateDisabled" default:"false"` RecordingDisabled bool `yaml:"recordingDisabled" json:"recordingDisabled" default:"false"` diff --git a/helm-chart/README.md b/helm-chart/README.md index 184c34e25..be5dfe04e 100644 --- a/helm-chart/README.md +++ b/helm-chart/README.md @@ -174,7 +174,7 @@ Please refer to [metrics](./metrics.md) documentation for details. | `tap.telemetry.enabled` | Enable anonymous usage statistics collection | `true` | | `tap.sentry.enabled` | Enable sending of error logs to Sentry | `false` | | `tap.sentry.environment` | Sentry environment to label error logs with | `production` | -| `tap.defaultFilter` | Sets the default dashboard KFL filter (e.g. `http`). By default, this value is set to filter out DNS and TCP entries. The user can easily change this in the Dashboard. | `"!dns and !tcp"` | +| `tap.defaultFilter` | Sets the default dashboard KFL filter (e.g. `http`). By default, this value is set to filter out noisy protocols such as DNS, UDP, ICMP and TCP. The user can easily change this in the Dashboard. You can also change this value to change this behavior. | `"!dns and !tcp and !udp and !icmp"` | | `tap.globalFilter` | Prepends to any KFL filter and can be used to limit what is visible in the dashboard. For example, `redact("request.headers.Authorization")` will redact the appropriate field. Another example `!dns` will not show any DNS traffic. | `""` | | `tap.metrics.port` | Pod port used to expose Prometheus metrics | `49100` | | `tap.enabledDissectors` | This is an array of strings representing the list of supported protocols. Remove or comment out redundant protocols (e.g., dns).| The default list includes: amqp, dns , http, icmp, kafka, redis,sctp, syscall, tcp, ws. | diff --git a/helm-chart/values.yaml b/helm-chart/values.yaml index ac3bc3cd7..8c9b581e8 100644 --- a/helm-chart/values.yaml +++ b/helm-chart/values.yaml @@ -132,6 +132,7 @@ tap: - sctp - syscall - tcp + - udp - ws metrics: port: 49100 diff --git a/manifests/complete.yaml b/manifests/complete.yaml index 0f8521cc4..8cb576bc1 100644 --- a/manifests/complete.yaml +++ b/manifests/complete.yaml @@ -249,7 +249,7 @@ data: TIMEZONE: ' ' CLOUD_LICENSE_ENABLED: 'true' DUPLICATE_TIMEFRAME: '200ms' - ENABLED_DISSECTORS: 'amqp,dns,http,icmp,kafka,redis,sctp,syscall,tcp,ws' + ENABLED_DISSECTORS: 'amqp,dns,http,icmp,kafka,redis,sctp,syscall,tcp,udp,ws' DISSECTORS_UPDATING_ENABLED: 'true' DETECT_DUPLICATES: 'false' --- @@ -785,7 +785,7 @@ spec: containers: - env: - name: REACT_APP_DEFAULT_FILTER - value: '!dns and !tcp' + value: '!dns and !tcp and !udp and !icmp' - name: REACT_APP_AUTH_ENABLED value: 'true' - name: REACT_APP_AUTH_TYPE