From 96a6ac32517c7115363e443c4dfbcc703efdf994 Mon Sep 17 00:00:00 2001 From: gadotroee <55343099+gadotroee@users.noreply.github.com> Date: Thu, 29 Apr 2021 15:05:03 +0300 Subject: [PATCH] Small fixes - permission + har writing exception (#17) --- api/pkg/inserter/main.go | 2 +- tap/src/har_writer.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/api/pkg/inserter/main.go b/api/pkg/inserter/main.go index b9d61e1dd..02601cba6 100644 --- a/api/pkg/inserter/main.go +++ b/api/pkg/inserter/main.go @@ -18,7 +18,7 @@ import ( ) func StartReadingFiles(workingDir string) { - err := os.MkdirAll(workingDir, 777) + err := os.MkdirAll(workingDir, os.ModePerm) utils.CheckErr(err) for true { diff --git a/tap/src/har_writer.go b/tap/src/har_writer.go index cc38eb84e..108ee18c9 100644 --- a/tap/src/har_writer.go +++ b/tap/src/har_writer.go @@ -39,6 +39,10 @@ type HarFile struct { } func (f *HarFile) WriteEntry(request *http.Request, requestTime time.Time, response *http.Response, responseTime time.Time) { + // TODO: quick fix until TRA-3212 is implemented + if request.URL == nil || request.Method == "" { + return + } harRequest, err := har.NewRequest(request, true) if err != nil { SilentError("convert-request-to-har", "Failed converting request to HAR %s (%v,%+v)\n", err, err, err)