From 9868a7723a29dd551cecb91b18ad95eb2ec9ef57 Mon Sep 17 00:00:00 2001 From: "M. Mert Yildiran" Date: Thu, 2 Jun 2022 01:23:45 +0300 Subject: [PATCH] Remove two `TODO`s --- tap/extensions/http/main.go | 2 -- tap/tlstapper/tls_poller.go | 1 - 2 files changed, 3 deletions(-) diff --git a/tap/extensions/http/main.go b/tap/extensions/http/main.go index 71392bc1f..57bc134af 100644 --- a/tap/extensions/http/main.go +++ b/tap/extensions/http/main.go @@ -154,8 +154,6 @@ func (d dissecting) Dissect(b *bufio.Reader, reader api.TcpReader, options *api. } else if reader.GetIsClient() { var req *http.Request switchingProtocolsHTTP2, req, err = handleHTTP1ClientStream(b, reader.GetReadProgress(), reader.GetParent().GetOrigin(), reader.GetTcpID(), reader.GetCounterPair(), reader.GetCaptureTime(), reader.GetEmitter(), options, reqResMatcher) - // TODO: Golang TLS malformed HTTP request - fmt.Printf("HTTP req err: %v\n", err) if err == io.EOF || err == io.ErrUnexpectedEOF { break } else if err != nil { diff --git a/tap/tlstapper/tls_poller.go b/tap/tlstapper/tls_poller.go index 6ecdd7e85..991240d97 100644 --- a/tap/tlstapper/tls_poller.go +++ b/tap/tlstapper/tls_poller.go @@ -163,7 +163,6 @@ func (p *tlsPoller) pollGolangReadWrite(rd *ringbuf.Reader, emitter api.Emitter, if b.IsGzipChunk { connection.Gzipped = true - continue // TODO: accepting gzip makes everything malformed (temp) } if b.IsRequest {