github/kubeshark
1
0
Fork 0
mirror of https://github.com/kubeshark/kubeshark.git synced 2025-07-19 18:54:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove two TODOs

Browse Source
This commit is contained in:
M. Mert Yildiran 2022-06-02 01:23:45 +03:00
parent 9f6188a4cb
commit 9868a7723a
No known key found for this signature in database
GPG Key ID: D42ADB236521BF7A
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tap/extensions/http/main.go
View File

@ -154,8 +154,6 @@ func (d dissecting) Dissect(b *bufio.Reader, reader api.TcpReader, options *api.
} else if reader.GetIsClient() { } else if reader.GetIsClient() {
var req *http.Request var req *http.Request
switchingProtocolsHTTP2, req, err = handleHTTP1ClientStream(b, reader.GetReadProgress(), reader.GetParent().GetOrigin(), reader.GetTcpID(), reader.GetCounterPair(), reader.GetCaptureTime(), reader.GetEmitter(), options, reqResMatcher) switchingProtocolsHTTP2, req, err = handleHTTP1ClientStream(b, reader.GetReadProgress(), reader.GetParent().GetOrigin(), reader.GetTcpID(), reader.GetCounterPair(), reader.GetCaptureTime(), reader.GetEmitter(), options, reqResMatcher)
// TODO: Golang TLS malformed HTTP request
fmt.Printf("HTTP req err: %v\n", err)
if err == io.EOF || err == io.ErrUnexpectedEOF { if err == io.EOF || err == io.ErrUnexpectedEOF {
break break
} else if err != nil { } else if err != nil {

1
tap/tlstapper/tls_poller.go
View File

@ -163,7 +163,6 @@ func (p *tlsPoller) pollGolangReadWrite(rd *ringbuf.Reader, emitter api.Emitter,
if b.IsGzipChunk { if b.IsGzipChunk {
connection.Gzipped = true connection.Gzipped = true
continue // TODO: accepting gzip makes everything malformed (temp)
} }
if b.IsRequest { if b.IsRequest {