github/kubeshark
1
0
Fork 0
mirror of https://github.com/kubeshark/kubeshark.git synced 2025-06-22 22:39:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a leak in HTTP

Browse Source
This commit is contained in:
M. Mert Yildiran 2021-09-02 19:59:52 +03:00
parent 6700f156e8
commit 9d46820ff3
No known key found for this signature in database
GPG Key ID: D42ADB236521BF7A
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tap/extensions/http/handlers.go
View File

@ -79,13 +79,14 @@ func handleHTTP1ClientStream(b *bufio.Reader, tcpID *api.TcpID, counterPair *api
} }
counterPair.Request++ counterPair.Request++
defer req.Body.Close()
body, err := ioutil.ReadAll(req.Body) body, err := ioutil.ReadAll(req.Body)
req.Body = io.NopCloser(bytes.NewBuffer(body)) // rewind req.Body = io.NopCloser(bytes.NewBuffer(body)) // rewind
s := len(body) s := len(body)
if err != nil { if err != nil {
rlog.Debugf("[HTTP-request-body] stream %s Got body err: %s", tcpID.Ident, err) rlog.Debugf("[HTTP-request-body] stream %s Got body err: %s", tcpID.Ident, err)
} }
if err := req.Body.Close(); err != nil { if err := defer req.Body.Close(); err != nil {
rlog.Debugf("[HTTP-request-body-close] stream %s Failed to close request body: %s", tcpID.Ident, err) rlog.Debugf("[HTTP-request-body-close] stream %s Failed to close request body: %s", tcpID.Ident, err)
} }
encoding := req.Header["Content-Encoding"] encoding := req.Header["Content-Encoding"]
@ -121,13 +122,14 @@ func handleHTTP1ServerStream(b *bufio.Reader, tcpID *api.TcpID, counterPair *api
} }
counterPair.Response++ counterPair.Response++
defer res.Body.Close()
body, err := ioutil.ReadAll(res.Body) body, err := ioutil.ReadAll(res.Body)
res.Body = io.NopCloser(bytes.NewBuffer(body)) // rewind res.Body = io.NopCloser(bytes.NewBuffer(body)) // rewind
s := len(body) s := len(body)
if err != nil { if err != nil {
rlog.Debugf("[HTTP-response-body] HTTP/%s: failed to get body(parsed len:%d): %s", tcpID.Ident, s, err) rlog.Debugf("[HTTP-response-body] HTTP/%s: failed to get body(parsed len:%d): %s", tcpID.Ident, s, err)
} }
if err := res.Body.Close(); err != nil { if err := defer res.Body.Close(); err != nil {
rlog.Debugf("[HTTP-response-body-close] HTTP/%s: failed to close body(parsed len:%d): %s", tcpID.Ident, s, err) rlog.Debugf("[HTTP-response-body-close] HTTP/%s: failed to close body(parsed len:%d): %s", tcpID.Ident, s, err)
} }
sym := "," sym := ","