diff --git a/cli/apiserver/provider.go b/cli/apiserver/provider.go index 7a94d0659..6be4e8105 100644 --- a/cli/apiserver/provider.go +++ b/cli/apiserver/provider.go @@ -23,8 +23,8 @@ type Provider struct { client *http.Client } -const DefaultRetries = 20 -const DefaultTimeout = 5 * time.Second +const DefaultRetries = 3 +const DefaultTimeout = 2 * time.Second func NewProvider(url string, retries int, timeout time.Duration) *Provider { return &Provider{ @@ -36,16 +36,6 @@ func NewProvider(url string, retries int, timeout time.Duration) *Provider { } } -func NewProviderWithoutRetries(url string, timeout time.Duration) *Provider { - return &Provider{ - url: url, - retries: 1, - client: &http.Client{ - Timeout: timeout, - }, - } -} - func (provider *Provider) TestConnection() error { retriesLeft := provider.retries for retriesLeft > 0 { diff --git a/cli/cmd/checkRunner.go b/cli/cmd/checkRunner.go index 6f1fc25da..384068ed3 100644 --- a/cli/cmd/checkRunner.go +++ b/cli/cmd/checkRunner.go @@ -97,7 +97,7 @@ func checkServerConnection(kubernetesProvider *kubernetes.Provider) bool { serverUrl := GetApiServerUrl() - apiServerProvider := apiserver.NewProviderWithoutRetries(serverUrl, apiserver.DefaultTimeout) + apiServerProvider := apiserver.NewProvider(serverUrl, 1, apiserver.DefaultTimeout) if err := apiServerProvider.TestConnection(); err == nil { logger.Log.Infof("%v found Mizu server tunnel available and connected successfully to API server", fmt.Sprintf(uiUtils.Green, "√")) return true diff --git a/cli/cmd/common.go b/cli/cmd/common.go index 243409642..52707b70c 100644 --- a/cli/cmd/common.go +++ b/cli/cmd/common.go @@ -5,6 +5,10 @@ import ( "encoding/json" "errors" "fmt" + "path" + "regexp" + "time" + "github.com/up9inc/mizu/cli/apiserver" "github.com/up9inc/mizu/cli/config/configStructs" "github.com/up9inc/mizu/cli/errormessage" @@ -13,9 +17,6 @@ import ( "github.com/up9inc/mizu/cli/resources" "github.com/up9inc/mizu/cli/uiUtils" "github.com/up9inc/mizu/shared" - "path" - "regexp" - "time" "github.com/up9inc/mizu/cli/config" "github.com/up9inc/mizu/shared/kubernetes" @@ -35,10 +36,10 @@ func startProxyReportErrorIfAny(kubernetesProvider *kubernetes.Provider, ctx con return } - apiProvider = apiserver.NewProviderWithoutRetries(GetApiServerUrl(), time.Second) // short check for proxy + apiProvider = apiserver.NewProvider(GetApiServerUrl(), apiserver.DefaultRetries, apiserver.DefaultTimeout) if err := apiProvider.TestConnection(); err != nil { logger.Log.Debugf("Couldn't connect using proxy, stopping proxy and trying to create port-forward") - if err := httpServer.Shutdown(context.Background()); err != nil { + if err := httpServer.Shutdown(ctx); err != nil { logger.Log.Debugf("Error occurred while stopping proxy %v", errormessage.FormatError(err)) } @@ -50,7 +51,7 @@ func startProxyReportErrorIfAny(kubernetesProvider *kubernetes.Provider, ctx con return } - apiProvider = apiserver.NewProvider(GetApiServerUrl(), apiserver.DefaultRetries, apiserver.DefaultTimeout) // long check for port-forward + apiProvider = apiserver.NewProvider(GetApiServerUrl(), apiserver.DefaultRetries, apiserver.DefaultTimeout) if err := apiProvider.TestConnection(); err != nil { logger.Log.Errorf(uiUtils.Error, fmt.Sprintf("Couldn't connect to API server, for more info check logs at %s", fsUtils.GetLogFilePath())) cancel()