diff --git a/tap/passive_tapper.go b/tap/passive_tapper.go index 2930cf284..8726f6301 100644 --- a/tap/passive_tapper.go +++ b/tap/passive_tapper.go @@ -216,7 +216,6 @@ func startMemoryProfiler() { } func closeTimedoutTcpStreamChannels() { - maxNumberOfGoroutines = GetMaxNumberOfGoroutines() TcpStreamChannelTimeoutMs := GetTcpChannelTimeoutMs() for { _debug.FreeOSMemory() diff --git a/tap/settings.go b/tap/settings.go index 173656a85..f2decd0de 100644 --- a/tap/settings.go +++ b/tap/settings.go @@ -13,11 +13,9 @@ const ( MaxBufferedPagesTotalEnvVarName = "MAX_BUFFERED_PAGES_TOTAL" MaxBufferedPagesPerConnectionEnvVarName = "MAX_BUFFERED_PAGES_PER_CONNECTION" TcpStreamChannelTimeoutMsEnvVarName = "TCP_STREAM_CHANNEL_TIMEOUT_MS" - MaxNumberOfGoroutinesEnvVarName = "MAX_NUMBER_OF_GOROUTINES" MaxBufferedPagesTotalDefaultValue = 5000 MaxBufferedPagesPerConnectionDefaultValue = 5000 TcpStreamChannelTimeoutMsDefaultValue = 5000 - MaxNumberOfGoroutinesDefaultValue = 4000 ) type globalSettings struct { @@ -62,14 +60,6 @@ func GetTcpChannelTimeoutMs() time.Duration { return time.Duration(valueFromEnv) * time.Millisecond } -func GetMaxNumberOfGoroutines() int { - valueFromEnv, err := strconv.Atoi(os.Getenv(MaxNumberOfGoroutinesEnvVarName)) - if err != nil { - return MaxNumberOfGoroutinesDefaultValue - } - return valueFromEnv -} - func GetMemoryProfilingEnabled() bool { return os.Getenv(MemoryProfilingEnabledEnvVarName) == "1" } diff --git a/tap/tcp_stream_factory.go b/tap/tcp_stream_factory.go index e14e8860f..ad042556b 100644 --- a/tap/tcp_stream_factory.go +++ b/tap/tcp_stream_factory.go @@ -2,7 +2,6 @@ package tap import ( "fmt" - "runtime" "sync" "time" @@ -33,8 +32,6 @@ type tcpStreamWrapper struct { var streams *sync.Map = &sync.Map{} // global var streamId int64 = 0 -var maxNumberOfGoroutines int - func (factory *tcpStreamFactory) New(net, transport gopacket.Flow, tcp *layers.TCP, ac reassembly.AssemblerContext) reassembly.Stream { rlog.Debugf("* NEW: %s %s", net, transport) fsmOptions := reassembly.TCPSimpleFSMOptions{ @@ -61,11 +58,6 @@ func (factory *tcpStreamFactory) New(net, transport gopacket.Flow, tcp *layers.T superIdentifier: &api.SuperIdentifier{}, } if stream.isTapTarget { - if runtime.NumGoroutine() > maxNumberOfGoroutines { - appStats.IncDroppedTcpStreams() - rlog.Debugf("Dropped a TCP stream because of load. Total dropped: %d Total Goroutines: %d\n", appStats.DroppedTcpStreams, runtime.NumGoroutine()) - return stream - } streamId++ stream.id = streamId for i, extension := range extensions {