From b2abd7b990eb6bd6b14372b2f14f34e28248d572 Mon Sep 17 00:00:00 2001 From: "M. Mert Yildiran" Date: Fri, 27 Aug 2021 05:06:01 +0300 Subject: [PATCH] Set `isTapTarget` to always `true` again since `filterAuthorities` implementation has problems --- tap/tcp_stream_factory.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tap/tcp_stream_factory.go b/tap/tcp_stream_factory.go index 2e17b7ea4..2d0f50fdf 100644 --- a/tap/tcp_stream_factory.go +++ b/tap/tcp_stream_factory.go @@ -102,6 +102,8 @@ func (factory *tcpStreamFactory) WaitGoRoutines() { func (factory *tcpStreamFactory) getStreamProps(srcIP string, dstIP string, dstPort string) *streamProps { if hostMode { + // TODO: Fix `filterAuthorities` logic or value. Default `isTapTarget: true` causes; + // RabbitMQ server->client pushes to not show up for example. Where the client is the tapped pod. if inArrayString(gSettings.filterAuthorities, fmt.Sprintf("%s:%s", dstIP, dstPort)) { rlog.Debugf("getStreamProps %s", fmt.Sprintf("+ host1 %s:%s", dstIP, dstPort)) return &streamProps{isTapTarget: true, isOutgoing: false} @@ -112,7 +114,7 @@ func (factory *tcpStreamFactory) getStreamProps(srcIP string, dstIP string, dstP rlog.Debugf("getStreamProps %s", fmt.Sprintf("+ host3 %s", srcIP)) return &streamProps{isTapTarget: true, isOutgoing: true} } - return &streamProps{isTapTarget: false} + return &streamProps{isTapTarget: true, isOutgoing: false} } else { isOutgoing := !inArrayString(ownIps, dstIP)