github/kubeshark
1
0
Fork 0
mirror of https://github.com/kubeshark/kubeshark.git synced 2025-08-02 00:57:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

added semver isvalid check in version update checker (#338)

Browse Source
This commit is contained in:
RoyUP9 2021-10-11 11:32:41 +03:00 committed by GitHub
parent 9d378ed75b
commit ba6b5c868c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cli/mizu/version/versionCheck.go
View File

@ -75,6 +75,12 @@ func CheckNewerVersion(versionChan chan string) {
gitHubVersionSemVer := semver.SemVersion(gitHubVersion) gitHubVersionSemVer := semver.SemVersion(gitHubVersion)
currentSemVer := semver.SemVersion(mizu.SemVer) currentSemVer := semver.SemVersion(mizu.SemVer)
if !gitHubVersionSemVer.IsValid() || !currentSemVer.IsValid() {
logger.Log.Debugf("[ERROR] Semver version is not valid, github version %v, current version %v", gitHubVersion, currentSemVer)
versionChan <- ""
return
}
logger.Log.Debugf("Finished version validation, github version %v, current version %v, took %v", gitHubVersion, currentSemVer, time.Since(start)) logger.Log.Debugf("Finished version validation, github version %v, current version %v, took %v", gitHubVersion, currentSemVer, time.Since(start))
if gitHubVersionSemVer.GreaterThan(currentSemVer) { if gitHubVersionSemVer.GreaterThan(currentSemVer) {

8
shared/semver/semver.go
View File

@ -6,9 +6,17 @@ import (
type SemVersion string type SemVersion string
func (v SemVersion) IsValid() bool {
re := regexp.MustCompile(`\d+`)
breakdown := re.FindAllString(string(v), 3)
return len(breakdown) == 3
}
func (v SemVersion) Breakdown() (string, string, string) { func (v SemVersion) Breakdown() (string, string, string) {
re := regexp.MustCompile(`\d+`) re := regexp.MustCompile(`\d+`)
breakdown := re.FindAllString(string(v), 3) breakdown := re.FindAllString(string(v), 3)
return breakdown[0], breakdown[1], breakdown[2] return breakdown[0], breakdown[1], breakdown[2]
} }