From ee63247888fc639128a43256f6406db7cdf72175 Mon Sep 17 00:00:00 2001 From: nimrod-up9 <59927337+nimrod-up9@users.noreply.github.com> Date: Sun, 9 May 2021 14:09:39 +0300 Subject: [PATCH] Removed flags without implementation (#38) --- cli/cmd/tap.go | 3 --- cli/config/config.go | 1 - cli/mizu/mizuRunner.go | 4 +--- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/cli/cmd/tap.go b/cli/cmd/tap.go index 6de369e8d..6985d9422 100644 --- a/cli/cmd/tap.go +++ b/cli/cmd/tap.go @@ -31,11 +31,8 @@ var tapCmd = &cobra.Command{ func init() { rootCmd.AddCommand(tapCmd) - // tapCmd.Flags().BoolVarP(&config.Configuration.Quiet, "quiet", "q", false, "No stdout output") - tapCmd.Flags().BoolVarP(&config.Configuration.NoGUI, "no-gui", "", false, "Do not open web interface") tapCmd.Flags().Uint16VarP(&config.Configuration.GuiPort, "gui-port", "p", 8899, "Provide a custom port for the web interface webserver") tapCmd.Flags().StringVarP(&config.Configuration.Namespace, "namespace", "n", "", "Namespace selector") - // tapCmd.Flags().BoolVarP(&config.Configuration.AllNamespaces, "all-namespaces", "A", false, "Select all namespaces") tapCmd.Flags().StringVarP(&config.Configuration.KubeConfigPath, "kubeconfig", "k", "", "Path to kubeconfig file") tapCmd.Flags().StringVarP(&config.Configuration.MizuImage, "mizu-image", "", "gcr.io/up9-docker-hub/mizu/develop:latest", "Custom image for mizu collector") tapCmd.Flags().Uint16VarP(&config.Configuration.MizuPodPort, "mizu-port", "", 8899, "Port which mizu cli will attempt to forward from the mizu collector pod") diff --git a/cli/config/config.go b/cli/config/config.go index 6183d8ebf..7fd0825f8 100644 --- a/cli/config/config.go +++ b/cli/config/config.go @@ -1,7 +1,6 @@ package config type Options struct { - NoGUI bool GuiPort uint16 Namespace string KubeConfigPath string diff --git a/cli/mizu/mizuRunner.go b/cli/mizu/mizuRunner.go index ca015d91e..254563f13 100644 --- a/cli/mizu/mizuRunner.go +++ b/cli/mizu/mizuRunner.go @@ -76,9 +76,7 @@ func createPodAndPortForward(ctx context.Context, kubernetesProvider *kubernetes isPodReady = true var err error portForward, err = kubernetes.NewPortForward(kubernetesProvider, kubernetesProvider.Namespace, podName, config.Configuration.GuiPort, config.Configuration.MizuPodPort, cancel) - if !config.Configuration.NoGUI { - fmt.Printf("Web interface is now available at http://localhost:%d\n", config.Configuration.GuiPort) - } + fmt.Printf("Web interface is now available at http://localhost:%d\n", config.Configuration.GuiPort) if err != nil { fmt.Printf("error forwarding port to pod %s\n", err) cancel()