From 0bbfdaf3d5638c40ac10e198eea24f9ceaba4e6e Mon Sep 17 00:00:00 2001 From: Mason Daugherty Date: Mon, 28 Jul 2025 10:23:42 -0400 Subject: [PATCH] `make test` -> `make unit_test` --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- .github/copilot-instructions.md | 2 +- .github/workflows/_test.yml | 4 ++-- .github/workflows/_test_pydantic.yml | 4 ++-- docs/docs/contributing/how_to/code/setup.mdx | 6 +++--- docs/docs/contributing/how_to/testing.mdx | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b99fdd92cc3..aa5d8dbcf0a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -22,7 +22,7 @@ Thank you for contributing to LangChain! Follow these steps to mark your pull re 1. A test for the integration, preferably unit tests that do not rely on network access, 2. An example notebook showing its use. It lives in `docs/docs/integrations` directory. -- [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. **We will not consider a PR unless these three are passing in CI.** See [contribution guidelines](https://python.langchain.com/docs/contributing/) for more. +- [ ] **Lint and test**: Run `make format`, `make lint` and `make unit_test` from the root of the package(s) you've modified. **We will not consider a PR unless these three are passing in CI.** See [contribution guidelines](https://python.langchain.com/docs/contributing/) for more. Additional guidelines: diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index b12f23edb2e..bb53e16bbcb 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -239,7 +239,7 @@ uv lock ```bash # Run unit tests (no network) -make test +make unit_test # Don't run integration tests, as API keys must be set diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index 0deb2b53592..8a0426122b1 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -46,7 +46,7 @@ jobs: - name: '🧪 Run Core Unit Tests' shell: bash run: | - make test + make unit_test - name: '🔍 Calculate Minimum Dependency Versions' working-directory: ${{ inputs.working-directory }} @@ -79,4 +79,4 @@ jobs: # grep will exit non-zero if the target message isn't found, # and `set -e` above will cause the step to fail. echo "$STATUS" | grep 'nothing to commit, working tree clean' - + diff --git a/.github/workflows/_test_pydantic.yml b/.github/workflows/_test_pydantic.yml index a6b6b183755..0394dd6958b 100644 --- a/.github/workflows/_test_pydantic.yml +++ b/.github/workflows/_test_pydantic.yml @@ -52,7 +52,7 @@ jobs: - name: '🧪 Run Core Tests' shell: bash run: | - make test + make unit_test - name: '🧹 Verify Clean Working Directory' shell: bash @@ -64,4 +64,4 @@ jobs: # grep will exit non-zero if the target message isn't found, # and `set -e` above will cause the step to fail. - echo "$STATUS" | grep 'nothing to commit, working tree clean' \ No newline at end of file + echo "$STATUS" | grep 'nothing to commit, working tree clean' diff --git a/docs/docs/contributing/how_to/code/setup.mdx b/docs/docs/contributing/how_to/code/setup.mdx index 9ba53d52242..6bd390da428 100644 --- a/docs/docs/contributing/how_to/code/setup.mdx +++ b/docs/docs/contributing/how_to/code/setup.mdx @@ -48,7 +48,7 @@ uv sync Then verify dependency installation: ```bash -make test +make unit_test ``` ## Testing @@ -61,7 +61,7 @@ If you add new logic, please add a unit test. To run unit tests: ```bash -make test +make unit_test ``` There are also [integration tests and code-coverage](../testing.mdx) available. @@ -72,7 +72,7 @@ If you are only developing `langchain_core`, you can simply install the dependen ```bash cd libs/core -make test +make unit_test ``` ## Formatting and linting diff --git a/docs/docs/contributing/how_to/testing.mdx b/docs/docs/contributing/how_to/testing.mdx index cc5a1155c32..b7e6659ecfc 100644 --- a/docs/docs/contributing/how_to/testing.mdx +++ b/docs/docs/contributing/how_to/testing.mdx @@ -24,13 +24,13 @@ poetry install --with test To run unit tests: ```bash -make test +make unit_test ``` To run a specific test: ```bash -TEST_FILE=tests/unit_tests/test_imports.py make test +TEST_FILE=tests/unit_tests/test_imports.py make unit_test ``` ## Integration tests