mirror of
https://github.com/hwchase17/langchain.git
synced 2025-08-19 01:21:50 +00:00
google-genai[patch]: on_llm_new_token fix (#16924)
### This pull request makes the following changes: * Fixed issue #16913 Fixed the google gen ai chat_models.py code to make sure that the callback is called before the token is yielded <!-- Thank you for contributing to LangChain! Please title your PR "<package>: <description>", where <package> is whichever of langchain, community, core, experimental, etc. is being modified. Replace this entire comment with: - **Description:** a description of the change, - **Issue:** the issue # it fixes if applicable, - **Dependencies:** any dependencies required for this change, - **Twitter handle:** we announce bigger features on Twitter. If your PR gets announced, and you'd like a mention, we'll gladly shout you out! Please make sure your PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` from the root of the package you've modified to check this locally. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/ If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17. --> --------- Co-authored-by: Erick Friis <erick@langchain.dev>
This commit is contained in:
parent
10c10f2dea
commit
183daa6e6f
@ -598,6 +598,7 @@ class ChatGoogleGenerativeAI(_BaseGoogleGenerativeAI, BaseChatModel):
|
||||
for chunk in response:
|
||||
_chat_result = _response_to_result(chunk, stream=True)
|
||||
gen = cast(ChatGenerationChunk, _chat_result.generations[0])
|
||||
|
||||
if run_manager:
|
||||
run_manager.on_llm_new_token(gen.text)
|
||||
yield gen
|
||||
@ -622,6 +623,7 @@ class ChatGoogleGenerativeAI(_BaseGoogleGenerativeAI, BaseChatModel):
|
||||
):
|
||||
_chat_result = _response_to_result(chunk, stream=True)
|
||||
gen = cast(ChatGenerationChunk, _chat_result.generations[0])
|
||||
|
||||
if run_manager:
|
||||
await run_manager.on_llm_new_token(gen.text)
|
||||
yield gen
|
||||
|
Loading…
Reference in New Issue
Block a user