From 18acc22f292314c318d12c1a3c41492f37b38b66 Mon Sep 17 00:00:00 2001 From: Erick Friis Date: Mon, 13 Nov 2023 10:28:47 -0800 Subject: [PATCH] Ollama pass kwargs as options instead of top (#13280) Noticed params are really in `options` instead while reviewing #12895 --- libs/langchain/langchain/llms/ollama.py | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libs/langchain/langchain/llms/ollama.py b/libs/langchain/langchain/llms/ollama.py index 8f5e3035100..43451e12fe7 100644 --- a/libs/langchain/langchain/llms/ollama.py +++ b/libs/langchain/langchain/llms/ollama.py @@ -136,8 +136,21 @@ class _OllamaCommon(BaseLanguageModel): stop = self.stop elif stop is None: stop = [] - params = {**self._default_params, **kwargs} - params["options"]["stop"] = stop + + params = self._default_params + + if "model" in kwargs: + params["model"] = kwargs["model"] + + if "options" in kwargs: + params["options"] = kwargs["options"] + else: + params["options"] = { + **params["options"], + "stop": stop, + **kwargs, + } + response = requests.post( url=f"{self.base_url}/api/generate/", headers={"Content-Type": "application/json"},