From 1985aaf095007f86b1d04064ab596e071a80b63c Mon Sep 17 00:00:00 2001 From: Matthew Farrellee Date: Mon, 17 Mar 2025 18:37:16 -0500 Subject: [PATCH] langchain-tests: allow subclasses to add addition, non-standard tests (#30204) **description:** the ChatModel[Integration]Tests classes are powerful and helpful, this change allows sub-classes to add additional tests. for instance, ``` class TestChatMyServiceIntegration(ChatModelIntegrationTests): ... def test_myservice(self, model: BaseChatModel) -> None: ... ``` --------- Co-authored-by: ccurme --- libs/standard-tests/langchain_tests/base.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libs/standard-tests/langchain_tests/base.py b/libs/standard-tests/langchain_tests/base.py index df99a39b71d..1f138ebc546 100644 --- a/libs/standard-tests/langchain_tests/base.py +++ b/libs/standard-tests/langchain_tests/base.py @@ -41,14 +41,12 @@ class BaseStandardTests(ABC): base_tests = set( [method for method in dir(comparison_class) if method.startswith("test_")] ) - non_standard_tests = running_tests - base_tests - assert not non_standard_tests, f"Non-standard tests found: {non_standard_tests}" deleted_tests = base_tests - running_tests assert not deleted_tests, f"Standard tests deleted: {deleted_tests}" overridden_tests = [ method - for method in running_tests + for method in base_tests if getattr(self.__class__, method) is not getattr(comparison_class, method) ]