github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-06-23 23:29:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

community[patch]: fix a bug that mistakenly handle zip iterator in FAISS.from_embeddings (#16020)

Browse Source 
**Description**: `zip` is iterator that will only produce result once,
so the previous code will cause the `embeddings` to be an empty list.

**Issue**: I could not find a related issue.

**Dependencies**: this PR does not introduce or affect dependencies.

---------

Co-authored-by: Bagatur <baskaryan@gmail.com>
This commit is contained in:
Neo Zhao 2024-01-16 03:13:14 +08:00 committed by GitHub
parent 15c2b4a47e
commit 21e0df937f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libs/community/langchain_community/vectorstores/faiss.py
View File

@ -986,11 +986,10 @@ class FAISS(VectorStore):
text_embedding_pairs = zip(texts, text_embeddings) text_embedding_pairs = zip(texts, text_embeddings)
faiss = FAISS.from_embeddings(text_embedding_pairs, embeddings) faiss = FAISS.from_embeddings(text_embedding_pairs, embeddings)
""" """
texts = [t[0] for t in text_embeddings] texts, embeddings = zip(*text_embeddings)
embeddings = [t[1] for t in text_embeddings]
return cls.__from( return cls.__from(
texts, list(texts),
embeddings, list(embeddings),
embedding, embedding,
metadatas=metadatas, metadatas=metadatas,
ids=ids, ids=ids,