github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-09-14 14:05:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

standard-tests: Fix ToolsIntegrationTests to correctly handle "content_and_artifact" tools (#29391)

Browse Source 
**Description:**

The response from `tool.invoke()` is always a ToolMessage, with content
and artifact fields, not a tuple.
The tuple is converted to a ToolMessage here

b6ae7ca91d/libs/core/langchain_core/tools/base.py (L726)

**Issue:**

Currently `ToolsIntegrationTests` requires `invoke()` to return a tuple
and so standard tests fail for "content_and_artifact" tools. This fixes
that to check the returned ToolMessage.

This PR also adds a test that now passes.
This commit is contained in:
Andrew Wason
2025-02-05 21:27:09 -05:00
committed by GitHub
parent f849305a56
commit 22aa5e07ed
2 changed files with 43 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
libs/standard-tests/langchain_tests/integration_tests/tools.py
View File

@@ -29,15 +29,10 @@ class ToolsIntegrationTests(ToolsTests):
)
result = tool.invoke(tool_call)
if tool.response_format == "content":
tool_message = result
elif tool.response_format == "content_and_artifact":
# should be (content, artifact)
assert isinstance(result, tuple)
assert len(result) == 2
tool_message, artifact = result
assert artifact # artifact can be anything, but shouldn't be none
tool_message = result
if tool.response_format == "content_and_artifact":
# artifact can be anything, except none
assert tool_message.artifact is not None
# check content is a valid ToolMessage content
assert isinstance(tool_message.content, (str, list))
@@ -59,15 +54,10 @@ class ToolsIntegrationTests(ToolsTests):
)
result = await tool.ainvoke(tool_call)
if tool.response_format == "content":
tool_message = result
elif tool.response_format == "content_and_artifact":
# should be (content, artifact)
assert isinstance(result, tuple)
assert len(result) == 2
tool_message, artifact = result
assert artifact # artifact can be anything, but shouldn't be none
tool_message = result
if tool.response_format == "content_and_artifact":
# artifact can be anything, except none
assert tool_message.artifact is not None
# check content is a valid ToolMessage content
assert isinstance(tool_message.content, (str, list))