core: Make Graph.Node.data optional (#30943)

Thank you for contributing to LangChain!

- [ ] **PR title**: "package: description"
- Where "package" is whichever of langchain, community, core, etc. is
being modified. Use "docs: ..." for purely docs changes, "infra: ..."
for CI changes.
  - Example: "community: add foobar LLM"


- [ ] **PR message**: ***Delete this entire checklist*** and replace
with
    - **Description:** a description of the change
    - **Issue:** the issue # it fixes, if applicable
    - **Dependencies:** any dependencies required for this change
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!


- [ ] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.


- [ ] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.

If no one reviews your PR within a few days, please @-mention one of
baskaryan, eyurtsev, ccurme, vbarda, hwchase17.
This commit is contained in:
Nuno Campos 2025-04-21 07:18:36 -07:00 committed by GitHub
parent 0e9d0dbc10
commit 27296bdb0c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -108,7 +108,7 @@ class Node(NamedTuple):
id: str id: str
name: str name: str
data: Union[type[BaseModel], RunnableType] data: Union[type[BaseModel], RunnableType, None]
metadata: Optional[dict[str, Any]] metadata: Optional[dict[str, Any]]
def copy(self, *, id: Optional[str] = None, name: Optional[str] = None) -> Node: def copy(self, *, id: Optional[str] = None, name: Optional[str] = None) -> Node:
@ -181,7 +181,7 @@ class MermaidDrawMethod(Enum):
API = "api" # Uses Mermaid.INK API to render the graph API = "api" # Uses Mermaid.INK API to render the graph
def node_data_str(id: str, data: Union[type[BaseModel], RunnableType]) -> str: def node_data_str(id: str, data: Union[type[BaseModel], RunnableType, None]) -> str:
"""Convert the data of a node to a string. """Convert the data of a node to a string.
Args: Args:
@ -193,7 +193,7 @@ def node_data_str(id: str, data: Union[type[BaseModel], RunnableType]) -> str:
""" """
from langchain_core.runnables.base import Runnable from langchain_core.runnables.base import Runnable
if not is_uuid(id): if not is_uuid(id) or data is None:
return id return id
data_str = data.get_name() if isinstance(data, Runnable) else data.__name__ data_str = data.get_name() if isinstance(data, Runnable) else data.__name__
return data_str if not data_str.startswith("Runnable") else data_str[8:] return data_str if not data_str.startswith("Runnable") else data_str[8:]
@ -215,8 +215,10 @@ def node_data_json(
from langchain_core.load.serializable import to_json_not_implemented from langchain_core.load.serializable import to_json_not_implemented
from langchain_core.runnables.base import Runnable, RunnableSerializable from langchain_core.runnables.base import Runnable, RunnableSerializable
if isinstance(node.data, RunnableSerializable): if node.data is None:
json: dict[str, Any] = { json: dict[str, Any] = {}
elif isinstance(node.data, RunnableSerializable):
json = {
"type": "runnable", "type": "runnable",
"data": { "data": {
"id": node.data.lc_id(), "id": node.data.lc_id(),
@ -317,7 +319,7 @@ class Graph:
def add_node( def add_node(
self, self,
data: Union[type[BaseModel], RunnableType], data: Union[type[BaseModel], RunnableType, None],
id: Optional[str] = None, id: Optional[str] = None,
*, *,
metadata: Optional[dict[str, Any]] = None, metadata: Optional[dict[str, Any]] = None,