From 32db24222794b558d31390da8b77869996d3bdc4 Mon Sep 17 00:00:00 2001 From: Mason Daugherty Date: Mon, 16 Mar 2026 10:50:33 -0400 Subject: [PATCH] fix(model-profiles): use posix-compatible substitution in makefile (#35957) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `refresh_model_profiles` CI workflow has been failing daily since the `refresh-profiles` Makefile target was added. `make` runs recipes with `/bin/sh`, which is dash on Ubuntu CI runners — and `${var//pattern/replacement}` is a bash-only construct that dash rejects with `Bad substitution`. ## Changes - Replace bash-ism `$${partner//-/_}` with POSIX-compatible `$$(echo "$${partner}" | tr '-' '_')` in the `refresh-profiles` target's `data_dir` construction --- libs/model-profiles/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/model-profiles/Makefile b/libs/model-profiles/Makefile index 4a0d23bab22..d7212cb0bb3 100644 --- a/libs/model-profiles/Makefile +++ b/libs/model-profiles/Makefile @@ -30,7 +30,7 @@ refresh-profiles: @for entry in $(PROFILE_PROVIDERS); do \ partner=$${entry%%=*}; \ provider=$${entry##*=}; \ - data_dir="../partners/$${partner}/langchain_$${partner//-/_}/data"; \ + data_dir="../partners/$${partner}/langchain_$$(echo "$${partner}" | tr '-' '_')/data"; \ echo "--- Refreshing $${partner} (provider: $${provider}) ---"; \ echo y | UV_FROZEN=false uv run langchain-profiles refresh \ --provider "$${provider}" \