github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-16 08:06:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove unneeded xfail overrides ollama

Browse Source
This commit is contained in:
Mason Daugherty 2025-08-06 16:55:03 -04:00
parent f7b93f2062
commit 33dc43f1f4
No known key found for this signature in database
1 changed files with 4 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
libs/partners/ollama/tests/integration_tests/v1/chat_models/test_chat_models_standard_v1.py
View File

@ -159,29 +159,10 @@ class TestChatOllamaV1(ChatModelV1IntegrationTests):
assert final_tool_call["id"] == tool_call_id assert final_tool_call["id"] == tool_call_id
@pytest.mark.xfail( @pytest.mark.xfail(
reason=( reason=("Ollama does not yet support tool_choice forcing, may be unreliable")
"Will sometime encounter AssertionErrors where tool responses are "
"`'3'` instead of `3`"
)
)
def test_tool_calling(self, model: BaseChatModel) -> None:
super().test_tool_calling(model)
@pytest.mark.xfail(
reason=(
"Will sometime encounter AssertionErrors where tool responses are "
"`'3'` instead of `3`"
)
)
async def test_tool_calling_async(self, model: BaseChatModel) -> None:
await super().test_tool_calling_async(model)
@pytest.mark.xfail(
reason=(
"Ollama does not support tool_choice forcing, tool calls may be unreliable"
)
) )
def test_tool_calling_with_no_arguments(self, model: BaseChatModel) -> None: def test_tool_calling_with_no_arguments(self, model: BaseChatModel) -> None:
# TODO: shouldn't need to xfail this
super().test_tool_calling_with_no_arguments(model) super().test_tool_calling_with_no_arguments(model)
@pytest.mark.xfail( @pytest.mark.xfail(
@ -208,14 +189,9 @@ class TestChatOllamaV1(ChatModelV1IntegrationTests):
if not self.supports_multimodal_reasoning: if not self.supports_multimodal_reasoning:
pytest.skip("Model does not support multimodal reasoning.") pytest.skip("Model does not support multimodal reasoning.")
# For multimodal reasoning, we need a model that supports both images
# and reasoning.
# TODO: Update this when we have a model that supports both multimodal
# and reasoning.
pytest.skip( pytest.skip(
"No single model available that supports both multimodal content " "TODO: Update this when we have a model that supports both multimodal and "
"and reasoning." "reasoning."
) )
@pytest.mark.xfail( @pytest.mark.xfail(